This change fixes possibly invalid access to the internal data structure during library shutdown. In a heavily oversubscribed situation, the library shutdown sequence can reach the point where resources are deallocated while there still exist threads in their final spinning loop. The added loop in __kmp_internal_end() checks if there are such busy-waiting threads and blocks the shutdown sequence if that is the case. Two versions of kmp_wait_template() are now used to minimize performance impact. Patch by Hansang Bae Differential Revision: https://reviews.llvm.org/D49452 llvm-svn: 337486
27 lines
892 B
C++
27 lines
892 B
C++
/*
|
|
* kmp_wait_release.cpp -- Wait/Release implementation
|
|
*/
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is dual licensed under the MIT and the University of Illinois Open
|
|
// Source Licenses. See LICENSE.txt for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "kmp_wait_release.h"
|
|
|
|
void __kmp_wait_64(kmp_info_t *this_thr, kmp_flag_64 *flag,
|
|
int final_spin USE_ITT_BUILD_ARG(void *itt_sync_obj)) {
|
|
if (final_spin)
|
|
__kmp_wait_template<kmp_flag_64, TRUE>(
|
|
this_thr, flag USE_ITT_BUILD_ARG(itt_sync_obj));
|
|
else
|
|
__kmp_wait_template<kmp_flag_64, FALSE>(
|
|
this_thr, flag USE_ITT_BUILD_ARG(itt_sync_obj));
|
|
}
|
|
|
|
void __kmp_release_64(kmp_flag_64 *flag) { __kmp_release_template(flag); }
|