0628bea513
This broke Chromium's PGO build, it seems because hot-cold-splitting got turned
on unintentionally. See comment on the code review for repro etc.
> This patch adds -f[no-]split-cold-code CC1 options to clang. This allows
> the splitting pass to be toggled on/off. The current method of passing
> `-mllvm -hot-cold-split=true` to clang isn't ideal as it may not compose
> correctly (say, with `-O0` or `-Oz`).
>
> To implement the -fsplit-cold-code option, an attribute is applied to
> functions to indicate that they may be considered for splitting. This
> removes some complexity from the old/new PM pipeline builders, and
> behaves as expected when LTO is enabled.
>
> Co-authored by: Saleem Abdulrasool <compnerd@compnerd.org>
> Differential Revision: https://reviews.llvm.org/D57265
> Reviewed By: Aditya Kumar, Vedant Kumar
> Reviewers: Teresa Johnson, Aditya Kumar, Fedor Sergeev, Philip Pfaffe, Vedant Kumar
This reverts commit 273c299d5d.
100 lines
2.1 KiB
LLVM
100 lines
2.1 KiB
LLVM
; RUN: opt -S -hotcoldsplit -hotcoldsplit-threshold=0 < %s | FileCheck %s
|
|
|
|
target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
|
|
target triple = "x86_64-apple-macosx10.14.0"
|
|
|
|
; CHECK-LABEL: define {{.*}}@foo(
|
|
; CHECK: landingpad
|
|
; CHECK: sideeffect(i32 2)
|
|
define void @foo(i32 %cond) personality i8 0 {
|
|
entry:
|
|
invoke void @llvm.donothing() to label %normal unwind label %exception
|
|
|
|
exception:
|
|
; Note: EH pads are not candidates for region entry points.
|
|
%cleanup = landingpad i8 cleanup
|
|
br label %continue_exception
|
|
|
|
continue_exception:
|
|
call void @sideeffect(i32 0)
|
|
call void @sink()
|
|
ret void
|
|
|
|
normal:
|
|
call void @sideeffect(i32 2)
|
|
ret void
|
|
}
|
|
|
|
; See llvm.org/PR39917. It's currently not safe to outline landingpad
|
|
; instructions.
|
|
;
|
|
; CHECK-LABEL: define {{.*}}@bar(
|
|
; CHECK: landingpad
|
|
define void @bar(i32 %cond) personality i8 0 {
|
|
entry:
|
|
br i1 undef, label %exit, label %continue
|
|
|
|
exit:
|
|
ret void
|
|
|
|
continue:
|
|
invoke void @sink() to label %normal unwind label %exception
|
|
|
|
exception:
|
|
; Note: EH pads are not candidates for region entry points.
|
|
%cleanup = landingpad i8 cleanup
|
|
br label %trivial-eh-handler
|
|
|
|
trivial-eh-handler:
|
|
call void @sideeffect(i32 1)
|
|
br label %normal
|
|
|
|
normal:
|
|
call void @sideeffect(i32 0)
|
|
ret void
|
|
}
|
|
|
|
define void @baz() personality i8 0 {
|
|
entry:
|
|
br i1 undef, label %exit, label %cold1
|
|
|
|
exit:
|
|
ret void
|
|
|
|
cold1:
|
|
; The predecessor of a cold invoke may still be extracted (see baz.cold.2).
|
|
call void @sideeffect(i32 0)
|
|
br label %cold2
|
|
|
|
cold2:
|
|
invoke void @sink() to label %cold3 unwind label %cold4
|
|
|
|
cold3:
|
|
; The successor of a cold invoke may still be extracted (see baz.cold.1).
|
|
call void @sideeffect(i32 1)
|
|
ret void
|
|
|
|
cold4:
|
|
landingpad i8 cleanup
|
|
ret void
|
|
}
|
|
|
|
; CHECK-LABEL: define {{.*}}@foo.cold.1(
|
|
; CHECK: sideeffect(i32 0)
|
|
; CHECK: sink
|
|
|
|
; CHECK-LABEL: define {{.*}}@bar.cold.1(
|
|
; CHECK: sideeffect(i32 1)
|
|
|
|
; CHECK-LABEL: define {{.*}}@baz.cold.1(
|
|
; CHECK: sideeffect(i32 1)
|
|
|
|
; CHECK-LABEL: define {{.*}}@baz.cold.2(
|
|
; CHECK: sideeffect(i32 0)
|
|
|
|
declare void @sideeffect(i32)
|
|
|
|
declare void @sink() cold
|
|
|
|
declare void @llvm.donothing() nounwind readnone
|