539117616d
This affects -gmodules only.
Under normal operation pcm_type is a shallow forward declaration
that gets completed later. This is necessary to support cyclic
data structures. If, however, pcm_type is already complete (for
example, because it was loaded for a different target before),
the definition needs to be imported right away, too.
Type::ResolveClangType() effectively ignores the ResolveState
inside type_sp and only looks at IsDefined(), so it never calls
ClangASTImporter::ASTImporterDelegate::ImportDefinitionTo(),
which does extra work for Objective-C classes. This would result
in only the forward declaration to be visible.
An alternative implementation would be to sink this into Type::ResolveClangType ( 88235812a7/lldb/source/Symbol/Type.cpp (L5809)) though it isn't clear to me how to best do this from a layering perspective.
rdar://problem/52134074
Differential Revision: https://reviews.llvm.org/D70415
62 lines
2.0 KiB
Python
62 lines
2.0 KiB
Python
from __future__ import print_function
|
|
|
|
import unittest2
|
|
import os
|
|
import shutil
|
|
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class TestClangModuleAppUpdate(TestBase):
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
def setUp(self):
|
|
TestBase.setUp(self)
|
|
|
|
@skipUnlessDarwin
|
|
@skipIf(debug_info=no_match(["gmodules"]))
|
|
def test_rebuild_app_modules_untouched(self):
|
|
with open(self.getBuildArtifact("module.modulemap"), "w") as f:
|
|
f.write("""
|
|
module Foo { header "f.h" }
|
|
""")
|
|
with open(self.getBuildArtifact("f.h"), "w") as f:
|
|
f.write("""
|
|
@import Foundation;
|
|
@interface Foo : NSObject {
|
|
int i;
|
|
}
|
|
+(instancetype)init;
|
|
@end
|
|
""")
|
|
|
|
mod_cache = self.getBuildArtifact("private-module-cache")
|
|
import os
|
|
if os.path.isdir(mod_cache):
|
|
shutil.rmtree(mod_cache)
|
|
self.build()
|
|
self.assertTrue(os.path.isdir(mod_cache), "module cache exists")
|
|
|
|
target, process, _, bkpt = lldbutil.run_to_source_breakpoint(
|
|
self, "break here", lldb.SBFileSpec("main.m"))
|
|
bar = target.FindTypes('Bar').GetTypeAtIndex(0)
|
|
foo = bar.GetDirectBaseClassAtIndex(0).GetType()
|
|
self.assertEqual(foo.GetNumberOfFields(), 1)
|
|
self.assertEqual(foo.GetFieldAtIndex(0).GetName(), "i")
|
|
|
|
# Rebuild.
|
|
process.Kill()
|
|
os.remove(self.getBuildArtifact('main.o'))
|
|
os.remove(self.getBuildArtifact('a.out'))
|
|
self.build()
|
|
|
|
# Reattach.
|
|
target, process, _, _ = lldbutil.run_to_breakpoint_do_run(self, target, bkpt)
|
|
bar = target.FindTypes('Bar').GetTypeAtIndex(0)
|
|
foo = bar.GetDirectBaseClassAtIndex(0).GetType()
|
|
self.assertEqual(foo.GetNumberOfFields(), 1)
|
|
self.assertEqual(foo.GetFieldAtIndex(0).GetName(), "i")
|