Files
clang-p2996/lldb/unittests/Utility/ProcessInstanceInfoTest.cpp
Walter Erquinigo e0a398bf31 [process list] make the TRIPLE column wider
Summary:
Now that `process list` works better on the android platform, the arch aarch64-unknown-linux-android appears quite often.
The existing printed width of the TRIPLE column is not long enough, which doesn't look okay.
E.g.
```
1561   1016                    aarch64-unknown-linux-android ip6tables-restore
1999   1                       aarch64-unknown-linux-android tlc_server
2332   982                                              com.android.systemui
2378   983                                              webview_zygote
```

Now, after adding 6 spaces, it looks better

```
PID    PARENT USER       TRIPLE                         NAME
====== ====== ========== ============================== ============================
...
1561   1016              aarch64-unknown-linux-android  ip6tables-restore
1999   1                 aarch64-unknown-linux-android  tlc_server
2332   982                                              com.android.systemui
2378   983                                              webview_zygote
2448   982                                              com.sec.location.nsflp2
```

Reviewers: clayborg, labath, xiaobai, aadsm

Reviewed By: labath

Subscribers: srhines, kristof.beyls, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D68291

llvm-svn: 373670
2019-10-03 21:57:01 +00:00

94 lines
2.8 KiB
C++

//===-- ProcessInstanceInfoTest.cpp -----------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "lldb/Target/Process.h"
#include "gtest/gtest.h"
using namespace lldb_private;
namespace {
/// A very simple resolver which fails for even ids and returns a simple string
/// for odd ones.
class DummyUserIDResolver : public UserIDResolver {
protected:
llvm::Optional<std::string> DoGetUserName(id_t uid) override {
if (uid % 2)
return ("user" + llvm::Twine(uid)).str();
return llvm::None;
}
llvm::Optional<std::string> DoGetGroupName(id_t gid) override {
if (gid % 2)
return ("group" + llvm::Twine(gid)).str();
return llvm::None;
}
};
} // namespace
TEST(ProcessInstanceInfo, Dump) {
ProcessInstanceInfo info("a.out", ArchSpec("x86_64-pc-linux"), 47);
info.SetUserID(1);
info.SetEffectiveUserID(2);
info.SetGroupID(3);
info.SetEffectiveGroupID(4);
DummyUserIDResolver resolver;
StreamString s;
info.Dump(s, resolver);
EXPECT_STREQ(R"( pid = 47
name = a.out
file = a.out
arch = x86_64-pc-linux
uid = 1 (user1)
gid = 3 (group3)
euid = 2 ()
egid = 4 ()
)",
s.GetData());
}
TEST(ProcessInstanceInfo, DumpTable) {
ProcessInstanceInfo info("a.out", ArchSpec("x86_64-pc-linux"), 47);
info.SetUserID(1);
info.SetEffectiveUserID(2);
info.SetGroupID(3);
info.SetEffectiveGroupID(4);
DummyUserIDResolver resolver;
StreamString s;
const bool show_args = false;
const bool verbose = true;
ProcessInstanceInfo::DumpTableHeader(s, show_args, verbose);
info.DumpAsTableRow(s, resolver, show_args, verbose);
EXPECT_STREQ(
R"(PID PARENT USER GROUP EFF USER EFF GROUP TRIPLE ARGUMENTS
====== ====== ========== ========== ========== ========== ============================== ============================
47 0 user1 group3 2 4 x86_64-pc-linux
)",
s.GetData());
}
TEST(ProcessInstanceInfo, DumpTable_invalidUID) {
ProcessInstanceInfo info("a.out", ArchSpec("aarch64-unknown-linux-android"), 47);
DummyUserIDResolver resolver;
StreamString s;
const bool show_args = false;
const bool verbose = false;
ProcessInstanceInfo::DumpTableHeader(s, show_args, verbose);
info.DumpAsTableRow(s, resolver, show_args, verbose);
EXPECT_STREQ(
R"(PID PARENT USER TRIPLE NAME
====== ====== ========== ============================== ============================
47 0 aarch64-unknown-linux-android a.out
)",
s.GetData());
}