In the static analyzer codebase we have a traditional pattern where a single checker class (and its singleton instance) acts as the implementation of several (user-facing or modeling) checkers that have shared state and logic, but have their own names and can be enabled or disabled separately. Currently these multipart checker classes all reimplement the same boilerplate logic to store the enabled/disabled state, the name and the bug types associated with the checker parts. This commit extends `CheckerBase`, `BugType` and the checker registration process to offer an easy-to-use alternative to that boilerplate (which includes the ugly lazy initialization of `mutable std::unique_ptr<BugType>`s). In this new framework the single-part checkers are internally represented as "multipart checkers with just one part" (because this way I don't need to reimplement the same logic twice) but this does not require any changes in the code of simple single-part checkers. I do not claim that these multi-part checkers are perfect from an architectural point of view; but they won't suddenly disappear after many years of existence, so we might as well introduce a clear framework for them. (Switching to e.g. 1:1 correspondence between checker classes and checker names would be a prohibitively complex change.) This PR ports `DivZeroChecker` to the new framework as a proof of concept. I'm planning to do a series of follow-up commits to port the rest of the multi-part checker.
142 lines
4.7 KiB
C++
142 lines
4.7 KiB
C++
//== DivZeroChecker.cpp - Division by zero checker --------------*- C++ -*--==//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This defines DivZeroChecker, a builtin check in ExprEngine that performs
|
|
// checks for division by zeros.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
|
|
#include "clang/StaticAnalyzer/Checkers/Taint.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/CommonBugCategories.h"
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
|
|
#include <optional>
|
|
|
|
using namespace clang;
|
|
using namespace ento;
|
|
using namespace taint;
|
|
|
|
namespace {
|
|
class DivZeroChecker : public Checker<check::PreStmt<BinaryOperator>> {
|
|
void reportBug(StringRef Msg, ProgramStateRef StateZero,
|
|
CheckerContext &C) const;
|
|
void reportTaintBug(StringRef Msg, ProgramStateRef StateZero,
|
|
CheckerContext &C,
|
|
llvm::ArrayRef<SymbolRef> TaintedSyms) const;
|
|
|
|
public:
|
|
/// This checker class implements several user facing checkers
|
|
enum : CheckerPartIdx {
|
|
DivideZeroChecker,
|
|
TaintedDivChecker,
|
|
NumCheckerParts
|
|
};
|
|
BugType BugTypes[NumCheckerParts] = {
|
|
{this, DivideZeroChecker, "Division by zero"},
|
|
{this, TaintedDivChecker, "Division by zero", categories::TaintedData}};
|
|
|
|
void checkPreStmt(const BinaryOperator *B, CheckerContext &C) const;
|
|
};
|
|
} // end anonymous namespace
|
|
|
|
static const Expr *getDenomExpr(const ExplodedNode *N) {
|
|
const Stmt *S = N->getLocationAs<PreStmt>()->getStmt();
|
|
if (const auto *BE = dyn_cast<BinaryOperator>(S))
|
|
return BE->getRHS();
|
|
return nullptr;
|
|
}
|
|
|
|
void DivZeroChecker::reportBug(StringRef Msg, ProgramStateRef StateZero,
|
|
CheckerContext &C) const {
|
|
if (!isPartEnabled(DivideZeroChecker))
|
|
return;
|
|
if (ExplodedNode *N = C.generateErrorNode(StateZero)) {
|
|
auto R = std::make_unique<PathSensitiveBugReport>(
|
|
BugTypes[DivideZeroChecker], Msg, N);
|
|
bugreporter::trackExpressionValue(N, getDenomExpr(N), *R);
|
|
C.emitReport(std::move(R));
|
|
}
|
|
}
|
|
|
|
void DivZeroChecker::reportTaintBug(
|
|
StringRef Msg, ProgramStateRef StateZero, CheckerContext &C,
|
|
llvm::ArrayRef<SymbolRef> TaintedSyms) const {
|
|
if (!isPartEnabled(TaintedDivChecker))
|
|
return;
|
|
if (ExplodedNode *N = C.generateNonFatalErrorNode(StateZero)) {
|
|
auto R = std::make_unique<PathSensitiveBugReport>(
|
|
BugTypes[TaintedDivChecker], Msg, N);
|
|
bugreporter::trackExpressionValue(N, getDenomExpr(N), *R);
|
|
for (auto Sym : TaintedSyms)
|
|
R->markInteresting(Sym);
|
|
C.emitReport(std::move(R));
|
|
}
|
|
}
|
|
|
|
void DivZeroChecker::checkPreStmt(const BinaryOperator *B,
|
|
CheckerContext &C) const {
|
|
BinaryOperator::Opcode Op = B->getOpcode();
|
|
if (Op != BO_Div &&
|
|
Op != BO_Rem &&
|
|
Op != BO_DivAssign &&
|
|
Op != BO_RemAssign)
|
|
return;
|
|
|
|
if (!B->getRHS()->getType()->isScalarType())
|
|
return;
|
|
|
|
SVal Denom = C.getSVal(B->getRHS());
|
|
std::optional<DefinedSVal> DV = Denom.getAs<DefinedSVal>();
|
|
|
|
// Divide-by-undefined handled in the generic checking for uses of
|
|
// undefined values.
|
|
if (!DV)
|
|
return;
|
|
|
|
// Check for divide by zero.
|
|
ConstraintManager &CM = C.getConstraintManager();
|
|
ProgramStateRef stateNotZero, stateZero;
|
|
std::tie(stateNotZero, stateZero) = CM.assumeDual(C.getState(), *DV);
|
|
|
|
if (!stateNotZero) {
|
|
assert(stateZero);
|
|
reportBug("Division by zero", stateZero, C);
|
|
return;
|
|
}
|
|
|
|
if ((stateNotZero && stateZero)) {
|
|
std::vector<SymbolRef> taintedSyms = getTaintedSymbols(C.getState(), *DV);
|
|
if (!taintedSyms.empty()) {
|
|
reportTaintBug("Division by a tainted value, possibly zero", stateNotZero,
|
|
C, taintedSyms);
|
|
return;
|
|
}
|
|
}
|
|
|
|
// If we get here, then the denom should not be zero. We abandon the implicit
|
|
// zero denom case for now.
|
|
C.addTransition(stateNotZero);
|
|
}
|
|
|
|
void ento::registerDivZeroChecker(CheckerManager &Mgr) {
|
|
Mgr.registerChecker<DivZeroChecker, DivZeroChecker::DivideZeroChecker>();
|
|
}
|
|
|
|
bool ento::shouldRegisterDivZeroChecker(const CheckerManager &) { return true; }
|
|
|
|
void ento::registerTaintedDivChecker(CheckerManager &Mgr) {
|
|
Mgr.registerChecker<DivZeroChecker, DivZeroChecker::TaintedDivChecker>();
|
|
}
|
|
|
|
bool ento::shouldRegisterTaintedDivChecker(const CheckerManager &) {
|
|
return true;
|
|
}
|