ff3227e77d
Users can specify the path a raw profile is written to by passing
-fprofile-instr-generate=<path>, but this functionality broke on Darwin
after __llvm_profile_filename was made weak [1], resulting in profiles
being written to "default.profraw" even when <path> is specified.
The situation is that instrumented programs provide a weak definition of
__llvm_profile_filename, which conflicts with a weak redefinition
provided by the profiling runtime.
The linker appears to pick the 'winning' definition arbitrarily: on
Darwin, it usually prefers the larger definition, which is probably why
the instrprof-override-filename.c test has been passing.
The fix is to move the runtime's definition into a separate object file
within the archive. This means that the linker won't "see" the runtime's
definition unless the user program has not provided one. I couldn't
think of a great way to test this other than to mimic the Darwin
failure: use -fprofile-instr-generate=<some-small-path>.
Testing: check-{clang,profile}, modified instrprof-override-filename.c.
[1] [Profile] deprecate __llvm_profile_override_default_filename
https://reviews.llvm.org/D22613
https://reviews.llvm.org/D22614
Differential Revision: https://reviews.llvm.org/D34797
llvm-svn: 306710
80 lines
2.3 KiB
C
80 lines
2.3 KiB
C
/*===- InstrProfiling.c - Support library for PGO instrumentation ---------===*\
|
|
|*
|
|
|* The LLVM Compiler Infrastructure
|
|
|*
|
|
|* This file is distributed under the University of Illinois Open Source
|
|
|* License. See LICENSE.TXT for details.
|
|
|*
|
|
\*===----------------------------------------------------------------------===*/
|
|
|
|
#include "InstrProfiling.h"
|
|
#include "InstrProfilingInternal.h"
|
|
#include <limits.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#define INSTR_PROF_VALUE_PROF_DATA
|
|
#include "InstrProfData.inc"
|
|
|
|
|
|
COMPILER_RT_WEAK uint64_t INSTR_PROF_RAW_VERSION_VAR = INSTR_PROF_RAW_VERSION;
|
|
|
|
COMPILER_RT_VISIBILITY uint64_t __llvm_profile_get_magic(void) {
|
|
return sizeof(void *) == sizeof(uint64_t) ? (INSTR_PROF_RAW_MAGIC_64)
|
|
: (INSTR_PROF_RAW_MAGIC_32);
|
|
}
|
|
|
|
static unsigned ProfileDumped = 0;
|
|
|
|
COMPILER_RT_VISIBILITY unsigned lprofProfileDumped() {
|
|
return ProfileDumped;
|
|
}
|
|
|
|
COMPILER_RT_VISIBILITY void lprofSetProfileDumped() {
|
|
ProfileDumped = 1;
|
|
}
|
|
|
|
/* Return the number of bytes needed to add to SizeInBytes to make it
|
|
* the result a multiple of 8.
|
|
*/
|
|
COMPILER_RT_VISIBILITY uint8_t
|
|
__llvm_profile_get_num_padding_bytes(uint64_t SizeInBytes) {
|
|
return 7 & (sizeof(uint64_t) - SizeInBytes % sizeof(uint64_t));
|
|
}
|
|
|
|
COMPILER_RT_VISIBILITY uint64_t __llvm_profile_get_version(void) {
|
|
return __llvm_profile_raw_version;
|
|
}
|
|
|
|
COMPILER_RT_VISIBILITY void __llvm_profile_reset_counters(void) {
|
|
uint64_t *I = __llvm_profile_begin_counters();
|
|
uint64_t *E = __llvm_profile_end_counters();
|
|
|
|
memset(I, 0, sizeof(uint64_t) * (E - I));
|
|
|
|
const __llvm_profile_data *DataBegin = __llvm_profile_begin_data();
|
|
const __llvm_profile_data *DataEnd = __llvm_profile_end_data();
|
|
const __llvm_profile_data *DI;
|
|
for (DI = DataBegin; DI < DataEnd; ++DI) {
|
|
uint64_t CurrentVSiteCount = 0;
|
|
uint32_t VKI, i;
|
|
if (!DI->Values)
|
|
continue;
|
|
|
|
ValueProfNode **ValueCounters = (ValueProfNode **)DI->Values;
|
|
|
|
for (VKI = IPVK_First; VKI <= IPVK_Last; ++VKI)
|
|
CurrentVSiteCount += DI->NumValueSites[VKI];
|
|
|
|
for (i = 0; i < CurrentVSiteCount; ++i) {
|
|
ValueProfNode *CurrentVNode = ValueCounters[i];
|
|
|
|
while (CurrentVNode) {
|
|
CurrentVNode->Count = 0;
|
|
CurrentVNode = CurrentVNode->Next;
|
|
}
|
|
}
|
|
}
|
|
ProfileDumped = 0;
|
|
}
|