This patch makes sure that scalable indices (that would normally represent scalable tile or vector sizes) are printed correctly, i.e. with additional square brackets: ``` %1, %loop = transform.structured.tile %0 [2, 8, [4]] ``` This change complements https://reviews.llvm.org/D150944 and is a part of a larger effort to enable scalable vectorisation in Linalg. See this RFC for more context: * https://discourse.llvm.org/t/rfc-scalable-vectorisation-in-linalg/ Differential Revision: https://reviews.llvm.org/D151978
214 lines
7.8 KiB
C++
214 lines
7.8 KiB
C++
//===- ViewLikeInterface.cpp - View-like operations in MLIR ---------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "mlir/Interfaces/ViewLikeInterface.h"
|
|
|
|
using namespace mlir;
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// ViewLike Interfaces
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
/// Include the definitions of the loop-like interfaces.
|
|
#include "mlir/Interfaces/ViewLikeInterface.cpp.inc"
|
|
|
|
LogicalResult mlir::verifyListOfOperandsOrIntegers(Operation *op,
|
|
StringRef name,
|
|
unsigned numElements,
|
|
ArrayRef<int64_t> staticVals,
|
|
ValueRange values) {
|
|
// Check static and dynamic offsets/sizes/strides does not overflow type.
|
|
if (staticVals.size() != numElements)
|
|
return op->emitError("expected ") << numElements << " " << name
|
|
<< " values, got " << staticVals.size();
|
|
unsigned expectedNumDynamicEntries =
|
|
llvm::count_if(staticVals, [&](int64_t staticVal) {
|
|
return ShapedType::isDynamic(staticVal);
|
|
});
|
|
if (values.size() != expectedNumDynamicEntries)
|
|
return op->emitError("expected ")
|
|
<< expectedNumDynamicEntries << " dynamic " << name << " values";
|
|
return success();
|
|
}
|
|
|
|
LogicalResult
|
|
mlir::detail::verifyOffsetSizeAndStrideOp(OffsetSizeAndStrideOpInterface op) {
|
|
std::array<unsigned, 3> maxRanks = op.getArrayAttrMaxRanks();
|
|
// Offsets can come in 2 flavors:
|
|
// 1. Either single entry (when maxRanks == 1).
|
|
// 2. Or as an array whose rank must match that of the mixed sizes.
|
|
// So that the result type is well-formed.
|
|
if (!(op.getMixedOffsets().size() == 1 && maxRanks[0] == 1) && // NOLINT
|
|
op.getMixedOffsets().size() != op.getMixedSizes().size())
|
|
return op->emitError(
|
|
"expected mixed offsets rank to match mixed sizes rank (")
|
|
<< op.getMixedOffsets().size() << " vs " << op.getMixedSizes().size()
|
|
<< ") so the rank of the result type is well-formed.";
|
|
// Ranks of mixed sizes and strides must always match so the result type is
|
|
// well-formed.
|
|
if (op.getMixedSizes().size() != op.getMixedStrides().size())
|
|
return op->emitError(
|
|
"expected mixed sizes rank to match mixed strides rank (")
|
|
<< op.getMixedSizes().size() << " vs " << op.getMixedStrides().size()
|
|
<< ") so the rank of the result type is well-formed.";
|
|
|
|
if (failed(verifyListOfOperandsOrIntegers(op, "offset", maxRanks[0],
|
|
op.static_offsets(), op.offsets())))
|
|
return failure();
|
|
if (failed(verifyListOfOperandsOrIntegers(op, "size", maxRanks[1],
|
|
op.static_sizes(), op.sizes())))
|
|
return failure();
|
|
if (failed(verifyListOfOperandsOrIntegers(op, "stride", maxRanks[2],
|
|
op.static_strides(), op.strides())))
|
|
return failure();
|
|
return success();
|
|
}
|
|
|
|
static char getLeftDelimiter(AsmParser::Delimiter delimiter) {
|
|
switch (delimiter) {
|
|
case AsmParser::Delimiter::Paren:
|
|
return '(';
|
|
case AsmParser::Delimiter::LessGreater:
|
|
return '<';
|
|
case AsmParser::Delimiter::Square:
|
|
return '[';
|
|
case AsmParser::Delimiter::Braces:
|
|
return '{';
|
|
default:
|
|
llvm_unreachable("unsupported delimiter");
|
|
}
|
|
}
|
|
|
|
static char getRightDelimiter(AsmParser::Delimiter delimiter) {
|
|
switch (delimiter) {
|
|
case AsmParser::Delimiter::Paren:
|
|
return ')';
|
|
case AsmParser::Delimiter::LessGreater:
|
|
return '>';
|
|
case AsmParser::Delimiter::Square:
|
|
return ']';
|
|
case AsmParser::Delimiter::Braces:
|
|
return '}';
|
|
default:
|
|
llvm_unreachable("unsupported delimiter");
|
|
}
|
|
}
|
|
|
|
void mlir::printDynamicIndexList(OpAsmPrinter &printer, Operation *op,
|
|
OperandRange values,
|
|
ArrayRef<int64_t> integers,
|
|
TypeRange valueTypes,
|
|
AsmParser::Delimiter delimiter,
|
|
bool isTrailingIdxScalable) {
|
|
char leftDelimiter = getLeftDelimiter(delimiter);
|
|
char rightDelimiter = getRightDelimiter(delimiter);
|
|
printer << leftDelimiter;
|
|
if (integers.empty()) {
|
|
printer << rightDelimiter;
|
|
return;
|
|
}
|
|
|
|
int64_t trailingScalableInteger;
|
|
if (isTrailingIdxScalable) {
|
|
// ATM only the trailing idx can be scalable
|
|
trailingScalableInteger = integers.back();
|
|
integers = integers.drop_back();
|
|
}
|
|
|
|
unsigned idx = 0;
|
|
llvm::interleaveComma(integers, printer, [&](int64_t integer) {
|
|
if (ShapedType::isDynamic(integer)) {
|
|
printer << values[idx];
|
|
if (!valueTypes.empty())
|
|
printer << " : " << valueTypes[idx];
|
|
++idx;
|
|
} else {
|
|
printer << integer;
|
|
}
|
|
});
|
|
|
|
// Print the trailing scalable index
|
|
if (isTrailingIdxScalable) {
|
|
printer << ", ";
|
|
printer << "[";
|
|
printer << trailingScalableInteger;
|
|
printer << "]";
|
|
}
|
|
|
|
printer << rightDelimiter;
|
|
}
|
|
|
|
ParseResult mlir::parseDynamicIndexList(
|
|
OpAsmParser &parser,
|
|
SmallVectorImpl<OpAsmParser::UnresolvedOperand> &values,
|
|
DenseI64ArrayAttr &integers, bool *isTrailingIdxScalable,
|
|
SmallVectorImpl<Type> *valueTypes, AsmParser::Delimiter delimiter) {
|
|
|
|
SmallVector<int64_t, 4> integerVals;
|
|
bool foundScalable = false;
|
|
auto parseIntegerOrValue = [&]() {
|
|
OpAsmParser::UnresolvedOperand operand;
|
|
auto res = parser.parseOptionalOperand(operand);
|
|
|
|
// If `foundScalable` has already been set to `true` then a non-trailing
|
|
// tile size was identified as scalable.
|
|
if (foundScalable) {
|
|
parser.emitError(parser.getNameLoc())
|
|
<< "non-trailing tile size cannot be scalable";
|
|
return failure();
|
|
}
|
|
|
|
if (isTrailingIdxScalable && parser.parseOptionalLSquare().succeeded())
|
|
foundScalable = true;
|
|
|
|
if (res.has_value() && succeeded(res.value())) {
|
|
values.push_back(operand);
|
|
integerVals.push_back(ShapedType::kDynamic);
|
|
if (valueTypes && parser.parseColonType(valueTypes->emplace_back()))
|
|
return failure();
|
|
} else {
|
|
int64_t integer;
|
|
if (failed(parser.parseInteger(integer)))
|
|
return failure();
|
|
integerVals.push_back(integer);
|
|
}
|
|
if (foundScalable && parser.parseOptionalRSquare().failed())
|
|
return failure();
|
|
return success();
|
|
};
|
|
if (parser.parseCommaSeparatedList(delimiter, parseIntegerOrValue,
|
|
" in dynamic index list"))
|
|
return parser.emitError(parser.getNameLoc())
|
|
<< "expected SSA value or integer";
|
|
integers = parser.getBuilder().getDenseI64ArrayAttr(integerVals);
|
|
if (isTrailingIdxScalable)
|
|
*isTrailingIdxScalable = foundScalable;
|
|
return success();
|
|
}
|
|
|
|
bool mlir::detail::sameOffsetsSizesAndStrides(
|
|
OffsetSizeAndStrideOpInterface a, OffsetSizeAndStrideOpInterface b,
|
|
llvm::function_ref<bool(OpFoldResult, OpFoldResult)> cmp) {
|
|
if (a.static_offsets().size() != b.static_offsets().size())
|
|
return false;
|
|
if (a.static_sizes().size() != b.static_sizes().size())
|
|
return false;
|
|
if (a.static_strides().size() != b.static_strides().size())
|
|
return false;
|
|
for (auto it : llvm::zip(a.getMixedOffsets(), b.getMixedOffsets()))
|
|
if (!cmp(std::get<0>(it), std::get<1>(it)))
|
|
return false;
|
|
for (auto it : llvm::zip(a.getMixedSizes(), b.getMixedSizes()))
|
|
if (!cmp(std::get<0>(it), std::get<1>(it)))
|
|
return false;
|
|
for (auto it : llvm::zip(a.getMixedStrides(), b.getMixedStrides()))
|
|
if (!cmp(std::get<0>(it), std::get<1>(it)))
|
|
return false;
|
|
return true;
|
|
}
|