c21dfa9e49
Remove the test override of `target.prefer-dynamic-value`. Previously, the lldb default was `no-dynamic-values`. In rG9aa7e8e9ffbe (in 2015), the default was changed to `no-run-target`, but at that time the tests were changed to be run with `no-dynamic-value`. I don't know the reasons for not changing the tests, perhaps to avoid determining which tests to change, and what about them to change. Because `no-run-target` is the lldb default, I think it makes sense to make it the test default too. It puts the test config closer to what's used in practice. This change removes the `target.prefer-dynamic-value` override, and for those tests that failed, they have been updated to explicitly use `no-dynamic-values`. Future changes could update these tests to use dynamic values too, or they can be left as is to exercise non-dynamic typing. Differential Revision: https://reviews.llvm.org/D132382
85 lines
3.4 KiB
Python
85 lines
3.4 KiB
Python
"""
|
|
Test diamond inheritance.
|
|
"""
|
|
|
|
import lldb
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test.decorators import *
|
|
import lldbsuite.test.lldbutil as lldbutil
|
|
|
|
|
|
class TestCase(TestBase):
|
|
|
|
@no_debug_info_test
|
|
def test_with_sbvalue(self):
|
|
"""
|
|
Test that virtual base classes work in when SBValue objects are
|
|
used to explore the class.
|
|
"""
|
|
self.build()
|
|
lldbutil.run_to_source_breakpoint(self, "// breakpoint 1", lldb.SBFileSpec("main.cpp"))
|
|
|
|
self.runCmd("settings set target.prefer-dynamic-value no-dynamic-values")
|
|
|
|
j1 = self.frame().FindVariable("j1")
|
|
j1_Derived1 = j1.GetChildAtIndex(0)
|
|
j1_Derived2 = j1.GetChildAtIndex(1)
|
|
j1_Derived1_VBase = j1_Derived1.GetChildAtIndex(0)
|
|
j1_Derived2_VBase = j1_Derived2.GetChildAtIndex(0)
|
|
j1_Derived1_VBase_m_value = j1_Derived1_VBase.GetChildAtIndex(0)
|
|
j1_Derived2_VBase_m_value = j1_Derived2_VBase.GetChildAtIndex(0)
|
|
|
|
self.assertEqual(
|
|
j1_Derived1_VBase.GetLoadAddress(), j1_Derived2_VBase.GetLoadAddress(),
|
|
"ensure virtual base class is the same between Derived1 and Derived2")
|
|
self.assertEqual(j1_Derived1_VBase_m_value.GetValueAsUnsigned(
|
|
1), j1_Derived2_VBase_m_value.GetValueAsUnsigned(2), "ensure m_value in VBase is the same")
|
|
self.assertEqual(self.frame().FindVariable("d").GetChildAtIndex(0).GetChildAtIndex(
|
|
0).GetValueAsUnsigned(0), 12345, "ensure Derived2 from j1 is correct")
|
|
|
|
# This reassigns 'd' to point to 'j2'.
|
|
self.thread().StepOver()
|
|
|
|
self.assertEqual(self.frame().FindVariable("d").GetChildAtIndex(0).GetChildAtIndex(
|
|
0).GetValueAsUnsigned(0), 12346, "ensure Derived2 from j2 is correct")
|
|
|
|
@no_debug_info_test
|
|
def test(self):
|
|
self.build()
|
|
lldbutil.run_to_source_breakpoint(self, "// breakpoint 1", lldb.SBFileSpec("main.cpp"))
|
|
|
|
# All the children of j1.
|
|
children = [
|
|
ValueCheck(type="Derived1", children=[
|
|
ValueCheck(type="VBase", children=[
|
|
ValueCheck(type="int", name="m_value", value="12345")
|
|
])
|
|
]),
|
|
ValueCheck(type="Derived2", children=[
|
|
ValueCheck(type="VBase", children=[
|
|
ValueCheck(type="int", name="m_value", value="12345")
|
|
])
|
|
]),
|
|
ValueCheck(type="long", value="1"),
|
|
]
|
|
# Try using the class with expression evaluator/variable paths.
|
|
self.expect_expr("j1", result_type="Joiner1", result_children=children)
|
|
self.expect_var_path("j1", type="Joiner1", children=children)
|
|
|
|
# Use the expression evaluator to access the members.
|
|
self.expect_expr("j1.x", result_type="long", result_value="1")
|
|
self.expect_expr("j1.m_value", result_type="int", result_value="12345")
|
|
|
|
# Use variable paths to access the members.
|
|
self.expect_var_path("j1.x", type="long", value="1")
|
|
|
|
@expectedFailureAll
|
|
@no_debug_info_test
|
|
def test(self):
|
|
self.build()
|
|
lldbutil.run_to_source_breakpoint(self, "// breakpoint 1", lldb.SBFileSpec("main.cpp"))
|
|
# FIXME: This is completely broken and 'succeeds' with an error that
|
|
# there is noch such value/member in Joiner1. Move this up to the test
|
|
# above when fixed.
|
|
self.expect_var_path("j1.m_value", type="int", value="12345")
|