0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
156 lines
3.1 KiB
Plaintext
156 lines
3.1 KiB
Plaintext
// RUN: %clang_cc1 -x objective-c++ -fblocks -fobjc-gc -triple x86_64-apple-darwin -fobjc-runtime=macosx-fragile-10.5 -print-ivar-layout -emit-llvm -o /dev/null %s > %t-64.layout
|
|
// RUN: FileCheck --input-file=%t-64.layout %s
|
|
|
|
// See commentary in test/CodeGenObjC/block-var-layout.m, from which
|
|
// this is largely cloned.
|
|
|
|
struct S {
|
|
int i1;
|
|
id o1;
|
|
struct V {
|
|
int i2;
|
|
id o2;
|
|
} v1;
|
|
int i3;
|
|
id o3;
|
|
};
|
|
|
|
__weak id wid;
|
|
void x(id y) {}
|
|
void y(int a) {}
|
|
|
|
extern id opaque_id();
|
|
|
|
void f() {
|
|
__block int byref_int = 0;
|
|
char ch = 'a';
|
|
char ch1 = 'b';
|
|
char ch2 = 'c';
|
|
short sh = 2;
|
|
const id bar = (id) opaque_id();
|
|
id baz = 0;
|
|
__strong void *strong_void_sta;
|
|
__block id byref_bab = (id)0;
|
|
__block void *bl_var1;
|
|
int i; double dob;
|
|
|
|
// Test 1
|
|
// byref int, short, char, char, char, id, id, strong void*, byref id
|
|
// 01 35 10 00
|
|
// CHECK: block variable layout for block: 0x01, 0x35, 0x10, 0x00
|
|
void (^b)() = ^{
|
|
byref_int = sh + ch+ch1+ch2 ;
|
|
x(bar);
|
|
x(baz);
|
|
x((id)strong_void_sta);
|
|
x(byref_bab);
|
|
};
|
|
b();
|
|
|
|
// Test 2
|
|
// byref int, short, char, char, char, id, id, strong void*, byref void*, byref id
|
|
// 01 36 10 00
|
|
// CHECK: 0x01, 0x36, 0x10, 0x00
|
|
void (^c)() = ^{
|
|
byref_int = sh + ch+ch1+ch2 ;
|
|
x(bar);
|
|
x(baz);
|
|
x((id)strong_void_sta);
|
|
x(wid);
|
|
bl_var1 = 0;
|
|
x(byref_bab);
|
|
};
|
|
c();
|
|
|
|
// Test 3
|
|
// byref int, short, char, char, char, id, id, byref void*, int, double, byref id
|
|
// 01 34 11 30 00
|
|
// CHECK: block variable layout for block: 0x01, 0x35, 0x30, 0x00
|
|
void (^d)() = ^{
|
|
byref_int = sh + ch+ch1+ch2 ;
|
|
x(bar);
|
|
x(baz);
|
|
x(wid);
|
|
bl_var1 = 0;
|
|
y(i + dob);
|
|
x(byref_bab);
|
|
};
|
|
d();
|
|
|
|
// Test4
|
|
// struct S (int, id, int, id, int, id)
|
|
// 01 41 11 11 00
|
|
// CHECK: block variable layout for block: 0x01, 0x41, 0x11, 0x11, 0x00
|
|
struct S s2;
|
|
void (^e)() = ^{
|
|
x(s2.o1);
|
|
};
|
|
e();
|
|
}
|
|
|
|
// Test 5 (unions/structs and their nesting):
|
|
void Test5() {
|
|
struct S5 {
|
|
int i1;
|
|
id o1;
|
|
struct V {
|
|
int i2;
|
|
id o2;
|
|
} v1;
|
|
int i3;
|
|
union UI {
|
|
void * i1;
|
|
id o1;
|
|
int i3;
|
|
id o3;
|
|
}ui;
|
|
};
|
|
|
|
union U {
|
|
void * i1;
|
|
id o1;
|
|
int i3;
|
|
id o3;
|
|
}ui;
|
|
|
|
struct S5 s2;
|
|
union U u2;
|
|
|
|
// struct s2 (int, id, int, id, int, id?), union u2 (id?)
|
|
// 01 41 11 12 00
|
|
// CHECK: block variable layout for block: 0x01, 0x41, 0x11, 0x12, 0x00
|
|
void (^c)() = ^{
|
|
x(s2.ui.o1);
|
|
x(u2.o1);
|
|
};
|
|
c();
|
|
|
|
}
|
|
|
|
void CFRelease(id);
|
|
void notifyBlock(id dependentBlock) {
|
|
id singleObservationToken;
|
|
id token;
|
|
void (^b)();
|
|
|
|
// id, id, void(^)()
|
|
// 01 33 00
|
|
// CHECK: block variable layout for block: 0x01, 0x33, 0x00
|
|
void (^wrapperBlock)() = ^() {
|
|
CFRelease(singleObservationToken);
|
|
CFRelease(singleObservationToken);
|
|
CFRelease(token);
|
|
CFRelease(singleObservationToken);
|
|
b();
|
|
};
|
|
wrapperBlock();
|
|
}
|
|
|
|
void test_empty_block() {
|
|
// 01 00
|
|
// CHECK: block variable layout for block: 0x01, 0x30, 0x00
|
|
void (^wrapperBlock)() = ^() {
|
|
};
|
|
wrapperBlock();
|
|
}
|