0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
98 lines
2.3 KiB
C++
98 lines
2.3 KiB
C++
// RUN: %clang_cc1 -Wreturn-type -fsyntax-only -std=c++11 -verify %s
|
|
|
|
class A {
|
|
public:
|
|
A(const A&);
|
|
};
|
|
|
|
struct S {
|
|
int i;
|
|
double d;
|
|
|
|
virtual void B() {}
|
|
};
|
|
|
|
union U {
|
|
struct {
|
|
int i;
|
|
virtual void B() {} // Can only do this in C++11
|
|
} t;
|
|
};
|
|
|
|
struct S2 {
|
|
int i;
|
|
double d;
|
|
};
|
|
|
|
extern "C" U f3( void ); // expected-warning {{'f3' has C-linkage specified, but returns user-defined type 'U' which is incompatible with C}}
|
|
extern "C" S f0(void); // expected-warning {{'f0' has C-linkage specified, but returns user-defined type 'S' which is incompatible with C}}
|
|
extern "C" A f4( void ); // expected-warning {{'f4' has C-linkage specified, but returns user-defined type 'A' which is incompatible with C}}
|
|
|
|
// These should all be fine
|
|
extern "C" S2 f5( void );
|
|
extern "C" void f2( A x );
|
|
extern "C" void f6( S s );
|
|
extern "C" void f7( U u );
|
|
extern "C" double f8(void);
|
|
extern "C" long long f11( void );
|
|
extern "C" A *f10( void );
|
|
|
|
extern "C" struct mypodstruct f12(); // expected-warning {{'f12' has C-linkage specified, but returns incomplete type 'struct mypodstruct' which could be incompatible with C}}
|
|
|
|
namespace test2 {
|
|
// FIXME: we should probably suppress the first warning as the second one
|
|
// is more precise.
|
|
// For now this tests that a second 'extern "C"' is not necessary to trigger
|
|
// the warning.
|
|
struct A;
|
|
extern "C" A f(void); // expected-warning {{'f' has C-linkage specified, but returns incomplete type 'A' which could be incompatible with C}}
|
|
struct A {
|
|
A(const A&);
|
|
};
|
|
A f(void); // no warning. warning is already issued on first declaration.
|
|
}
|
|
|
|
namespace test3 {
|
|
struct A {
|
|
A(const A&);
|
|
};
|
|
extern "C" {
|
|
// Don't warn for static functions.
|
|
static A f(void);
|
|
}
|
|
}
|
|
|
|
namespace rdar13364028 {
|
|
class A {
|
|
public:
|
|
virtual int x();
|
|
};
|
|
|
|
extern "C" {
|
|
#pragma clang diagnostic push
|
|
#pragma clang diagnostic ignored "-Wreturn-type-c-linkage"
|
|
A xyzzy();
|
|
#pragma clang diagnostic pop
|
|
A bbb(); // expected-warning {{'bbb' has C-linkage specified, but returns user-defined type 'A' which is incompatible with C}}
|
|
A ccc() { // expected-warning {{'ccc' has C-linkage specified, but returns user-defined type 'A' which is incompatible with C}}
|
|
return A();
|
|
};
|
|
}
|
|
|
|
A xyzzy();
|
|
|
|
A xyzzy()
|
|
{
|
|
return A();
|
|
}
|
|
|
|
A bbb()
|
|
{
|
|
return A();
|
|
}
|
|
|
|
A bbb();
|
|
|
|
A ccc();
|
|
}
|