fde4b80cb7
Example:
int * const my_var = my_initializer;
Currently when transforming my_var to std::span the fixits:
- replace "int * const my_var = " with "std::span<int> const my_var {"
- add ", SIZE}" after "my_initializer" where SIZE is either inferred or
a placeholder
This patch makes that behavior less intrusive by not modifying variable
cv-qualifiers and initialization syntax.
The new behavior is:
- replace "int *" with "std::span<int>"
- add "{" before "my_initializer"
- add ", SIZE}" after "my_initializer"
This is an improvement on its own - since we don't touch the identifier,
we automatically can handle macros in them.
It also simplifies future work on initializer fixits.
50 lines
1.5 KiB
C++
50 lines
1.5 KiB
C++
// RUN: %clang_cc1 -std=c++20 -Wunsafe-buffer-usage \
|
|
// RUN: -fsafe-buffer-usage-suggestions \
|
|
// RUN: -fdiagnostics-parseable-fixits %s 2>&1 | FileCheck %s
|
|
|
|
void unsafe_array_func_ptr_call(void (*fn_ptr)(int *param)) {
|
|
int p[32];
|
|
// CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:12}:"std::array<int, 32> p"
|
|
|
|
int idx;
|
|
p[idx] = 10;
|
|
fn_ptr(p);
|
|
// CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:11-[[@LINE-1]]:11}:".data()"
|
|
}
|
|
|
|
void unsafe_ptr_func_ptr_call(void (*fn_ptr)(int *param)) {
|
|
int *p;
|
|
// CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:8}:"std::span<int> "
|
|
|
|
p[5] = 10;
|
|
fn_ptr(p);
|
|
// CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:11-[[@LINE-1]]:11}:".data()"
|
|
}
|
|
|
|
void addr_of_unsafe_ptr_func_ptr_call(void (*fn_ptr)(int *param)) {
|
|
int *p;
|
|
// CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:8}:"std::span<int> "
|
|
|
|
p[5] = 10;
|
|
fn_ptr(&p[0]);
|
|
// CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:10-[[@LINE-1]]:15}:"p.data()"
|
|
}
|
|
|
|
void addr_of_unsafe_ptr_w_offset_func_ptr_call(void (*fn_ptr)(int *param)) {
|
|
int *p;
|
|
// CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:8}:"std::span<int> "
|
|
|
|
p[5] = 10;
|
|
fn_ptr(&p[3]);
|
|
// CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:10-[[@LINE-1]]:15}:"&p.data()[3]"
|
|
}
|
|
|
|
void preincrement_unsafe_ptr_func_ptr_call(void (*fn_ptr)(int *param)) {
|
|
int *p;
|
|
// CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:8}:"std::span<int> "
|
|
|
|
p[5] = 10;
|
|
fn_ptr(++p);
|
|
// CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:10-[[@LINE-1]]:13}:"(p = p.subspan(1)).data()"
|
|
}
|