d33fa70ddd
This patch is a reworking of Pete Lawrence's (@PortalPete) proposal for better expression evaluator error messages: https://github.com/llvm/llvm-project/pull/80938 Before: ``` $ lldb -o "expr a+b" (lldb) expr a+b error: <user expression 0>:1:1: use of undeclared identifier 'a' a+b ^ error: <user expression 0>:1:3: use of undeclared identifier 'b' a+b ^ ``` After: ``` (lldb) expr a+b ^ ^ │ ╰─ error: use of undeclared identifier 'b' ╰─ error: use of undeclared identifier 'a' ``` This eliminates the confusing `<user expression 0>:1:3` source location and avoids echoing the expression to the console again, which results in a cleaner presentation that makes it easier to grasp what's going on. You can't see it here, bug the word "error" is now also in color, if so desired. Depends on https://github.com/llvm/llvm-project/pull/106442.
60 lines
2.1 KiB
C++
60 lines
2.1 KiB
C++
//===-- CommandObjectThreadTraceExportCTF.h -------------------*- C++ //-*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLDB_SOURCE_PLUGINS_TRACE_INTEL_PT_COMMANDOBJECTTHREADTRACEEXPORTCTF_H
|
|
#define LLDB_SOURCE_PLUGINS_TRACE_INTEL_PT_COMMANDOBJECTTHREADTRACEEXPORTCTF_H
|
|
|
|
#include "TraceExporterCTF.h"
|
|
#include "lldb/Interpreter/CommandInterpreter.h"
|
|
#include "lldb/Interpreter/CommandReturnObject.h"
|
|
#include <optional>
|
|
|
|
namespace lldb_private {
|
|
namespace ctf {
|
|
|
|
class CommandObjectThreadTraceExportCTF : public CommandObjectParsed {
|
|
public:
|
|
class CommandOptions : public Options {
|
|
public:
|
|
CommandOptions() : Options() { OptionParsingStarting(nullptr); }
|
|
|
|
Status SetOptionValue(uint32_t option_idx, llvm::StringRef option_arg,
|
|
ExecutionContext *execution_context) override;
|
|
|
|
void OptionParsingStarting(ExecutionContext *execution_context) override;
|
|
|
|
llvm::ArrayRef<OptionDefinition> GetDefinitions() override;
|
|
|
|
std::optional<size_t> m_thread_index;
|
|
std::string m_file;
|
|
};
|
|
|
|
CommandObjectThreadTraceExportCTF(CommandInterpreter &interpreter)
|
|
: CommandObjectParsed(
|
|
interpreter, "thread trace export ctf",
|
|
"Export a given thread's trace to Chrome Trace Format",
|
|
"thread trace export ctf [<ctf-options>]",
|
|
lldb::eCommandRequiresProcess | lldb::eCommandTryTargetAPILock |
|
|
lldb::eCommandProcessMustBeLaunched |
|
|
lldb::eCommandProcessMustBePaused |
|
|
lldb::eCommandProcessMustBeTraced),
|
|
m_options() {}
|
|
|
|
Options *GetOptions() override { return &m_options; }
|
|
|
|
protected:
|
|
void DoExecute(Args &args, CommandReturnObject &result) override;
|
|
|
|
CommandOptions m_options;
|
|
};
|
|
|
|
} // namespace ctf
|
|
} // namespace lldb_private
|
|
|
|
#endif // LLDB_SOURCE_PLUGINS_TRACE_INTEL_PT_COMMANDOBJECTTHREADTRACEEXPORTCTF_H
|