55b1410895
PT_LOAD and PT_TLS segments are top level sections in the ObjectFileELF section list. The two segments can often have the same program header p_vaddr and p_paddr values and this can cause section load list issues in LLDB if we load the PT_TLS segments. What happens is the SectionLoadList::m_addr_to_sect, when a library is loaded, will first map one of the sections named "PT_LOAD[0]" with the load address that matches the p_vaddr entry from the program header. Then the "PT_TLS[0]" would come along and try to load this section at the same address. This would cause the "PT_LOAD[0]" section to be unloaded as the SectionLoadList::m_addr_to_sect would replace the value for the matching p_vaddr with the last section to be seen. The sizes of the PT_TLS and PT_LOAD that have the same p_vaddr value don't need to have the same byte size, so this could cause lookups to fail for an addresses in the "PT_LOAD[0]" section or any of its children if the offset is greater than the offset size of the PT_TLS segment. It could also cause us to incorrectly attribute addresses from the "PT_LOAD[0]" to the "PT_TLS[0]" segment when doing lookups for offset that are less than the size of the PT_TLS segment. This fix stops us from loading PT_TLS segments in the section load lists and will prevent the bugs that resulted from this. No addresses the the DWARF refer to TLS data with a "file address" in any way. They all have TLS DWARF location expressions to locate these variables. We also don't have any support for having actual thread specific sections and having those sections resolve to something different for each thread, so there currently is no point in loading thread specific sections. Both the ObjectFileMachO and ObjectFileCOFF both ignore thread specific sections at the moment, so this brings the ObjectFileELF to parity with those plug-ins. I added a test into an existing test to verify that things work as expected. Prior to this fix with a real binary, the output of "target dump section-load-list" would look like this for the old LLDB: ``` // (lldb) target dump section-load-list // addr = 0x0000000000000000, section = 0x55d46ab8c510: 0xfffffffffffffffd container [0x0000000000000000-0x0000000000000628) r-- 0x00000000 0x00000628 0x00000000 a.out.PT_LOAD[0] // addr = 0x0000000000001000, section = 0x55d46ab8b0c0: 0xfffffffffffffffc container [0x0000000000001000-0x0000000000001185) r-x 0x00001000 0x00000185 0x00000000 a.out.PT_LOAD[1] // addr = 0x0000000000002000, section = 0x55d46ac040f0: 0xfffffffffffffffb container [0x0000000000002000-0x00000000000020cc) r-- 0x00002000 0x000000cc 0x00000000 a.out.PT_LOAD[2] // addr = 0x0000000000003db0, section = 0x55d46ab7cef0: 0xfffffffffffffff6 container [0x0000000000003db0-0x0000000000003db4) r-- 0x00002db0 0x00000000 0x00000000 a.out.PT_TLS[0] ``` And this for the fixed LLDB: ``` // (lldb) target dump section-load-list // addr = 0x0000000000000000, section = 0x105f0a9a8: 0xfffffffffffffffd container [0x0000000000000000-0x0000000000000628) r-- 0x00000000 0x00000628 0x00000000 a.out.PT_LOAD[0] // addr = 0x0000000000001000, section = 0x105f0adb8: 0xfffffffffffffffc container [0x0000000000001000-0x0000000000001185) r-x 0x00001000 0x00000185 0x00000000 a.out.PT_LOAD[1] // addr = 0x0000000000002000, section = 0x105f0af48: 0xfffffffffffffffb container [0x0000000000002000-0x00000000000020cc) r-- 0x00002000 0x000000cc 0x00000000 a.out.PT_LOAD[2] // addr = 0x0000000000003db0, section = 0x105f0b078: 0xfffffffffffffffa container [0x0000000000003db0-0x0000000000004028) rw- 0x00002db0 0x00000274 0x00000000 a.out.PT_LOAD[3] ``` We can see that previously the "PT_LOAD[3]" segment would be removed from the section load list, and after the fix it remains and there is on PT_TLS in the loaded sections.
89 lines
2.9 KiB
YAML
89 lines
2.9 KiB
YAML
# Overlapping PT_LOAD and PT_TLS segments in an object file should be able to
|
|
# exist side by side.
|
|
|
|
# When an ELF file contains both PT_LOAD and PT_TLS segments where the PT_TLS
|
|
# segment has the same p_vaddr and p_paddr as a PT_LOAD segment, this
|
|
# was causing LLDB, when loading a ELF object file at an address, to overwrite
|
|
# the section load address for a PT_LOAD that shares the same p_vaddr value in
|
|
# the section load list's addr to section map for this code. This test ensures
|
|
# that no PT_TLS segments get loaded and can't interfere with real segments we
|
|
# need to resolved as all access to thread specific memory is only done via
|
|
# DWARF location expressions. We also don't have any code that loads any thread
|
|
# specific segments at a different address for different threads, so there is
|
|
# no reason currently to try and load thread specific segments.
|
|
|
|
# RUN: yaml2obj %s -o %t
|
|
# RUN: lldb-test object-file %t | FileCheck %s
|
|
|
|
|
|
# CHECK: Index: 0
|
|
# CHECK-NEXT: ID: 0xffffffffffffffff
|
|
# CHECK-NEXT: Name: PT_LOAD[0]
|
|
# CHECK-NEXT: Type: container
|
|
# CHECK-NEXT: Permissions: rw-
|
|
# CHECK-NEXT: Thread specific: no
|
|
# CHECK-NEXT: VM address: 0x1000
|
|
# CHECK-NEXT: VM size: 16
|
|
# CHECK-NEXT: File size: 16
|
|
# CHECK-NEXT: Showing 1 subsections
|
|
|
|
# CHECK: Index: 1
|
|
# CHECK-NEXT: ID: 0xfffffffffffffffe
|
|
# CHECK-NEXT: Name: PT_TLS[0]
|
|
# CHECK-NEXT: Type: container
|
|
# CHECK-NEXT: Permissions: rw-
|
|
# CHECK-NEXT: Thread specific: yes
|
|
# CHECK-NEXT: VM address: 0x1000
|
|
# CHECK-NEXT: VM size: 16
|
|
# CHECK-NEXT: File size: 0
|
|
# CHECK-NEXT: Showing 1 subsections
|
|
|
|
# RUN: %lldb %t -b \
|
|
# RUN: -o "image lookup -a 0x1000" \
|
|
# RUN: -o "target modules load --file %t --slide 0" \
|
|
# RUN: -o "image lookup -a 0x1000" \
|
|
# RUN: -o "target dump section-load-list" \
|
|
# RUN: | FileCheck --check-prefix=LOOKUP %s
|
|
|
|
# LOOKUP-LABEL: image lookup -a 0x1000
|
|
# LOOKUP: Address: {{.*}}.PT_LOAD[0]..data + 0)
|
|
# LOOKUP: target modules load
|
|
# LOOKUP: image lookup -a 0x1000
|
|
# LOOKUP: Address: {{.*}}.PT_LOAD[0]..data + 0)
|
|
# LOOKUP: target dump section-load-list
|
|
# LOOKUP: PT_TLS-overlap-PT_LOAD.yaml.tmp.PT_LOAD[0]
|
|
# LOOKUP-NOT: PT_TLS-overlap-PT_LOAD.yaml.tmp.PT_TLS[0]
|
|
|
|
!ELF
|
|
FileHeader:
|
|
Class: ELFCLASS32
|
|
Data: ELFDATA2LSB
|
|
Type: ET_EXEC
|
|
Machine: EM_ARM
|
|
Sections:
|
|
- Name: .data
|
|
Type: SHT_PROGBITS
|
|
Flags: [ SHF_ALLOC, SHF_WRITE ]
|
|
Address: 0x1000
|
|
AddressAlign: 0x4
|
|
Size: 0x10
|
|
- Name: .tbss
|
|
Type: SHT_NOBITS
|
|
Flags: [ SHF_ALLOC, SHF_WRITE, SHF_TLS ]
|
|
Address: 0x1000
|
|
AddressAlign: 0x4
|
|
Size: 0x10
|
|
ProgramHeaders:
|
|
- Type: PT_LOAD
|
|
Flags: [ PF_W, PF_R ]
|
|
VAddr: 0x1000
|
|
Align: 0x4
|
|
FirstSec: .data
|
|
LastSec: .data
|
|
- Type: PT_TLS
|
|
Flags: [ PF_R, PF_W ]
|
|
VAddr: 0x1000
|
|
Align: 0x4
|
|
FirstSec: .tbss
|
|
LastSec: .tbss
|