Yingwei Zheng a77dedcacb [InstSimplify][InstCombine][ConstantFold] Move vector div/rem by zero fold to InstCombine (#114280) ...

Previously we fold `div/rem X, C` into `poison` if any element of the
constant divisor `C` is zero or undef. However, it is incorrect when
threading udiv over an vector select:
https://alive2.llvm.org/ce/z/3Ninx5
```
define <2 x i32> @vec_select_udiv_poison(<2 x i1> %x) {
  %sel = select <2 x i1> %x, <2 x i32> <i32 -1, i32 -1>, <2 x i32> <i32 0, i32 1>
  %div = udiv <2 x i32> <i32 42, i32 -7>, %sel
  ret <2 x i32> %div
}
```
In this case, `threadBinOpOverSelect` folds `udiv <i32 42, i32 -7>, <i32
-1, i32 -1>` and `udiv <i32 42, i32 -7>, <i32 0, i32 1>` into
`zeroinitializer` and `poison`, respectively. One solution is to
introduce a new flag indicating that we are threading over a vector
select. But it requires to modify both `InstSimplify` and
`ConstantFold`.

However, this optimization doesn't provide benefits to real-world
programs:

https://dtcxzyw.github.io/llvm-opt-benchmark/coverage/data/zyw/opt-ci/actions-runner/_work/llvm-opt-benchmark/llvm-opt-benchmark/llvm/llvm-project/llvm/lib/IR/ConstantFold.cpp.html#L908

https://dtcxzyw.github.io/llvm-opt-benchmark/coverage/data/zyw/opt-ci/actions-runner/_work/llvm-opt-benchmark/llvm-opt-benchmark/llvm/llvm-project/llvm/lib/Analysis/InstructionSimplify.cpp.html#L1107

This patch moves the fold into InstCombine to avoid breaking numerous
existing tests.

Fixes #114191 and #113866 (only poison-safety issue).

2024-11-01 22:56:22 +08:00

..

AbstractCallSite.cpp

…

AsmWriter.cpp

[IR] Add samesign flag to icmp instruction (#111419)

2024-10-15 17:11:25 +08:00

Assumptions.cpp

…

AttributeImpl.h

[IR][Attribute] Add support for intersecting AttributeLists; NFC (#109719)

2024-10-01 11:45:32 -05:00

Attributes.cpp

Reapply "[Inliner] Propagate more attributes to params when inlining (#91101)" (2nd Attempt) (#112749)

2024-10-17 20:28:47 -05:00

AutoUpgrade.cpp

[NVPTX] Remove nvvm.ldg.global.* intrinsics (#112834)

2024-10-27 16:14:13 -07:00

BasicBlock.cpp

[RemoveDIs] Fix spliceDebugInfo splice-to-end edge case (#105671)

2024-08-29 14:12:02 +01:00

BuiltinGCs.cpp

…

CMakeLists.txt

[NFC] Add a new Intrinsics.cpp file for intrinsic code (#110078)

2024-10-01 06:55:35 -07:00

Comdat.cpp

…

ConstantFold.cpp

[InstSimplify][InstCombine][ConstantFold] Move vector div/rem by zero fold to InstCombine (#114280)

2024-11-01 22:56:22 +08:00

ConstantFPRange.cpp

[ConstantFPRange] Implement ConstantFPRange::makeExactFCmpRegion (#111490)

2024-10-08 15:55:10 +08:00

ConstantRange.cpp

[ConstantRange] Perform increment on APInt (NFC)

2024-09-05 16:11:00 +02:00

ConstantRangeList.cpp

…

Constants.cpp

[APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (#80309)

2024-10-17 08:48:08 +02:00

ConstantsContext.h

[LLVM] Use {} instead of std::nullopt to initialize empty ArrayRef (#109133)

2024-09-19 16:16:38 +01:00

ConvergenceVerifier.cpp

…

Core.cpp

[NFC] Rename Intrinsic::getDeclaration to getOrInsertDeclaration (#111752)

2024-10-11 05:26:03 -07:00

CycleInfo.cpp

Revert "[CycleAnalysis] Methods to verify cycles and their nesting. (#102300)"

2024-08-20 16:05:39 +05:30

DataLayout.cpp

[DataLayout] Refactor storage of non-integral address spaces

2024-10-25 10:02:40 -07:00

DebugInfo.cpp

Add DILabel functions for LLVM-C (#112840)

2024-10-28 10:59:53 -07:00

DebugInfoMetadata.cpp

[LLVM] Use {} instead of std::nullopt to initialize empty ArrayRef (#109133)

2024-09-19 16:16:38 +01:00

DebugLoc.cpp

…

DebugProgramInstruction.cpp

[NFC] Rename Intrinsic::getDeclaration to getOrInsertDeclaration (#111752)

2024-10-11 05:26:03 -07:00

DiagnosticHandler.cpp

…

DiagnosticInfo.cpp

[Sanitizer] Create DiagnosticInfoInstrumentation for IR Instrumentation reporting. (#106356)

2024-09-08 10:10:16 +05:30

DiagnosticPrinter.cpp

…

DIBuilder.cpp

[NFC] Rename Intrinsic::getDeclaration to getOrInsertDeclaration (#111752)

2024-10-11 05:26:03 -07:00

DIExpressionOptimizer.cpp

…

Dominators.cpp

…

EHPersonalities.cpp

…

FPEnv.cpp

…

Function.cpp

[SimplifyLibCall][Attribute] Fix bug where we may keep range attr with incompatible type (#112649)

2024-10-17 10:32:55 -05:00

GCStrategy.cpp

…

Globals.cpp

[MTE] Do not allow local aliases to MTE globals (#106280)

2024-10-21 17:00:41 -07:00

GVMaterializer.cpp

…

InlineAsm.cpp

…

Instruction.cpp

[IR] Add samesign flag to icmp instruction (#111419)

2024-10-15 17:11:25 +08:00

Instructions.cpp

[NFC] Use initial-stack-allocations for more data structures (#110544)

2024-09-30 23:15:18 +01:00

IntrinsicInst.cpp

[NFC] Rename Intrinsic::getDeclaration to getOrInsertDeclaration (#111752)

2024-10-11 05:26:03 -07:00

Intrinsics.cpp

[LLVM] Add Intrinsic::getDeclarationIfExists (#112428)

2024-10-16 07:21:10 -07:00

IRBuilder.cpp

[LLVM] Make more use of IRBuilder::CreateIntrinsic. NFC. (#112706)

2024-10-17 16:20:43 +01:00

IRPrintingPasses.cpp

…

LegacyPassManager.cpp

[IR] Avoid repeated hash lookups (NFC) (#112469)

2024-10-16 06:40:10 -07:00

LLVMContext.cpp

LLVMContext: add getSyncScopeName() to lookup individual scope name (#109484)

2024-09-25 11:13:56 -07:00

LLVMContextImpl.cpp

LLVMContext: add getSyncScopeName() to lookup individual scope name (#109484)

2024-09-25 11:13:56 -07:00

LLVMContextImpl.h

LLVMContext: add getSyncScopeName() to lookup individual scope name (#109484)

2024-09-25 11:13:56 -07:00

LLVMRemarkStreamer.cpp

…

Mangler.cpp

[IR][ARM64EC][NFC] Clean up and document ARM64EC mangling helpers. (#107230)

2024-09-05 12:53:57 +02:00

MDBuilder.cpp

[LLVM] Use {} instead of std::nullopt to initialize empty ArrayRef (#109133)

2024-09-19 16:16:38 +01:00

MemoryModelRelaxationAnnotations.cpp

…

Metadata.cpp

[LLVM] Use {} instead of std::nullopt to initialize empty ArrayRef (#109133)

2024-09-19 16:16:38 +01:00

MetadataImpl.h

…

Module.cpp

[NFC] Rename Intrinsic::getDeclaration to getOrInsertDeclaration (#111752)

2024-10-11 05:26:03 -07:00

ModuleSummaryIndex.cpp

[ThinLTO] Shrink FunctionSummary by 8 bytes (#107706)

2024-09-07 11:21:20 -07:00

Operator.cpp

[IR] Add support for samesign in Operator::hasPoisonGeneratingFlags (#112358)

2024-10-15 23:07:16 +08:00

OptBisect.cpp

[OptBisect] Add an option to disable print of pass message (#101065)

2024-07-30 08:41:52 -04:00

Pass.cpp

[LegacyPM] Drop analysis groups (#101670)

2024-08-02 16:14:15 +02:00

PassInstrumentation.cpp

[llvm] Support llvm::Any across shared libraries on windows (#108051)

2024-10-24 08:07:13 +03:00

PassManager.cpp

…

PassRegistry.cpp

[LegacyPM] Drop analysis groups (#101670)

2024-08-02 16:14:15 +02:00

PassTimingInfo.cpp

…

PrintPasses.cpp

…

ProfDataUtils.cpp

ProfDataUtils: Avoid dyn_extract + assert (NFC)

2024-09-25 13:55:16 +04:00

ProfileSummary.cpp

…

PseudoProbe.cpp

…

ReplaceConstant.cpp

…

RuntimeLibcalls.cpp

[X86][CodeGen] Add base atan2 intrinsic lowering (p4) (#110760)

2024-10-16 11:43:17 -07:00

SafepointIRVerifier.cpp

…

SSAContext.cpp

…

Statepoint.cpp

…

StructuralHash.cpp

[StructuralHash] Support Differences (#112638)

2024-10-26 20:02:05 -07:00

SymbolTableListTraitsImpl.h

…

Type.cpp

[AMDGPU] Add a type for the named barrier (#113614)

2024-10-25 11:24:47 -07:00

TypedPointerType.cpp

Clean up after transition into opaque pointers. NFC (#102631)

2024-08-12 13:28:26 +02:00

TypeFinder.cpp

[DebugInfo][RemoveDIs] Find types hidden in DbgRecords (#106547)

2024-09-02 11:56:40 +01:00

Use.cpp

…

User.cpp

Don't rely on undefined behavior to store how a User object's allocation is laid out (#105714)

2024-09-11 11:34:26 -07:00

Value.cpp

…

ValueSymbolTable.cpp

…

VectorBuilder.cpp

[NFC] Rename Intrinsic::getDeclaration to getOrInsertDeclaration (#111752)

2024-10-11 05:26:03 -07:00

Verifier.cpp

IR: Fix verifier missing addrspace mismatch in vector GEPs (#114091)

2024-10-29 19:41:49 -07:00

VFABIDemangler.cpp

…