caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
890c4bece26e005cd9fa5511fe0efa7307794de5
clang-p2996/llvm/test/Transforms/InstSimplify
History
Yingwei Zheng a77dedcacb [InstSimplify][InstCombine][ConstantFold] Move vector div/rem by zero fold to InstCombine (#114280) 
Previously we fold `div/rem X, C` into `poison` if any element of the
constant divisor `C` is zero or undef. However, it is incorrect when
threading udiv over an vector select:
https://alive2.llvm.org/ce/z/3Ninx5
```
define <2 x i32> @vec_select_udiv_poison(<2 x i1> %x) {
  %sel = select <2 x i1> %x, <2 x i32> <i32 -1, i32 -1>, <2 x i32> <i32 0, i32 1>
  %div = udiv <2 x i32> <i32 42, i32 -7>, %sel
  ret <2 x i32> %div
}
```
In this case, `threadBinOpOverSelect` folds `udiv <i32 42, i32 -7>, <i32
-1, i32 -1>` and `udiv <i32 42, i32 -7>, <i32 0, i32 1>` into
`zeroinitializer` and `poison`, respectively. One solution is to
introduce a new flag indicating that we are threading over a vector
select. But it requires to modify both `InstSimplify` and
`ConstantFold`.

However, this optimization doesn't provide benefits to real-world
programs:

https://dtcxzyw.github.io/llvm-opt-benchmark/coverage/data/zyw/opt-ci/actions-runner/_work/llvm-opt-benchmark/llvm-opt-benchmark/llvm/llvm-project/llvm/lib/IR/ConstantFold.cpp.html#L908

https://dtcxzyw.github.io/llvm-opt-benchmark/coverage/data/zyw/opt-ci/actions-runner/_work/llvm-opt-benchmark/llvm-opt-benchmark/llvm/llvm-project/llvm/lib/Analysis/InstructionSimplify.cpp.html#L1107

This patch moves the fold into InstCombine to avoid breaking numerous
existing tests.

Fixes #114191 and #113866 (only poison-safety issue).
2024-11-01 22:56:22 +08:00
..
ConstProp
Fix logf128 tests to allow negative NaNs from (#104929)
2024-08-22 09:42:24 +00:00
X86
…
2010-12-20-Boolean.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
2011-01-14-Thread.ll
[NFCI] Regenerate instsimplify test checks
2022-04-03 20:55:15 +02:00
2011-02-01-Vector.ll
[NFCI] Regenerate instsimplify test checks
2022-04-03 20:55:15 +02:00
2011-09-05-InsertExtractValue.ll
[InstSimplify] Fix poison safety in insertvalue fold
2023-02-16 09:39:44 +01:00
2011-10-27-BinOpCrash.ll
…
2011-11-23-MaskedBitsCrash.ll
…
2013-04-19-ConstantFoldingCrash.ll
…
abs_intrinsic.ll
[ValueTracking] Fix i1 abs range (PR62760)
2023-05-17 12:31:13 +02:00
add_vp.ll
[NFC] Port all InstSimplify tests to -passes= syntax
2022-12-08 02:38:45 +03:00
add-mask.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
add.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
addsub.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
and-icmps-same-ops.ll
[InstSimplify] use isImpliedCondition() instead of semi-duplicated code
2022-08-05 10:59:09 -04:00
and-or-icmp-ctpop.ll
…
and-or-icmp-min-max.ll
…
and-or-icmp-nullptr.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
and-or-icmp-zero.ll
[InstCombine] Add pre-commit tests for PR66606. NFC.
2023-09-19 11:13:16 +08:00
and-or-implied-cond.ll
[InstSimplify] Fix simplifyAndOrWithICmpEq with undef refinement (#98898)
2024-07-16 11:40:04 +02:00
and.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
AndOrXor.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
assume_icmp.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
assume-fcmp-constant-implies-class.ll
…
assume-non-zero.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
bitcast-vector-fold.ll
[LLVM][ConstFolds] Verify a scalar src before attempting scalar->vector bitcast transformation. (#111149)
2024-10-08 13:28:44 +01:00
bitreverse-fold.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
bitreverse.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
bswap.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
call.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
canonicalize.ll
ConstantFolding: Constant fold denormal inputs to canonicalize for IEEE
2023-07-24 19:49:06 -04:00
cast-unsigned-icmp-cmp-0.ll
[IR][PatternMatch] Only accept poison in getSplatValue() (#89159)
2024-04-18 15:44:12 +09:00
cast.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
cmp_ext.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
cmp_of_min_max.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
cmp-alloca-offsets.ll
[InstSimplify] Fold icmp of allocas based on offset difference
2023-06-29 09:16:26 +02:00
cmp-vec-fast-path.ll
[LLVM][tests/Transforms/InstSimplify] Convert instances of ConstantExpr based splats to use splat().
2024-02-27 13:37:23 +00:00
compare.ll
[ValueTracking] Support gep nuw in isKnownNonZero()
2024-06-20 12:41:21 +02:00
constant-fold-fp-denormal.ll
[llvm-project] Fix typo "seperate" (#95373)
2024-06-13 20:20:27 +01:00
constantfold-add-nuw-allones-to-allones.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
constantfold-shl-nuw-C-to-C.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
constfold-constrained.ll
[ConstantFolding] Fix folding of constrained compare intrinsics
2022-02-27 10:19:19 +07:00
ctpop-pow2.ll
[ValueTracking] Do more thorough non-zero check in isKnownToBePowerOfTwo when OrZero is no set.
2023-10-12 16:05:19 -05:00
dead-code-removal.ll
[NFCI] Regenerate instsimplify test checks
2022-04-03 20:55:15 +02:00
distribute.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
div-by-0-guard-before-smul_ov-not.ll
…
div-by-0-guard-before-smul_ov.ll
…
div-by-0-guard-before-umul_ov-not.ll
…
div-by-0-guard-before-umul_ov.ll
…
div.ll
[InstSimplify][InstCombine][ConstantFold] Move vector div/rem by zero fold to InstCombine (#114280)
2024-11-01 22:56:22 +08:00
domcondition.ll
[InstSimplify] Precommit tests for dominate conditions are not single predecessor; NFC
2023-04-15 16:12:31 +08:00
exact-nsw-nuw.ll
…
exp10.ll
ConstantFolding: Handle exp10 intrinsic
2023-09-02 09:20:51 -04:00
extract-element.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
extract-vector.ll
[IR] Move vector.insert/vector.extract out of experimental namespace
2022-06-27 10:48:45 +00:00
fast-math-strictfp.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
fast-math.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
fcmp-select.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
fcmp.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
fdiv-strictfp.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
fdiv.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
floating-point-arithmetic-strictfp.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
floating-point-arithmetic.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
floating-point-compare.ll
[InstSimplify] fold uno/ord comparison if fpclass is always NaN (#97763)
2024-07-09 14:44:48 -07:00
fminmax-folds.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
fold-intrinsics.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
fold-vscale.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
fp-nan.ll
[InstCombine] Fix a cycle when folding fneg(select) with scalable vector types (#112465)
2024-10-25 10:47:39 -07:00
fp-undef-poison-strictfp.ll
…
fp-undef-poison.ll
…
fptoi-range.ll
[ValueTracking] Fix f16 fptosi range for large integers
2024-08-15 18:18:19 +02:00
fptoi-sat.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
freeze-noundef.ll
…
freeze.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
frexp.ll
InstSimplify: Handle basic folds for frexp
2023-07-17 17:28:01 -04:00
gc_relocate.ll
[InstSimplify] Add trivial simplifications for gc.relocate intrinsic (#81639)
2024-02-14 02:16:32 +03:00
gep.ll
[InstSimplify] Accept GEPNoWrapFlags instead of only InBounds flag
2024-06-04 11:15:06 +02:00
gv-alloca-cmp.ll
[InstSimplify] Fold all global variables with initializers
2023-07-03 15:11:41 -06:00
icmp-abs-nabs.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
icmp-bool-constant.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
icmp-constant.ll
[IR][PatternMatch] Only accept poison in getSplatValue() (#89159)
2024-04-18 15:44:12 +09:00
icmp-not-bool-constant.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
icmp-ranges.ll
[NFCI] Regenerate instsimplify test checks
2022-04-03 20:55:15 +02:00
icmp.ll
[ValueTracking] Add support for xor/disjoint or in isKnownNonZero
2024-04-10 13:13:43 -05:00
implies.ll
[ValueTracking] Add more conditions in to isTruePredicate
2024-04-04 12:42:58 -05:00
insert-vector.ll
[IR] Move vector.insert/vector.extract out of experimental namespace
2022-06-27 10:48:45 +00:00
insertelement.ll
[InstSimplify] Fold (insertelement Splat(C), C, X) -> Splat(C) (#102315)
2024-08-07 16:39:08 +02:00
insertvalue.ll
[InstSimplify] Fix poison safety in insertvalue fold
2023-02-16 09:39:44 +01:00
invalid-load-operand-infinite-loop.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
invariant.group-load.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
is_fpclass.ll
[Vectorize] Fix vectorization, scalarization and folding of llvm.is.fpclass
2023-04-24 13:42:08 +01:00
known-never-infinity.ll
[ValueTracking] Implement computeKnownFPClass for llvm.vector.reduce.{fmin,fmax,fmaximum,fminimum}
2024-04-16 16:10:00 -05:00
known-never-nan.ll
[InstSimplify] fold uno/ord comparison if fpclass is always NaN (#97763)
2024-07-09 14:44:48 -07:00
known-non-zero-opaque-ptrs.ll
…
known-non-zero.ll
[ValueTracking] Recognize X op (X != 0) as non-zero
2024-05-20 15:25:40 -05:00
ldexp.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
load-relative-32.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
load-relative.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
load.ll
[AggressiveInstCombine] Pre-Commit test for D144445 (NFC)
2023-03-23 23:31:22 +09:00
log2-pow2-intrinsic.ll
…
log10-pow10-intrinsic.ll
…
log-exp-intrinsic.ll
…
logic-of-fcmps.ll
[InstSimplify] Only handle canonical forms in simplifyAndOrOfFCmps. NFC. (#98136)
2024-07-10 12:59:27 +08:00
maxmin_intrinsics.ll
[IR][PatternMatch] Only accept poison in getSplatValue() (#89159)
2024-04-18 15:44:12 +09:00
maxmin.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
mul.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
named-vector-shuffle-reverse.ll
Move several vector intrinsics out of experimental namespace (#88748)
2024-04-29 10:16:45 +01:00
negate.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
noalias-ptr.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
null-ptr-is-valid-attribute.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
null-ptr-is-valid.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
opaque-ptr.ll
[llvm] Remove explicit -opaque-pointers flag from tests (NFC)
2023-07-12 14:35:55 +02:00
or-icmps-same-ops.ll
[InstSimplify] use isImpliedCondition() instead of semi-duplicated code
2022-08-05 10:59:09 -04:00
or.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
past-the-end.ll
Reapply [IR] Avoid creating icmp/fcmp constant expressions (#92885)
2024-05-31 08:55:59 +02:00
phi-cse.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
phi.ll
[InstSimplify] Fold all poison phi to poison instead of undef
2024-06-25 14:28:13 +02:00
po2-shift-add-and-to-zero.ll
…
pr28725.ll
[IR] Remove support for icmp and fcmp constant expressions (#93038)
2024-06-04 08:31:03 +02:00
pr33957.ll
[NFC] Port all InstSimplify tests to -passes= syntax
2022-12-08 02:38:45 +03:00
pr49495.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
pr87042.ll
[InstSimplify] Make sure the simplified value doesn't generate poison in threadBinOpOverSelect (#87075)
2024-04-11 12:48:52 +08:00
ptr_diff.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
ptrmask.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
ptrtoint.ll
[InstSimplify] Fold ptrtoint(ptradd(P,X-ptrtoint(P))) to X (#98649)
2024-07-15 09:26:03 +02:00
reassociate.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
redundant-null-check-in-uadd_with_overflow-of-nonnull-ptr.ll
…
rem.ll
[InstSimplify][InstCombine][ConstantFold] Move vector div/rem by zero fold to InstCombine (#114280)
2024-11-01 22:56:22 +08:00
require-dominator.ll
[Tests] Remove unnecessary bitcasts from opaque pointer tests (NFC)
2022-06-22 14:15:46 +02:00
result-of-add-of-negative-is-non-zero-and-no-underflow.ll
…
result-of-usub-by-nonzero-is-non-zero-and-no-overflow.ll
…
result-of-usub-is-non-zero-and-no-overflow.ll
…
returned.ll
…
round-intrinsics.ll
…
saturating-add-sub.ll
[InstSimplify] Simplify uadd.sat(X, Y) u>= X + Y and usub.sat(X, Y) u<= X, Y (#104698)
2024-08-18 20:55:05 +08:00
sdiv.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
select_or_and.ll
[InstSimplify] with logical ops: (X & Y) == -1 ? X : -1 --> -1
2023-04-26 15:53:02 +08:00
select-abs.ll
ValueTracking: handle more ops in isNotCrossLaneOperation (#112183)
2024-10-14 14:08:12 +01:00
select-and-cmp.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
select-icmp.ll
[ValueTracking] Infer relationship for the select with SLT
2024-08-06 10:30:04 +08:00
select-implied.ll
[InstCombine] Improvement the analytics through the dominating condition
2023-03-01 17:03:34 +08:00
select-inseltpoison.ll
[test] Remove immarg parameter attribute from calls (#97432)
2024-07-03 09:02:31 +01:00
select-logical.ll
[InstSimplify] !(X && Y) || X --> true (for poison-safe logical ops)
2023-01-29 10:24:52 -05:00
select-maxmin.ll
Reapply [InstSimplify] Support all instructions in simplifyWithOpReplaced()
2023-04-25 15:45:32 +02:00
select-or-cmp.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
select.ll
ValueTracking: introduce llvm::isNotCrossLaneOperation (#112011)
2024-10-14 11:37:30 +01:00
shift-128-kb.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
shift-knownbits.ll
[ValueTracking] Handle range attributes (#85143)
2024-03-20 12:43:00 +01:00
shift.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
shr-nop.ll
[NFCI] Regenerate instsimplify test checks
2022-04-03 20:55:15 +02:00
shr-scalar-vector-consistency.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
shufflevector-inseltpoison.ll
…
shufflevector.ll
VectorCombine: add tests written for InstSimplify (#92776)
2024-05-21 08:06:34 +01:00
signed-div-rem.ll
[NFCI] Regenerate instsimplify test checks
2022-04-03 20:55:15 +02:00
simplify-nested-bitcast.ll
[NFC] Port all InstSimplify tests to -passes= syntax
2022-12-08 02:38:45 +03:00
smul_fix.ll
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC
2022-02-07 14:26:58 +01:00
srem.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
strictfp-fadd.ll
…
strictfp-fsub.ll
Recommit [FPEnv][InstSimplify] Correct strictfp tests.
2023-08-03 09:44:50 -04:00
strictfp-sqrt-nonneg.ll
…
sub.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00
undef.ll
[NFCI] Regenerate instsimplify test checks
2022-04-03 20:55:15 +02:00
uscmp.ll
[InstSimplify] Provide information about the range of possible values that ucmp/scmp can return (#96410)
2024-06-24 12:01:46 +08:00
vec-cmp.ll
[ValueTracking] Don't accept undef in isKnownNonZero()
2024-04-15 13:54:09 +09:00
vec-icmp-of-cast.ll
…
vector_gep.ll
[ConstantFold] Remove notional over-indexing fold (#93697)
2024-05-30 08:36:44 +02:00
vector_ptr_bitcast.ll
[InstSimplify] Convert tests to opaque pointers (NFC)
2022-06-10 17:16:28 +02:00
vector-inseltextelt.ll
[instsimplify] Move (extelt (inselt Vec, Value, Index), Index) -> Value from InstCombine
2022-10-17 15:22:06 -07:00
vscale-inseltpoison.ll
[LLVM][tests/Transforms/InstSimplify] Convert instances of ConstantExpr based splats to use splat().
2024-02-27 13:37:23 +00:00
vscale.ll
[LLVM][tests/Transforms/InstSimplify] Convert instances of ConstantExpr based splats to use splat().
2024-02-27 13:37:23 +00:00
xor.ll
[PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
2024-04-17 18:22:05 +09:00