2ac2e9a5b6
When a function argument is annotated with the `llvm.byval` attribute, [LLVM expects](https://llvm.org/docs/LangRef.html#parameter-attributes) the function argument type to be an `llvm.ptr`. For example: ``` func.func (%args0 : llvm.ptr {llvm.byval = !llvm.struct<(i32)>} { ... } ``` Unfortunately, this makes the type conversion context-dependent, which is something that the type conversion infrastructure (i.e., `LLVMTypeConverter` in this particular case) doesn't support. For example, we may want to convert `MyType` to `llvm.struct<(i32)>` in general, but to an `llvm.ptr` type only when it's a function argument passed by value. To fix this problem, this PR changes the FuncToLLVM conversion logic to generate an `llvm.ptr` when the function argument has a `llvm.byval` attribute. An `llvm.load` is inserted into the function to retrieve the value expected by the argument users.
41 lines
1.5 KiB
MLIR
41 lines
1.5 KiB
MLIR
// RUN: mlir-opt %s -test-convert-func-op --split-input-file | FileCheck %s
|
|
|
|
// CHECK-LABEL: llvm.func @add
|
|
func.func @add(%arg0: i32, %arg1: i32) -> i32 attributes { llvm.emit_c_interface } {
|
|
%res = arith.addi %arg0, %arg1 : i32
|
|
return %res : i32
|
|
}
|
|
// CHECK-LABEL: llvm.func @_mlir_ciface_add
|
|
// CHECK-SAME: [[ARG0:%[a-zA-Z0-9_]+]]: i32
|
|
// CHECK-SAME: [[ARG1:%[a-zA-Z0-9_]+]]: i32
|
|
// CHECK-NEXT: [[RES:%.*]] = llvm.call @add([[ARG0]], [[ARG1]])
|
|
// CHECK-NEXT: llvm.return [[RES]]
|
|
|
|
// -----
|
|
|
|
// Test that `llvm.byval` arguments are converted to `llvm.ptr` and the actual
|
|
// value is retrieved within the `llvm.func`.
|
|
|
|
// CHECK-LABEL: llvm.func @byval
|
|
func.func @byval(%arg0: !test.smpla {llvm.byval = !test.smpla}) -> !test.smpla {
|
|
return %arg0 : !test.smpla
|
|
}
|
|
|
|
// CHECK-SAME: (%[[ARG0:.*]]: !llvm.ptr {llvm.byval = !llvm.struct<(i8, i8)>}) -> !llvm.struct<(i8, i8)>
|
|
// CHECK: %[[LD:.*]] = llvm.load %[[ARG0]] : !llvm.ptr -> !llvm.struct<(i8, i8)>
|
|
// CHECK: llvm.return %[[LD]] : !llvm.struct<(i8, i8)>
|
|
|
|
// -----
|
|
|
|
// Test that `llvm.byref` arguments are converted to `llvm.ptr` and the actual
|
|
// value is retrieved within the `llvm.func`.
|
|
|
|
// CHECK-LABEL: llvm.func @byref
|
|
func.func @byref(%arg0: !test.smpla {llvm.byref = !test.smpla}) -> !test.smpla {
|
|
return %arg0 : !test.smpla
|
|
}
|
|
|
|
// CHECK-SAME: (%[[ARG0:.*]]: !llvm.ptr {llvm.byref = !llvm.struct<(i8, i8)>}) -> !llvm.struct<(i8, i8)>
|
|
// CHECK: %[[LD:.*]] = llvm.load %[[ARG0]] : !llvm.ptr -> !llvm.struct<(i8, i8)>
|
|
// CHECK: llvm.return %[[LD]] : !llvm.struct<(i8, i8)>
|