a105877646
The idea behind this canonicalization is that it allows us to handle less patterns, because we know that some will be canonicalized away. This is indeed very useful to e.g. know that constants are always on the right. However, this is only useful if the canonicalization is actually reliable. This is the case for constants, but not for arguments: Moving these to the right makes it look like the "more complex" expression is guaranteed to be on the left, but this is not actually the case in practice. It fails as soon as you replace the argument with another instruction. The end result is that it looks like things correctly work in tests, while they actually don't. We use the "thwart complexity-based canonicalization" trick to handle this in tests, but it's often a challenge for new contributors to get this right, and based on the regressions this PR originally exposed, we clearly don't get this right in many cases. For this reason, I think that it's better to remove this complexity canonicalization. It will make it much easier to write tests for commuted cases and make sure that they are handled.
254 lines
10 KiB
LLVM
254 lines
10 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
|
|
; RUN: opt < %s -passes=slp-vectorizer,instcombine -S -mtriple=x86_64--- -mattr=+sse2 | FileCheck %s
|
|
; RUN: opt < %s -passes=slp-vectorizer,instcombine -S -mtriple=x86_64--- -mattr=+avx | FileCheck %s
|
|
|
|
;
|
|
; Check that we can commute operands based on the predicate.
|
|
;
|
|
|
|
define <4 x i32> @icmp_eq_v4i32(<4 x i32> %a, ptr %b) {
|
|
; CHECK-LABEL: @icmp_eq_v4i32(
|
|
; CHECK-NEXT: [[TMP1:%.*]] = load <4 x i32>, ptr [[B:%.*]], align 4
|
|
; CHECK-NEXT: [[TMP2:%.*]] = icmp eq <4 x i32> [[TMP1]], [[A:%.*]]
|
|
; CHECK-NEXT: [[R:%.*]] = sext <4 x i1> [[TMP2]] to <4 x i32>
|
|
; CHECK-NEXT: ret <4 x i32> [[R]]
|
|
;
|
|
%a0 = extractelement <4 x i32> %a, i32 0
|
|
%a1 = extractelement <4 x i32> %a, i32 1
|
|
%a2 = extractelement <4 x i32> %a, i32 2
|
|
%a3 = extractelement <4 x i32> %a, i32 3
|
|
%p1 = getelementptr inbounds i32, ptr %b, i32 1
|
|
%p2 = getelementptr inbounds i32, ptr %b, i32 2
|
|
%p3 = getelementptr inbounds i32, ptr %b, i32 3
|
|
%b0 = load i32, ptr %b, align 4
|
|
%b1 = load i32, ptr %p1, align 4
|
|
%b2 = load i32, ptr %p2, align 4
|
|
%b3 = load i32, ptr %p3, align 4
|
|
%c0 = icmp eq i32 %a0, %b0
|
|
%c1 = icmp eq i32 %b1, %a1
|
|
%c2 = icmp eq i32 %b2, %a2
|
|
%c3 = icmp eq i32 %a3, %b3
|
|
%d0 = insertelement <4 x i1> undef, i1 %c0, i32 0
|
|
%d1 = insertelement <4 x i1> %d0, i1 %c1, i32 1
|
|
%d2 = insertelement <4 x i1> %d1, i1 %c2, i32 2
|
|
%d3 = insertelement <4 x i1> %d2, i1 %c3, i32 3
|
|
%r = sext <4 x i1> %d3 to <4 x i32>
|
|
ret <4 x i32> %r
|
|
}
|
|
|
|
define <4 x i32> @icmp_ne_v4i32(<4 x i32> %a, ptr %b) {
|
|
; CHECK-LABEL: @icmp_ne_v4i32(
|
|
; CHECK-NEXT: [[TMP1:%.*]] = load <4 x i32>, ptr [[B:%.*]], align 4
|
|
; CHECK-NEXT: [[TMP2:%.*]] = icmp ne <4 x i32> [[TMP1]], [[A:%.*]]
|
|
; CHECK-NEXT: [[R:%.*]] = sext <4 x i1> [[TMP2]] to <4 x i32>
|
|
; CHECK-NEXT: ret <4 x i32> [[R]]
|
|
;
|
|
%a0 = extractelement <4 x i32> %a, i32 0
|
|
%a1 = extractelement <4 x i32> %a, i32 1
|
|
%a2 = extractelement <4 x i32> %a, i32 2
|
|
%a3 = extractelement <4 x i32> %a, i32 3
|
|
%p1 = getelementptr inbounds i32, ptr %b, i32 1
|
|
%p2 = getelementptr inbounds i32, ptr %b, i32 2
|
|
%p3 = getelementptr inbounds i32, ptr %b, i32 3
|
|
%b0 = load i32, ptr %b, align 4
|
|
%b1 = load i32, ptr %p1, align 4
|
|
%b2 = load i32, ptr %p2, align 4
|
|
%b3 = load i32, ptr %p3, align 4
|
|
%c0 = icmp ne i32 %a0, %b0
|
|
%c1 = icmp ne i32 %b1, %a1
|
|
%c2 = icmp ne i32 %b2, %a2
|
|
%c3 = icmp ne i32 %a3, %b3
|
|
%d0 = insertelement <4 x i1> undef, i1 %c0, i32 0
|
|
%d1 = insertelement <4 x i1> %d0, i1 %c1, i32 1
|
|
%d2 = insertelement <4 x i1> %d1, i1 %c2, i32 2
|
|
%d3 = insertelement <4 x i1> %d2, i1 %c3, i32 3
|
|
%r = sext <4 x i1> %d3 to <4 x i32>
|
|
ret <4 x i32> %r
|
|
}
|
|
|
|
define <4 x i32> @fcmp_oeq_v4i32(<4 x float> %a, ptr %b) {
|
|
; CHECK-LABEL: @fcmp_oeq_v4i32(
|
|
; CHECK-NEXT: [[TMP1:%.*]] = load <4 x float>, ptr [[B:%.*]], align 4
|
|
; CHECK-NEXT: [[TMP2:%.*]] = fcmp oeq <4 x float> [[TMP1]], [[A:%.*]]
|
|
; CHECK-NEXT: [[R:%.*]] = sext <4 x i1> [[TMP2]] to <4 x i32>
|
|
; CHECK-NEXT: ret <4 x i32> [[R]]
|
|
;
|
|
%a0 = extractelement <4 x float> %a, i32 0
|
|
%a1 = extractelement <4 x float> %a, i32 1
|
|
%a2 = extractelement <4 x float> %a, i32 2
|
|
%a3 = extractelement <4 x float> %a, i32 3
|
|
%p1 = getelementptr inbounds float, ptr %b, i32 1
|
|
%p2 = getelementptr inbounds float, ptr %b, i32 2
|
|
%p3 = getelementptr inbounds float, ptr %b, i32 3
|
|
%b0 = load float, ptr %b, align 4
|
|
%b1 = load float, ptr %p1, align 4
|
|
%b2 = load float, ptr %p2, align 4
|
|
%b3 = load float, ptr %p3, align 4
|
|
%c0 = fcmp oeq float %a0, %b0
|
|
%c1 = fcmp oeq float %b1, %a1
|
|
%c2 = fcmp oeq float %b2, %a2
|
|
%c3 = fcmp oeq float %a3, %b3
|
|
%d0 = insertelement <4 x i1> undef, i1 %c0, i32 0
|
|
%d1 = insertelement <4 x i1> %d0, i1 %c1, i32 1
|
|
%d2 = insertelement <4 x i1> %d1, i1 %c2, i32 2
|
|
%d3 = insertelement <4 x i1> %d2, i1 %c3, i32 3
|
|
%r = sext <4 x i1> %d3 to <4 x i32>
|
|
ret <4 x i32> %r
|
|
}
|
|
|
|
define <4 x i32> @fcmp_uno_v4i32(<4 x float> %a, ptr %b) {
|
|
; CHECK-LABEL: @fcmp_uno_v4i32(
|
|
; CHECK-NEXT: [[TMP1:%.*]] = load <4 x float>, ptr [[B:%.*]], align 4
|
|
; CHECK-NEXT: [[TMP2:%.*]] = fcmp uno <4 x float> [[TMP1]], [[A:%.*]]
|
|
; CHECK-NEXT: [[R:%.*]] = sext <4 x i1> [[TMP2]] to <4 x i32>
|
|
; CHECK-NEXT: ret <4 x i32> [[R]]
|
|
;
|
|
%a0 = extractelement <4 x float> %a, i32 0
|
|
%a1 = extractelement <4 x float> %a, i32 1
|
|
%a2 = extractelement <4 x float> %a, i32 2
|
|
%a3 = extractelement <4 x float> %a, i32 3
|
|
%p1 = getelementptr inbounds float, ptr %b, i32 1
|
|
%p2 = getelementptr inbounds float, ptr %b, i32 2
|
|
%p3 = getelementptr inbounds float, ptr %b, i32 3
|
|
%b0 = load float, ptr %b, align 4
|
|
%b1 = load float, ptr %p1, align 4
|
|
%b2 = load float, ptr %p2, align 4
|
|
%b3 = load float, ptr %p3, align 4
|
|
%c0 = fcmp uno float %a0, %b0
|
|
%c1 = fcmp uno float %b1, %a1
|
|
%c2 = fcmp uno float %b2, %a2
|
|
%c3 = fcmp uno float %a3, %b3
|
|
%d0 = insertelement <4 x i1> undef, i1 %c0, i32 0
|
|
%d1 = insertelement <4 x i1> %d0, i1 %c1, i32 1
|
|
%d2 = insertelement <4 x i1> %d1, i1 %c2, i32 2
|
|
%d3 = insertelement <4 x i1> %d2, i1 %c3, i32 3
|
|
%r = sext <4 x i1> %d3 to <4 x i32>
|
|
ret <4 x i32> %r
|
|
}
|
|
|
|
;
|
|
; Check that we can commute operands by swapping the predicate.
|
|
;
|
|
|
|
define <4 x i32> @icmp_sgt_slt_v4i32(<4 x i32> %a, ptr %b) {
|
|
; CHECK-LABEL: @icmp_sgt_slt_v4i32(
|
|
; CHECK-NEXT: [[TMP1:%.*]] = load <4 x i32>, ptr [[B:%.*]], align 4
|
|
; CHECK-NEXT: [[TMP2:%.*]] = icmp sgt <4 x i32> [[A:%.*]], [[TMP1]]
|
|
; CHECK-NEXT: [[R:%.*]] = sext <4 x i1> [[TMP2]] to <4 x i32>
|
|
; CHECK-NEXT: ret <4 x i32> [[R]]
|
|
;
|
|
%a0 = extractelement <4 x i32> %a, i32 0
|
|
%a1 = extractelement <4 x i32> %a, i32 1
|
|
%a2 = extractelement <4 x i32> %a, i32 2
|
|
%a3 = extractelement <4 x i32> %a, i32 3
|
|
%p1 = getelementptr inbounds i32, ptr %b, i32 1
|
|
%p2 = getelementptr inbounds i32, ptr %b, i32 2
|
|
%p3 = getelementptr inbounds i32, ptr %b, i32 3
|
|
%b0 = load i32, ptr %b, align 4
|
|
%b1 = load i32, ptr %p1, align 4
|
|
%b2 = load i32, ptr %p2, align 4
|
|
%b3 = load i32, ptr %p3, align 4
|
|
%c0 = icmp sgt i32 %a0, %b0
|
|
%c1 = icmp slt i32 %b1, %a1
|
|
%c2 = icmp slt i32 %b2, %a2
|
|
%c3 = icmp sgt i32 %a3, %b3
|
|
%d0 = insertelement <4 x i1> undef, i1 %c0, i32 0
|
|
%d1 = insertelement <4 x i1> %d0, i1 %c1, i32 1
|
|
%d2 = insertelement <4 x i1> %d1, i1 %c2, i32 2
|
|
%d3 = insertelement <4 x i1> %d2, i1 %c3, i32 3
|
|
%r = sext <4 x i1> %d3 to <4 x i32>
|
|
ret <4 x i32> %r
|
|
}
|
|
|
|
define <4 x i32> @icmp_uge_ule_v4i32(<4 x i32> %a, ptr %b) {
|
|
; CHECK-LABEL: @icmp_uge_ule_v4i32(
|
|
; CHECK-NEXT: [[TMP1:%.*]] = load <4 x i32>, ptr [[B:%.*]], align 4
|
|
; CHECK-NEXT: [[TMP2:%.*]] = icmp uge <4 x i32> [[A:%.*]], [[TMP1]]
|
|
; CHECK-NEXT: [[R:%.*]] = sext <4 x i1> [[TMP2]] to <4 x i32>
|
|
; CHECK-NEXT: ret <4 x i32> [[R]]
|
|
;
|
|
%a0 = extractelement <4 x i32> %a, i32 0
|
|
%a1 = extractelement <4 x i32> %a, i32 1
|
|
%a2 = extractelement <4 x i32> %a, i32 2
|
|
%a3 = extractelement <4 x i32> %a, i32 3
|
|
%p1 = getelementptr inbounds i32, ptr %b, i32 1
|
|
%p2 = getelementptr inbounds i32, ptr %b, i32 2
|
|
%p3 = getelementptr inbounds i32, ptr %b, i32 3
|
|
%b0 = load i32, ptr %b, align 4
|
|
%b1 = load i32, ptr %p1, align 4
|
|
%b2 = load i32, ptr %p2, align 4
|
|
%b3 = load i32, ptr %p3, align 4
|
|
%c0 = icmp uge i32 %a0, %b0
|
|
%c1 = icmp ule i32 %b1, %a1
|
|
%c2 = icmp ule i32 %b2, %a2
|
|
%c3 = icmp uge i32 %a3, %b3
|
|
%d0 = insertelement <4 x i1> undef, i1 %c0, i32 0
|
|
%d1 = insertelement <4 x i1> %d0, i1 %c1, i32 1
|
|
%d2 = insertelement <4 x i1> %d1, i1 %c2, i32 2
|
|
%d3 = insertelement <4 x i1> %d2, i1 %c3, i32 3
|
|
%r = sext <4 x i1> %d3 to <4 x i32>
|
|
ret <4 x i32> %r
|
|
}
|
|
|
|
define <4 x i32> @fcmp_ogt_olt_v4i32(<4 x float> %a, ptr %b) {
|
|
; CHECK-LABEL: @fcmp_ogt_olt_v4i32(
|
|
; CHECK-NEXT: [[TMP1:%.*]] = load <4 x float>, ptr [[B:%.*]], align 4
|
|
; CHECK-NEXT: [[TMP2:%.*]] = fcmp ogt <4 x float> [[A:%.*]], [[TMP1]]
|
|
; CHECK-NEXT: [[R:%.*]] = sext <4 x i1> [[TMP2]] to <4 x i32>
|
|
; CHECK-NEXT: ret <4 x i32> [[R]]
|
|
;
|
|
%a0 = extractelement <4 x float> %a, i32 0
|
|
%a1 = extractelement <4 x float> %a, i32 1
|
|
%a2 = extractelement <4 x float> %a, i32 2
|
|
%a3 = extractelement <4 x float> %a, i32 3
|
|
%p1 = getelementptr inbounds float, ptr %b, i32 1
|
|
%p2 = getelementptr inbounds float, ptr %b, i32 2
|
|
%p3 = getelementptr inbounds float, ptr %b, i32 3
|
|
%b0 = load float, ptr %b, align 4
|
|
%b1 = load float, ptr %p1, align 4
|
|
%b2 = load float, ptr %p2, align 4
|
|
%b3 = load float, ptr %p3, align 4
|
|
%c0 = fcmp ogt float %a0, %b0
|
|
%c1 = fcmp olt float %b1, %a1
|
|
%c2 = fcmp olt float %b2, %a2
|
|
%c3 = fcmp ogt float %a3, %b3
|
|
%d0 = insertelement <4 x i1> undef, i1 %c0, i32 0
|
|
%d1 = insertelement <4 x i1> %d0, i1 %c1, i32 1
|
|
%d2 = insertelement <4 x i1> %d1, i1 %c2, i32 2
|
|
%d3 = insertelement <4 x i1> %d2, i1 %c3, i32 3
|
|
%r = sext <4 x i1> %d3 to <4 x i32>
|
|
ret <4 x i32> %r
|
|
}
|
|
|
|
define <4 x i32> @fcmp_ord_uno_v4i32(<4 x float> %a, ptr %b) {
|
|
; CHECK-LABEL: @fcmp_ord_uno_v4i32(
|
|
; CHECK-NEXT: [[TMP1:%.*]] = load <4 x float>, ptr [[B:%.*]], align 4
|
|
; CHECK-NEXT: [[TMP2:%.*]] = fcmp ord <4 x float> [[TMP1]], [[A:%.*]]
|
|
; CHECK-NEXT: [[TMP3:%.*]] = fcmp uno <4 x float> [[TMP1]], [[A]]
|
|
; CHECK-NEXT: [[TMP4:%.*]] = shufflevector <4 x i1> [[TMP2]], <4 x i1> [[TMP3]], <4 x i32> <i32 0, i32 5, i32 6, i32 3>
|
|
; CHECK-NEXT: [[R:%.*]] = sext <4 x i1> [[TMP4]] to <4 x i32>
|
|
; CHECK-NEXT: ret <4 x i32> [[R]]
|
|
;
|
|
%a0 = extractelement <4 x float> %a, i32 0
|
|
%a1 = extractelement <4 x float> %a, i32 1
|
|
%a2 = extractelement <4 x float> %a, i32 2
|
|
%a3 = extractelement <4 x float> %a, i32 3
|
|
%p1 = getelementptr inbounds float, ptr %b, i32 1
|
|
%p2 = getelementptr inbounds float, ptr %b, i32 2
|
|
%p3 = getelementptr inbounds float, ptr %b, i32 3
|
|
%b0 = load float, ptr %b, align 4
|
|
%b1 = load float, ptr %p1, align 4
|
|
%b2 = load float, ptr %p2, align 4
|
|
%b3 = load float, ptr %p3, align 4
|
|
%c0 = fcmp ord float %a0, %b0
|
|
%c1 = fcmp uno float %b1, %a1
|
|
%c2 = fcmp uno float %b2, %a2
|
|
%c3 = fcmp ord float %a3, %b3
|
|
%d0 = insertelement <4 x i1> undef, i1 %c0, i32 0
|
|
%d1 = insertelement <4 x i1> %d0, i1 %c1, i32 1
|
|
%d2 = insertelement <4 x i1> %d1, i1 %c2, i32 2
|
|
%d3 = insertelement <4 x i1> %d2, i1 %c3, i32 3
|
|
%r = sext <4 x i1> %d3 to <4 x i32>
|
|
ret <4 x i32> %r
|
|
}
|