2a30bfcef3
If using a variadic operand, the error message given if the number of
types and operands do not match would be along the lines of:
```
3 operands present, but expected 2
```
This error message is confusing for multiple reasons, particular for
beginners:
* If the intention is to have 3 operands, it does not point out why it
expects 2. The user may actually just want to add a type to the type
list
* It reads as if a verifier error rather than a parser error, giving the
impression the Op only supports 2 operands.
This PR attempts to improve the error message by first noting the issue
("number of operands and types mismatch") and mentioning how many
operands and types it received.
103 lines
3.8 KiB
MLIR
103 lines
3.8 KiB
MLIR
// RUN: mlir-opt %s --split-input-file --verify-diagnostics
|
|
|
|
transform.sequence failures(propagate) {
|
|
^bb0(%arg0: !transform.any_op):
|
|
// expected-error@below {{'transform.structured.interchange' op expects iterator_interchange to be a permutation, found 1, 1}}
|
|
transform.structured.interchange %arg0 iterator_interchange = [1, 1] : (!transform.any_op) -> !transform.any_op
|
|
}
|
|
|
|
// -----
|
|
|
|
transform.sequence failures(propagate) {
|
|
^bb0(%arg0: !transform.any_op):
|
|
// expected-error@below {{expects padding_dimensions to contain positive integers, found [1, -7]}}
|
|
transform.structured.pad %arg0 {padding_dimensions=[1, -7]} : (!transform.any_op) -> (!transform.any_op, !transform.any_op, !transform.any_op)
|
|
}
|
|
|
|
// -----
|
|
|
|
transform.sequence failures(propagate) {
|
|
^bb0(%arg0: !transform.any_op):
|
|
// expected-error@below {{expects nofold_flags to contain booleans (0/1), found [1, 7]}}
|
|
transform.structured.pad %arg0 {nofold_flags=[1, 7]} : (!transform.any_op) -> (!transform.any_op, !transform.any_op, !transform.any_op)
|
|
}
|
|
|
|
// -----
|
|
|
|
transform.sequence failures(propagate) {
|
|
^bb0(%arg0: !transform.any_op):
|
|
// expected-error@below {{expects transpose_paddings to be a permutation, found [1, 1]}}
|
|
transform.structured.pad %arg0 {transpose_paddings=[[1, 1]]} : (!transform.any_op) -> (!transform.any_op, !transform.any_op, !transform.any_op)
|
|
}
|
|
|
|
// -----
|
|
|
|
transform.sequence failures(propagate) {
|
|
^bb0(%arg0: !transform.any_op):
|
|
// expected-error@below {{'transform.structured.interchange' op attribute 'iterator_interchange' failed to satisfy constraint: i64 dense array attribute whose value is non-negative}}
|
|
transform.structured.interchange %arg0 iterator_interchange = [-3, 1] : (!transform.any_op) -> !transform.any_op
|
|
}
|
|
|
|
// -----
|
|
|
|
transform.sequence failures(propagate) {
|
|
^bb0(%arg0: !transform.any_op):
|
|
// expected-error@below {{expects all results type to be the same}}
|
|
"transform.structured.multitile_sizes"(%arg0) { target_size = 3, divisor = 2, dimension = 0 }
|
|
: (!transform.any_op) -> (!transform.param<i64>, !transform.param<i64>, !transform.param<i32>)
|
|
}
|
|
|
|
// -----
|
|
|
|
transform.sequence failures(propagate) {
|
|
^bb0(%arg0: !transform.any_op):
|
|
// expected-error@below {{not a valid permutation}}
|
|
transform.structured.pack_greedily %arg0
|
|
matmul_packed_sizes = [8, 0, 32]
|
|
matmul_inner_dims_order = [1, 1, 0]
|
|
: (!transform.any_op) -> !transform.op<"linalg.generic">
|
|
|
|
}
|
|
|
|
// -----
|
|
|
|
transform.sequence failures(propagate) {
|
|
^bb0(%arg0: !transform.any_op):
|
|
// expected-error@below {{at most one of the packed_size and the padded_sizes_next_multiple_of can be nonzero}}
|
|
transform.structured.pack_greedily %arg0
|
|
matmul_packed_sizes = [1, 1, 1]
|
|
matmul_padded_sizes_next_multiple_of = [1, 1, 1]
|
|
matmul_inner_dims_order = [0, 1, 2]
|
|
: (!transform.any_op) -> !transform.op<"linalg.generic">
|
|
|
|
}
|
|
|
|
// -----
|
|
|
|
transform.sequence failures(propagate) {
|
|
^bb0(%arg0: !transform.any_op):
|
|
%0 = transform.param.constant 2 : i64 -> !transform.param<i64>
|
|
// expected-error@+1 {{custom op 'transform.structured.vectorize' number of operands and types do not match: got 1 operands and 2 types}}
|
|
transform.structured.vectorize %arg0 vector_sizes [%0, 2] : !transform.any_op, !transform.param<i64>, !transform.param<i64>
|
|
|
|
}
|
|
|
|
// -----
|
|
|
|
transform.sequence failures(propagate) {
|
|
^bb0(%arg0: !transform.any_op):
|
|
%0 = transform.param.constant 2 : i64 -> !transform.param<i64>
|
|
// expected-error@below {{expected ']' in dynamic index list}}
|
|
// expected-error@below {{custom op 'transform.structured.vectorize' expected SSA value or integer}}
|
|
transform.structured.vectorize %arg0 vector_sizes [%0 : !transform.param<i64>, 2] : !transform.any_op, !transform.param<i64>
|
|
|
|
}
|
|
|
|
// -----
|
|
|
|
transform.sequence failures(propagate) {
|
|
^bb0(%arg0: !transform.any_op):
|
|
// expected-error@below {{expected '('}}
|
|
%res = transform.structured.generalize %arg0 : !transform.any_op -> !transform.any_op
|
|
}
|