90c9cc2c98
As discussed in PR #142353, the current testsuite of the `clang` Python bindings has several issues: - If `libclang.so` cannot be loaded into `python` to run the testsuite, the whole `ninja check-all` aborts. - The result of running the testsuite isn't report like the `lit`-based tests, rendering them almost invisible. - The testsuite is disabled in a non-obvious way (`RUN_PYTHON_TESTS`) in `tests/CMakeLists.txt`, which again doesn't show up in the test results. All these issues can be avoided by integrating the Python bindings tests with `lit`, which is what this patch does: - The actual test lives in `clang/test/bindings/python/bindings.sh` and is run by `lit`. - The current `clang/bindings/python/tests` directory (minus the now-superfluous `CMakeLists.txt`) is moved into the same directory. - The check if `libclang` is loadable (originally from PR #142353) is now handled via a new `lit` feature, `libclang-loadable`. - The various ways to disable the tests have been turned into `XFAIL`s as appropriate. - AArch64 doesn't `FAIL` any longer, so no `XFAIL` is necessary. - It keeps the `check-clang-python` target for use by the Clang Python CI. Tested on `sparc-sun-solaris2.11`, `sparcv9-sun-solaris2.11`, `i386-pc-solaris2.11`, `amd64-pc-solaris2.11`, `i686-pc-linux-gnu`, and `x86_64-pc-linux-gnu`.
144 lines
4.4 KiB
Python
144 lines
4.4 KiB
Python
import os
|
|
|
|
from clang.cindex import Config, TranslationUnit
|
|
|
|
if "CLANG_LIBRARY_PATH" in os.environ:
|
|
Config.set_library_path(os.environ["CLANG_LIBRARY_PATH"])
|
|
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
|
|
class TestCodeCompletion(unittest.TestCase):
|
|
def check_completion_results(self, cr, expected):
|
|
self.assertIsNotNone(cr)
|
|
self.assertEqual(len(cr.diagnostics), 0)
|
|
|
|
completions = [str(c) for c in cr.results]
|
|
|
|
for c in expected:
|
|
self.assertIn(c, completions)
|
|
|
|
def test_code_complete(self):
|
|
files = [
|
|
(
|
|
"fake.c",
|
|
"""
|
|
/// Aaa.
|
|
int test1;
|
|
|
|
/// Bbb.
|
|
void test2(void);
|
|
|
|
void f() {
|
|
|
|
}
|
|
""",
|
|
)
|
|
]
|
|
|
|
tu = TranslationUnit.from_source(
|
|
"fake.c",
|
|
["-std=c99"],
|
|
unsaved_files=files,
|
|
options=TranslationUnit.PARSE_INCLUDE_BRIEF_COMMENTS_IN_CODE_COMPLETION,
|
|
)
|
|
|
|
cr = tu.codeComplete(
|
|
"fake.c", 9, 1, unsaved_files=files, include_brief_comments=True
|
|
)
|
|
|
|
expected = [
|
|
"{'int', ResultType} | {'test1', TypedText} || Priority: 50 || Availability: Available || Brief comment: Aaa.",
|
|
"{'void', ResultType} | {'test2', TypedText} | {'(', LeftParen} | {')', RightParen} || Priority: 50 || Availability: Available || Brief comment: Bbb.",
|
|
"{'return', TypedText} | {';', SemiColon} || Priority: 40 || Availability: Available || Brief comment: ",
|
|
]
|
|
self.check_completion_results(cr, expected)
|
|
|
|
def test_code_complete_pathlike(self):
|
|
files = [
|
|
(
|
|
Path("fake.c"),
|
|
"""
|
|
/// Aaa.
|
|
int test1;
|
|
|
|
/// Bbb.
|
|
void test2(void);
|
|
|
|
void f() {
|
|
|
|
}
|
|
""",
|
|
)
|
|
]
|
|
|
|
tu = TranslationUnit.from_source(
|
|
Path("fake.c"),
|
|
["-std=c99"],
|
|
unsaved_files=files,
|
|
options=TranslationUnit.PARSE_INCLUDE_BRIEF_COMMENTS_IN_CODE_COMPLETION,
|
|
)
|
|
|
|
cr = tu.codeComplete(
|
|
Path("fake.c"),
|
|
9,
|
|
1,
|
|
unsaved_files=files,
|
|
include_brief_comments=True,
|
|
)
|
|
|
|
expected = [
|
|
"{'int', ResultType} | {'test1', TypedText} || Priority: 50 || Availability: Available || Brief comment: Aaa.",
|
|
"{'void', ResultType} | {'test2', TypedText} | {'(', LeftParen} | {')', RightParen} || Priority: 50 || Availability: Available || Brief comment: Bbb.",
|
|
"{'return', TypedText} | {';', SemiColon} || Priority: 40 || Availability: Available || Brief comment: ",
|
|
]
|
|
self.check_completion_results(cr, expected)
|
|
|
|
def test_code_complete_availability(self):
|
|
files = [
|
|
(
|
|
"fake.cpp",
|
|
"""
|
|
class P {
|
|
protected:
|
|
int member;
|
|
};
|
|
|
|
class Q : public P {
|
|
public:
|
|
using P::member;
|
|
};
|
|
|
|
void f(P x, Q y) {
|
|
x.; // member is inaccessible
|
|
y.; // member is accessible
|
|
}
|
|
""",
|
|
)
|
|
]
|
|
|
|
tu = TranslationUnit.from_source(
|
|
"fake.cpp", ["-std=c++98"], unsaved_files=files
|
|
)
|
|
|
|
cr = tu.codeComplete("fake.cpp", 12, 5, unsaved_files=files)
|
|
|
|
expected = [
|
|
"{'const', TypedText} || Priority: 50 || Availability: Available || Brief comment: ",
|
|
"{'volatile', TypedText} || Priority: 50 || Availability: Available || Brief comment: ",
|
|
"{'operator', TypedText} || Priority: 40 || Availability: Available || Brief comment: ",
|
|
"{'P', TypedText} || Priority: 50 || Availability: Available || Brief comment: ",
|
|
"{'Q', TypedText} || Priority: 50 || Availability: Available || Brief comment: ",
|
|
]
|
|
self.check_completion_results(cr, expected)
|
|
|
|
cr = tu.codeComplete("fake.cpp", 13, 5, unsaved_files=files)
|
|
expected = [
|
|
"{'P', TypedText} | {'::', Text} || Priority: 75 || Availability: Available || Brief comment: ",
|
|
"{'P &', ResultType} | {'operator=', TypedText} | {'(', LeftParen} | {'const P &', Placeholder} | {')', RightParen} || Priority: 79 || Availability: Available || Brief comment: ",
|
|
"{'int', ResultType} | {'member', TypedText} || Priority: 35 || Availability: NotAccessible || Brief comment: ",
|
|
"{'void', ResultType} | {'~P', TypedText} | {'(', LeftParen} | {')', RightParen} || Priority: 79 || Availability: Available || Brief comment: ",
|
|
]
|
|
self.check_completion_results(cr, expected)
|