90c9cc2c98
As discussed in PR #142353, the current testsuite of the `clang` Python bindings has several issues: - If `libclang.so` cannot be loaded into `python` to run the testsuite, the whole `ninja check-all` aborts. - The result of running the testsuite isn't report like the `lit`-based tests, rendering them almost invisible. - The testsuite is disabled in a non-obvious way (`RUN_PYTHON_TESTS`) in `tests/CMakeLists.txt`, which again doesn't show up in the test results. All these issues can be avoided by integrating the Python bindings tests with `lit`, which is what this patch does: - The actual test lives in `clang/test/bindings/python/bindings.sh` and is run by `lit`. - The current `clang/bindings/python/tests` directory (minus the now-superfluous `CMakeLists.txt`) is moved into the same directory. - The check if `libclang` is loadable (originally from PR #142353) is now handled via a new `lit` feature, `libclang-loadable`. - The various ways to disable the tests have been turned into `XFAIL`s as appropriate. - AArch64 doesn't `FAIL` any longer, so no `XFAIL` is necessary. - It keeps the `check-clang-python` target for use by the Clang Python CI. Tested on `sparc-sun-solaris2.11`, `sparcv9-sun-solaris2.11`, `i386-pc-solaris2.11`, `amd64-pc-solaris2.11`, `i686-pc-linux-gnu`, and `x86_64-pc-linux-gnu`.
130 lines
5.5 KiB
Python
130 lines
5.5 KiB
Python
import os
|
|
|
|
from clang.cindex import Config, Diagnostic
|
|
|
|
if "CLANG_LIBRARY_PATH" in os.environ:
|
|
Config.set_library_path(os.environ["CLANG_LIBRARY_PATH"])
|
|
|
|
import unittest
|
|
|
|
from .util import get_tu
|
|
|
|
# FIXME: We need support for invalid translation units to test better.
|
|
|
|
|
|
class TestDiagnostics(unittest.TestCase):
|
|
def test_diagnostic_warning(self):
|
|
tu = get_tu("int f0() {}\n")
|
|
self.assertEqual(len(tu.diagnostics), 1)
|
|
self.assertEqual(tu.diagnostics[0].severity, Diagnostic.Warning)
|
|
self.assertEqual(tu.diagnostics[0].location.line, 1)
|
|
self.assertEqual(tu.diagnostics[0].location.column, 11)
|
|
self.assertEqual(
|
|
tu.diagnostics[0].spelling, "non-void function does not return a value"
|
|
)
|
|
|
|
def test_diagnostic_note(self):
|
|
# FIXME: We aren't getting notes here for some reason.
|
|
tu = get_tu("#define A x\nvoid *A = 1;\n")
|
|
self.assertEqual(len(tu.diagnostics), 1)
|
|
self.assertEqual(tu.diagnostics[0].severity, Diagnostic.Error)
|
|
self.assertEqual(tu.diagnostics[0].location.line, 2)
|
|
self.assertEqual(tu.diagnostics[0].location.column, 7)
|
|
self.assertIn("incompatible", tu.diagnostics[0].spelling)
|
|
|
|
# self.assertEqual(tu.diagnostics[1].severity, Diagnostic.Note)
|
|
# self.assertEqual(tu.diagnostics[1].location.line, 1)
|
|
# self.assertEqual(tu.diagnostics[1].location.column, 11)
|
|
# self.assertEqual(tu.diagnostics[1].spelling, 'instantiated from')
|
|
|
|
def test_diagnostic_fixit(self):
|
|
tu = get_tu("struct { int f0; } x = { f0 : 1 };")
|
|
self.assertEqual(len(tu.diagnostics), 1)
|
|
self.assertEqual(tu.diagnostics[0].severity, Diagnostic.Warning)
|
|
self.assertEqual(tu.diagnostics[0].location.line, 1)
|
|
self.assertEqual(tu.diagnostics[0].location.column, 26)
|
|
self.assertRegex(tu.diagnostics[0].spelling, "use of GNU old-style.*")
|
|
self.assertEqual(len(tu.diagnostics[0].fixits), 1)
|
|
with self.assertRaises(IndexError):
|
|
tu.diagnostics[0].fixits[1]
|
|
self.assertEqual(tu.diagnostics[0].fixits[0].range.start.line, 1)
|
|
self.assertEqual(tu.diagnostics[0].fixits[0].range.start.column, 26)
|
|
self.assertEqual(tu.diagnostics[0].fixits[0].range.end.line, 1)
|
|
self.assertEqual(tu.diagnostics[0].fixits[0].range.end.column, 30)
|
|
self.assertEqual(tu.diagnostics[0].fixits[0].value, ".f0 = ")
|
|
|
|
def test_diagnostic_range(self):
|
|
tu = get_tu('void f() { int i = "a"; }')
|
|
self.assertEqual(len(tu.diagnostics), 1)
|
|
self.assertEqual(tu.diagnostics[0].severity, Diagnostic.Error)
|
|
self.assertEqual(tu.diagnostics[0].location.line, 1)
|
|
self.assertEqual(tu.diagnostics[0].location.column, 16)
|
|
self.assertRegex(tu.diagnostics[0].spelling, "incompatible pointer to.*")
|
|
self.assertEqual(len(tu.diagnostics[0].fixits), 0)
|
|
self.assertEqual(len(tu.diagnostics[0].ranges), 1)
|
|
self.assertEqual(tu.diagnostics[0].ranges[0].start.line, 1)
|
|
self.assertEqual(tu.diagnostics[0].ranges[0].start.column, 20)
|
|
self.assertEqual(tu.diagnostics[0].ranges[0].end.line, 1)
|
|
self.assertEqual(tu.diagnostics[0].ranges[0].end.column, 23)
|
|
with self.assertRaises(IndexError):
|
|
tu.diagnostics[0].ranges[1].start.line
|
|
|
|
def test_diagnostic_category(self):
|
|
"""Ensure that category properties work."""
|
|
tu = get_tu("int f(int i) { return 7; }", all_warnings=True)
|
|
self.assertEqual(len(tu.diagnostics), 1)
|
|
d = tu.diagnostics[0]
|
|
|
|
self.assertEqual(d.severity, Diagnostic.Warning)
|
|
self.assertEqual(d.location.line, 1)
|
|
self.assertEqual(d.location.column, 11)
|
|
|
|
self.assertEqual(d.category_number, 3)
|
|
self.assertEqual(d.category_name, "Semantic Issue")
|
|
|
|
def test_diagnostic_option(self):
|
|
"""Ensure that category option properties work."""
|
|
tu = get_tu("int f(int i) { return 7; }", all_warnings=True)
|
|
self.assertEqual(len(tu.diagnostics), 1)
|
|
d = tu.diagnostics[0]
|
|
|
|
self.assertEqual(d.option, "-Wunused-parameter")
|
|
self.assertEqual(d.disable_option, "-Wno-unused-parameter")
|
|
|
|
def test_diagnostic_children(self):
|
|
tu = get_tu("void f(int x) {} void g() { f(); }")
|
|
self.assertEqual(len(tu.diagnostics), 1)
|
|
d = tu.diagnostics[0]
|
|
|
|
children = d.children
|
|
self.assertEqual(len(children), 1)
|
|
with self.assertRaises(IndexError):
|
|
children[1]
|
|
self.assertEqual(children[0].severity, Diagnostic.Note)
|
|
self.assertRegex(children[0].spelling, ".*declared here")
|
|
self.assertEqual(children[0].location.line, 1)
|
|
self.assertEqual(children[0].location.column, 6)
|
|
|
|
def test_diagnostic_string_repr(self):
|
|
tu = get_tu("struct MissingSemicolon{}")
|
|
self.assertEqual(len(tu.diagnostics), 1)
|
|
d = tu.diagnostics[0]
|
|
|
|
self.assertEqual(
|
|
repr(d),
|
|
"<Diagnostic severity 3, location <SourceLocation file 't.c', line 1, column 26>, spelling \"expected ';' after struct\">",
|
|
)
|
|
|
|
def test_diagnostic_string_format(self):
|
|
tu = get_tu("struct MissingSemicolon{}")
|
|
self.assertEqual(len(tu.diagnostics), 1)
|
|
d = tu.diagnostics[0]
|
|
|
|
self.assertEqual(str(d), "t.c:1:26: error: expected ';' after struct")
|
|
self.assertEqual(
|
|
d.format(0b111111),
|
|
"t.c:1:26: error: expected ';' after struct [2, Parse Issue]",
|
|
)
|
|
with self.assertRaises(ValueError):
|
|
d.format(0b1000000)
|