For a definition (of most linkage types), dso_local is set for ELF -fno-pic/-fpie
and COFF, but not for Mach-O. This nuance causes unneeded binary format differences.
This patch replaces (function) `define ` with `define{{.*}} `,
(variable/constant/alias) `= ` with `={{.*}} `, or inserts appropriate `{{.*}} `
if there is an explicit linkage.
* Clang will set dso_local for Mach-O, which is currently implied by TargetMachine.cpp. This will make COFF/Mach-O and executable ELF similar.
* Eventually I hope we can make dso_local the textual LLVM IR default (write explicit "dso_preemptable" when applicable) and -fpic ELF will be similar to everything else. This patch helps move toward that goal.
18 lines
448 B
C++
18 lines
448 B
C++
// RUN: %clang_cc1 -triple=x86_64-apple-darwin -std=c++11 -emit-llvm -o - %s | FileCheck %s
|
|
|
|
class Class1 {
|
|
public:
|
|
[[clang::not_tail_called]] int m1();
|
|
int m2();
|
|
};
|
|
|
|
int foo1(int a, Class1 *c1) {
|
|
if (a)
|
|
return c1->m1();
|
|
return c1->m2();
|
|
}
|
|
|
|
// CHECK-LABEL: define{{.*}} i32 @_Z4foo1iP6Class1(
|
|
// CHECK: %{{[a-z0-9]+}} = notail call i32 @_ZN6Class12m1Ev(%class.Class1*
|
|
// CHECK: %{{[a-z0-9]+}} = call i32 @_ZN6Class12m2Ev(%class.Class1*
|