516803dc86
Summary: This patch addresses https://bugs.llvm.org/show_bug.cgi?id=46256 The spec of coroutine requires that the expression co_await promise.final_suspend() shall not be potentially-throwing. To check this, we recursively look at every call (including Call, MemberCall, OperatorCall and Constructor) in all code generated by the final suspend, and ensure that the callees are declared with noexcept. We also look at any returned data type that requires explicit destruction, and check their destructors for noexcept. This patch does not check declarations with dependent types yet, which will be done in future patches. Updated all tests to add noexcept to the required functions, and added a dedicated test for this patch. This patch might start to cause existing codebase fail to compile because most people may not have been strict in tagging all the related functions noexcept. Reviewers: lewissbaker, modocache, junparser Reviewed By: modocache Subscribers: arphaman, junparser, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D82029
55 lines
2.2 KiB
C++
55 lines
2.2 KiB
C++
// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm -fcoroutines-ts \
|
|
// RUN: -fexperimental-new-pass-manager -O0 %s -o - | FileCheck %s
|
|
// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm -fcoroutines-ts \
|
|
// RUN: -fexperimental-new-pass-manager -fno-inline -O0 %s -o - | FileCheck %s
|
|
|
|
// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm -fcoroutines-ts \
|
|
// RUN: -O0 %s -o - | FileCheck %s
|
|
// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm -fcoroutines-ts \
|
|
// RUN: -fno-inline -O0 %s -o - | FileCheck %s
|
|
|
|
namespace std {
|
|
namespace experimental {
|
|
|
|
struct handle {};
|
|
|
|
struct awaitable {
|
|
bool await_ready() noexcept { return true; }
|
|
// CHECK-NOT: await_suspend
|
|
inline void __attribute__((__always_inline__)) await_suspend(handle) noexcept {}
|
|
bool await_resume() noexcept { return true; }
|
|
};
|
|
|
|
template <typename T>
|
|
struct coroutine_handle {
|
|
static handle from_address(void *address) noexcept { return {}; }
|
|
};
|
|
|
|
template <typename T = void>
|
|
struct coroutine_traits {
|
|
struct promise_type {
|
|
awaitable initial_suspend() { return {}; }
|
|
awaitable final_suspend() noexcept { return {}; }
|
|
void return_void() {}
|
|
T get_return_object() { return T(); }
|
|
void unhandled_exception() {}
|
|
};
|
|
};
|
|
} // namespace experimental
|
|
} // namespace std
|
|
|
|
// CHECK-LABEL: @_Z3foov
|
|
// CHECK-LABEL: entry:
|
|
// CHECK-NEXT: %this.addr.i{{[0-9]*}} = alloca %"struct.std::experimental::awaitable"*, align 8
|
|
// CHECK-NEXT: %this.addr.i{{[0-9]*}} = alloca %"struct.std::experimental::awaitable"*, align 8
|
|
// CHECK: [[CAST0:%[0-9]+]] = bitcast %"struct.std::experimental::awaitable"** %this.addr.i{{[0-9]*}} to i8*
|
|
// CHECK-NEXT: call void @llvm.lifetime.start.p0i8(i64 8, i8* [[CAST0]])
|
|
// CHECK: [[CAST1:%[0-9]+]] = bitcast %"struct.std::experimental::awaitable"** %this.addr.i{{[0-9]*}} to i8*
|
|
// CHECK-NEXT: call void @llvm.lifetime.end.p0i8(i64 8, i8* [[CAST1]])
|
|
|
|
// CHECK: [[CAST2:%[0-9]+]] = bitcast %"struct.std::experimental::awaitable"** %this.addr.i{{[0-9]*}} to i8*
|
|
// CHECK-NEXT: call void @llvm.lifetime.start.p0i8(i64 8, i8* [[CAST2]])
|
|
// CHECK: [[CAST3:%[0-9]+]] = bitcast %"struct.std::experimental::awaitable"** %this.addr.i{{[0-9]*}} to i8*
|
|
// CHECK-NEXT: call void @llvm.lifetime.end.p0i8(i64 8, i8* [[CAST3]])
|
|
void foo() { co_return; }
|