Every basic block section symbol created by -fbasic-block-sections will contain ".__part." to know that this symbol corresponds to a basic block fragment of the function. This patch solves two problems: a) Like D89617, we want function symbols with suffixes to be properly qualified so that external tools like profile aggregators know exactly what this symbol corresponds to. b) The current basic block naming just adds a ".N" to the symbol name where N is some integer. This collides with how clang creates __cxx_global_var_init.N. clang creates these symbol names to call constructor functions and basic block symbol naming should not use the same style. Fixed all the test cases and added an extra test for __cxx_global_var_init breakage. Differential Revision: https://reviews.llvm.org/D93082
19 lines
781 B
LLVM
19 lines
781 B
LLVM
; Check that basic block section is emitted when a non-entry block has no predecessors.
|
|
; RUN: llc < %s -mtriple=x86_64 -O0 -basic-block-sections=all | FileCheck %s --check-prefix=CHECK-SECTIONS
|
|
; RUN: llc < %s -mtriple=x86_64 -O0 | FileCheck %s --check-prefix=CHECK-NOSECTIONS
|
|
define void @foo(i32* %bar) {
|
|
%v = load i32, i32* %bar
|
|
switch i32 %v, label %default [
|
|
i32 0, label %target
|
|
]
|
|
target:
|
|
ret void
|
|
;; This is the block which will not have any predecessors. If the block is not garbage collected, it must
|
|
;; be placed in a basic block section with a corresponding symbol.
|
|
default:
|
|
unreachable
|
|
; CHECK-NOSECTIONS: # %bb.2: # %default
|
|
; CHECK-SECTIONS: .section .text,"ax",@progbits,unique,2
|
|
; CHECK-SECTIONS-NEXT: foo.__part.2: # %default
|
|
}
|