937348cd13
SetFile has an optional style argument which defaulted to the native style. This patch makes that argument mandatory so clients of the FileSpec class are forced to think about the correct syntax. At the same time this introduces a (protected) convenience method to update the file from within the FileSpec class that keeps the current style. These two changes together prevent a potential pitfall where the style might be forgotten, leading to the path being updated and the style unintentionally being changed to the host style. llvm-svn: 334663
123 lines
4.4 KiB
C++
123 lines
4.4 KiB
C++
//===-- OptionValueFileSpec.cpp ---------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/Interpreter/OptionValueFileSpec.h"
|
|
|
|
#include "lldb/Core/State.h"
|
|
#include "lldb/DataFormatters/FormatManager.h"
|
|
#include "lldb/Host/FileSystem.h"
|
|
#include "lldb/Interpreter/CommandCompletions.h"
|
|
#include "lldb/Interpreter/CommandInterpreter.h"
|
|
#include "lldb/Utility/Args.h"
|
|
#include "lldb/Utility/DataBufferLLVM.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
OptionValueFileSpec::OptionValueFileSpec(bool resolve)
|
|
: OptionValue(), m_current_value(), m_default_value(), m_data_sp(),
|
|
m_data_mod_time(),
|
|
m_completion_mask(CommandCompletions::eDiskFileCompletion),
|
|
m_resolve(resolve) {}
|
|
|
|
OptionValueFileSpec::OptionValueFileSpec(const FileSpec &value, bool resolve)
|
|
: OptionValue(), m_current_value(value), m_default_value(value),
|
|
m_data_sp(), m_data_mod_time(),
|
|
m_completion_mask(CommandCompletions::eDiskFileCompletion),
|
|
m_resolve(resolve) {}
|
|
|
|
OptionValueFileSpec::OptionValueFileSpec(const FileSpec ¤t_value,
|
|
const FileSpec &default_value,
|
|
bool resolve)
|
|
: OptionValue(), m_current_value(current_value),
|
|
m_default_value(default_value), m_data_sp(), m_data_mod_time(),
|
|
m_completion_mask(CommandCompletions::eDiskFileCompletion),
|
|
m_resolve(resolve) {}
|
|
|
|
void OptionValueFileSpec::DumpValue(const ExecutionContext *exe_ctx,
|
|
Stream &strm, uint32_t dump_mask) {
|
|
if (dump_mask & eDumpOptionType)
|
|
strm.Printf("(%s)", GetTypeAsCString());
|
|
if (dump_mask & eDumpOptionValue) {
|
|
if (dump_mask & eDumpOptionType)
|
|
strm.PutCString(" = ");
|
|
|
|
if (m_current_value) {
|
|
strm << '"' << m_current_value.GetPath().c_str() << '"';
|
|
}
|
|
}
|
|
}
|
|
|
|
Status OptionValueFileSpec::SetValueFromString(llvm::StringRef value,
|
|
VarSetOperationType op) {
|
|
Status error;
|
|
switch (op) {
|
|
case eVarSetOperationClear:
|
|
Clear();
|
|
NotifyValueChanged();
|
|
break;
|
|
|
|
case eVarSetOperationReplace:
|
|
case eVarSetOperationAssign:
|
|
if (value.size() > 0) {
|
|
// The setting value may have whitespace, double-quotes, or single-quotes
|
|
// around the file path to indicate that internal spaces are not word
|
|
// breaks. Strip off any ws & quotes from the start and end of the file
|
|
// path - we aren't doing any word // breaking here so the quoting is
|
|
// unnecessary. NB this will cause a problem if someone tries to specify
|
|
// a file path that legitimately begins or ends with a " or ' character,
|
|
// or whitespace.
|
|
value = value.trim("\"' \t");
|
|
m_value_was_set = true;
|
|
m_current_value.SetFile(value.str(), m_resolve, FileSpec::Style::native);
|
|
m_data_sp.reset();
|
|
m_data_mod_time = llvm::sys::TimePoint<>();
|
|
NotifyValueChanged();
|
|
} else {
|
|
error.SetErrorString("invalid value string");
|
|
}
|
|
break;
|
|
|
|
case eVarSetOperationInsertBefore:
|
|
case eVarSetOperationInsertAfter:
|
|
case eVarSetOperationRemove:
|
|
case eVarSetOperationAppend:
|
|
case eVarSetOperationInvalid:
|
|
error = OptionValue::SetValueFromString(value, op);
|
|
break;
|
|
}
|
|
return error;
|
|
}
|
|
|
|
lldb::OptionValueSP OptionValueFileSpec::DeepCopy() const {
|
|
return OptionValueSP(new OptionValueFileSpec(*this));
|
|
}
|
|
|
|
size_t OptionValueFileSpec::AutoComplete(
|
|
CommandInterpreter &interpreter, llvm::StringRef s, int match_start_point,
|
|
int max_return_elements, bool &word_complete, StringList &matches) {
|
|
word_complete = false;
|
|
matches.Clear();
|
|
CommandCompletions::InvokeCommonCompletionCallbacks(
|
|
interpreter, m_completion_mask, s, match_start_point, max_return_elements,
|
|
nullptr, word_complete, matches);
|
|
return matches.GetSize();
|
|
}
|
|
|
|
const lldb::DataBufferSP &OptionValueFileSpec::GetFileContents() {
|
|
if (m_current_value) {
|
|
const auto file_mod_time = FileSystem::GetModificationTime(m_current_value);
|
|
if (m_data_sp && m_data_mod_time == file_mod_time)
|
|
return m_data_sp;
|
|
m_data_sp = DataBufferLLVM::CreateFromPath(m_current_value.GetPath());
|
|
m_data_mod_time = file_mod_time;
|
|
}
|
|
return m_data_sp;
|
|
}
|