814b8e91c7
As a follow-up to r246098, require `DISubprogram` definitions
(`isDefinition: true`) to be 'distinct'. Specifically, add an assembler
check, a verifier check, and bitcode upgrading logic to combat testcase
bitrot after the `DIBuilder` change.
While working on the testcases, I realized that
test/Linker/subprogram-linkonce-weak-odr.ll isn't relevant anymore. Its
purpose was to check for a corner case in PR22792 where two subprogram
definitions match exactly and share the same metadata node. The new
verifier check, requiring that subprogram definitions are 'distinct',
precludes that possibility.
I updated almost all the IR with the following script:
git grep -l -E -e '= !DISubprogram\(.* isDefinition: true' |
grep -v test/Bitcode |
xargs sed -i '' -e 's/= \(!DISubprogram(.*, isDefinition: true\)/= distinct \1/'
Likely some variant of would work for out-of-tree testcases.
llvm-svn: 246327
28 lines
1.9 KiB
LLVM
28 lines
1.9 KiB
LLVM
; RUN: llc -filetype=asm < %s | FileCheck %s
|
|
target triple = "thumbv7-apple-ios7.0.0"
|
|
%class.Matrix3.0.6.10 = type { [9 x float] }
|
|
define arm_aapcscc void @_Z9GetMatrixv(%class.Matrix3.0.6.10* noalias nocapture sret %agg.result) #0 {
|
|
br i1 fcmp oeq (float fadd (float fadd (float fmul (float undef, float undef), float fmul (float undef, float undef)), float fmul (float undef, float undef)), float 0.000000e+00), label %_ZN7Vector39NormalizeEv.exit, label %1
|
|
tail call arm_aapcscc void @_ZL4Sqrtd() #3
|
|
br label %_ZN7Vector39NormalizeEv.exit
|
|
_ZN7Vector39NormalizeEv.exit: ; preds = %1, %0
|
|
; rdar://problem/15094721.
|
|
;
|
|
; When this (partially) dead use gets eliminated (and thus the def
|
|
; of the vreg holding %agg.result) the dbg_value becomes dangling
|
|
; and SelectionDAGISel crashes. It should definitely not
|
|
; crash. Drop the dbg_value instead.
|
|
; CHECK-NOT: "matrix"
|
|
tail call void @llvm.dbg.declare(metadata %class.Matrix3.0.6.10* %agg.result, metadata !45, metadata !DIExpression(DW_OP_deref))
|
|
%2 = getelementptr inbounds %class.Matrix3.0.6.10, %class.Matrix3.0.6.10* %agg.result, i32 0, i32 0, i32 8
|
|
ret void
|
|
}
|
|
declare void @llvm.dbg.declare(metadata, metadata, metadata) #1
|
|
declare arm_aapcscc void @_ZL4Sqrtd() #2
|
|
!4 = !DICompositeType(tag: DW_TAG_class_type, name: "Matrix3", line: 20, size: 288, align: 32, file: !5, identifier: "_ZTS7Matrix3")
|
|
!5 = !DIFile(filename: "test.ii", directory: "/Volumes/Data/radar/15094721")
|
|
!39 = distinct !DISubprogram(name: "GetMatrix", linkageName: "_Z9GetMatrixv", line: 32, isLocal: false, isDefinition: true, virtualIndex: 6, flags: DIFlagPrototyped, isOptimized: true, scopeLine: 32, file: !5, scope: !40, type: !41, function: void (%class.Matrix3.0.6.10*)* @_Z9GetMatrixv)
|
|
!40 = !DIFile(filename: "test.ii", directory: "/Volumes/Data/radar/15094721")
|
|
!41 = !DISubroutineType(types: null)
|
|
!45 = !DILocalVariable(name: "matrix", line: 35, scope: !39, file: !40, type: !4)
|