814b8e91c7
As a follow-up to r246098, require `DISubprogram` definitions
(`isDefinition: true`) to be 'distinct'. Specifically, add an assembler
check, a verifier check, and bitcode upgrading logic to combat testcase
bitrot after the `DIBuilder` change.
While working on the testcases, I realized that
test/Linker/subprogram-linkonce-weak-odr.ll isn't relevant anymore. Its
purpose was to check for a corner case in PR22792 where two subprogram
definitions match exactly and share the same metadata node. The new
verifier check, requiring that subprogram definitions are 'distinct',
precludes that possibility.
I updated almost all the IR with the following script:
git grep -l -E -e '= !DISubprogram\(.* isDefinition: true' |
grep -v test/Bitcode |
xargs sed -i '' -e 's/= \(!DISubprogram(.*, isDefinition: true\)/= distinct \1/'
Likely some variant of would work for out-of-tree testcases.
llvm-svn: 246327
42 lines
1.8 KiB
LLVM
42 lines
1.8 KiB
LLVM
; RUN: opt -analyze -module-debuginfo < %s | FileCheck %s
|
|
|
|
; Produced from linking:
|
|
; /tmp/test1.c containing f()
|
|
; /tmp/test2.c containing g()
|
|
|
|
; Verify that both compile units and both their contained functions are
|
|
; listed by DebugInfoFinder:
|
|
;CHECK: Compile unit: DW_LANG_C99 from /tmp/test1.c
|
|
;CHECK: Compile unit: DW_LANG_C99 from /tmp/test2.c
|
|
;CHECK: Subprogram: f from /tmp/test1.c:1
|
|
;CHECK: Subprogram: g from /tmp/test2.c:1
|
|
|
|
define void @f() {
|
|
ret void, !dbg !14
|
|
}
|
|
|
|
define void @g() {
|
|
ret void, !dbg !15
|
|
}
|
|
|
|
!llvm.dbg.cu = !{!0, !8}
|
|
!llvm.module.flags = !{!13, !16}
|
|
|
|
!0 = distinct !DICompileUnit(language: DW_LANG_C99, producer: "clang version 3.4 (192092)", isOptimized: false, emissionKind: 0, file: !1, enums: !2, retainedTypes: !2, subprograms: !3, globals: !2, imports: !2)
|
|
!1 = !DIFile(filename: "test1.c", directory: "/tmp")
|
|
!2 = !{}
|
|
!3 = !{!4}
|
|
!4 = distinct !DISubprogram(name: "f", line: 1, isLocal: false, isDefinition: true, virtualIndex: 6, isOptimized: false, scopeLine: 1, file: !1, scope: !5, type: !6, function: void ()* @f, variables: !2)
|
|
!5 = !DIFile(filename: "test1.c", directory: "/tmp")
|
|
!6 = !DISubroutineType(types: !7)
|
|
!7 = !{null}
|
|
!8 = distinct !DICompileUnit(language: DW_LANG_C99, producer: "clang version 3.4 (192092)", isOptimized: false, emissionKind: 0, file: !9, enums: !2, retainedTypes: !2, subprograms: !10, globals: !2, imports: !2)
|
|
!9 = !DIFile(filename: "test2.c", directory: "/tmp")
|
|
!10 = !{!11}
|
|
!11 = distinct !DISubprogram(name: "g", line: 1, isLocal: false, isDefinition: true, virtualIndex: 6, isOptimized: false, scopeLine: 1, file: !9, scope: !12, type: !6, function: void ()* @g, variables: !2)
|
|
!12 = !DIFile(filename: "test2.c", directory: "/tmp")
|
|
!13 = !{i32 2, !"Dwarf Version", i32 4}
|
|
!14 = !DILocation(line: 1, scope: !4)
|
|
!15 = !DILocation(line: 1, scope: !11)
|
|
!16 = !{i32 1, !"Debug Info Version", i32 3}
|