fdea9a4ec9
Summary:
Around a third of our test sources have LLVM license headers. This patch removes those headers from all test
sources and also fixes any tests that depended on the length of the license header.
The reasons for this are:
* A few tests verify line numbers and will start failing if the number of lines in the LLVM license header changes. Once I landed my patch for valid SourceLocations in debug info we will probably have even more tests that verify line numbers.
* No other LLVM project is putting license headers in its test files to my knowledge.
* They make the test sources much more verbose than they have to be. Several tests have longer license headers than the actual test source.
For the record, the following tests had their line numbers changed to pass with the removal of the license header:
lldb-api :: functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py
lldb-shell :: Reproducer/TestGDBRemoteRepro.test
lldb-shell :: Reproducer/TestMultipleTargets.test
lldb-shell :: Reproducer/TestReuseDirectory.test
lldb-shell :: ExecControl/StopHook/stop-hook-threads.test
lldb-shell :: ExecControl/StopHook/stop-hook.test
lldb-api :: lang/objc/exceptions/TestObjCExceptions.py
Reviewers: #lldb, espindola, JDevlieghere
Reviewed By: #lldb, JDevlieghere
Subscribers: emaste, aprantl, arphaman, JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74839
70 lines
1.4 KiB
C++
70 lines
1.4 KiB
C++
// This test is intended to create a situation in which one thread will exit
|
|
// while the debugger is stepping in another thread.
|
|
|
|
#include "pseudo_barrier.h"
|
|
#include <thread>
|
|
|
|
#define do_nothing()
|
|
|
|
// A barrier to synchronize thread start.
|
|
pseudo_barrier_t g_barrier;
|
|
|
|
volatile int g_thread_exited = 0;
|
|
|
|
volatile int g_test = 0;
|
|
|
|
void *
|
|
step_thread_func ()
|
|
{
|
|
// Wait until both threads are started.
|
|
pseudo_barrier_wait(g_barrier);
|
|
|
|
g_test = 0; // Set breakpoint here
|
|
|
|
while (!g_thread_exited)
|
|
g_test++;
|
|
|
|
// One more time to provide a continue point
|
|
g_test++; // Continue from here
|
|
|
|
// Return
|
|
return NULL;
|
|
}
|
|
|
|
void *
|
|
exit_thread_func ()
|
|
{
|
|
// Wait until both threads are started.
|
|
pseudo_barrier_wait(g_barrier);
|
|
|
|
// Wait until the other thread is stepping.
|
|
while (g_test == 0)
|
|
do_nothing();
|
|
|
|
// Return
|
|
return NULL;
|
|
}
|
|
|
|
int main ()
|
|
{
|
|
// Synchronize thread start so that doesn't happen during stepping.
|
|
pseudo_barrier_init(g_barrier, 2);
|
|
|
|
// Create a thread to hit the breakpoint.
|
|
std::thread thread_1(step_thread_func);
|
|
|
|
// Create a thread to exit while we're stepping.
|
|
std::thread thread_2(exit_thread_func);
|
|
|
|
// Wait for the exit thread to finish.
|
|
thread_2.join();
|
|
|
|
// Let the stepping thread know the other thread is gone.
|
|
g_thread_exited = 1;
|
|
|
|
// Wait for the stepping thread to finish.
|
|
thread_1.join();
|
|
|
|
return 0;
|
|
}
|