f12808ab20
The note tag that was previously added in all cases when a standard function call is found is displayed now only if the function call (return value) is "interesting". This results in less unneeded notes but some of the previously good notes disappear too. This is because interestingness is not always set as it should be. Reviewed By: donat.nagy Differential Revision: https://reviews.llvm.org/D153776
83 lines
2.7 KiB
C
83 lines
2.7 KiB
C
// RUN: %clang_analyze_cc1 -verify %s \
|
|
// RUN: -analyzer-checker=core,alpha.unix.StdCLibraryFunctions \
|
|
// RUN: -analyzer-config alpha.unix.StdCLibraryFunctions:ModelPOSIX=true \
|
|
// RUN: -analyzer-output=text
|
|
|
|
#include "Inputs/std-c-library-functions-POSIX.h"
|
|
#define NULL ((void *)0)
|
|
|
|
char *getenv(const char *);
|
|
int isalpha(int);
|
|
int isdigit(int);
|
|
int islower(int);
|
|
|
|
char test_getenv() {
|
|
char *env = getenv("VAR"); // \
|
|
// expected-note{{Assuming the environment variable does not exist}} \
|
|
// expected-note{{'env' initialized here}}
|
|
|
|
return env[0]; // \
|
|
// expected-warning{{Array access (from variable 'env') results in a null pointer dereference}} \
|
|
// expected-note {{Array access (from variable 'env') results in a null pointer dereference}}
|
|
}
|
|
|
|
int test_isalpha(int *x, char c, char d) {
|
|
int iad = isalpha(d);
|
|
if (isalpha(c)) {// \
|
|
// expected-note{{Taking true branch}}
|
|
x = NULL; // \
|
|
// expected-note{{Null pointer value stored to 'x'}}
|
|
}
|
|
|
|
return *x; // \
|
|
// expected-warning{{Dereference of null pointer (loaded from variable 'x')}} \
|
|
// expected-note {{Dereference of null pointer (loaded from variable 'x')}}
|
|
}
|
|
|
|
int test_isdigit(int *x, char c) {
|
|
if (!isdigit(c)) {// \
|
|
// expected-note{{Taking true branch}}
|
|
x = NULL; // \
|
|
// expected-note{{Null pointer value stored to 'x'}}
|
|
}
|
|
|
|
return *x; // \
|
|
// expected-warning{{Dereference of null pointer (loaded from variable 'x')}} \
|
|
// expected-note {{Dereference of null pointer (loaded from variable 'x')}}
|
|
}
|
|
|
|
int test_islower(int *x) {
|
|
char c = 'c';
|
|
// No "Assuming..." note. We aren't assuming anything. We *know*.
|
|
if (islower(c)) { // \
|
|
// expected-note{{Taking true branch}}
|
|
x = NULL; // \
|
|
// expected-note{{Null pointer value stored to 'x'}}
|
|
}
|
|
|
|
return *x; // \
|
|
// expected-warning{{Dereference of null pointer (loaded from variable 'x')}} \
|
|
// expected-note {{Dereference of null pointer (loaded from variable 'x')}}
|
|
}
|
|
|
|
int test_bugpath_notes(FILE *f1, char c, FILE *f2) {
|
|
int f = fileno(f2);
|
|
if (f == -1) // \
|
|
// expected-note{{Taking false branch}}
|
|
return 0;
|
|
int l = islower(c);
|
|
f = fileno(f1); // \
|
|
// expected-note{{Value assigned to 'f'}} \
|
|
// expected-note{{Assuming that 'fileno' fails}}
|
|
return dup(f); // \
|
|
// expected-warning{{The 1st argument to 'dup' is -1 but should be >= 0}} \
|
|
// expected-note{{The 1st argument to 'dup' is -1 but should be >= 0}}
|
|
}
|
|
|
|
int test_fileno_arg_note(FILE *f1) {
|
|
return dup(fileno(f1)); // \
|
|
// expected-warning{{The 1st argument to 'dup' is < 0 but should be >= 0}} \
|
|
// expected-note{{The 1st argument to 'dup' is < 0 but should be >= 0}} \
|
|
// expected-note{{Assuming that 'fileno' fails}}
|
|
}
|