3d334df587
std::format is currently experimental, so there is technically no deployment target requirement for it (since the only symbols required for it are in `libc++experimental.a`). However, some parts of std::format depend indirectly on the floating point std::to_chars implementation, which does have deployment target requirements. This patch removes all the availability format for std::format and updates the XFAILs in the tests to properly explain why they fail on old deployment targets, when they do. It also changes a couple of tests to avoid depending on floating-point std::to_chars when it isn't fundamental to the test. Finally, some tests are marked as XFAIL but I added a comment saying TODO FMT This test should not require std::to_chars(floating-point) These tests do not fundamentally depend on floating-point std::to_chars, however they end up failing because calling std::format even without a floating-point argument to format will end up requiring floating-point std::to_chars. I believe this is an implementation artifact that could be avoided in all cases where we know the format string at compile-time. In the tests, I added the TODO comment only to the places where we could do better and actually avoid relying on floating-point std::to_chars because we know the format string at compile-time. Differential Revision: https://reviews.llvm.org/D134598
55 lines
1.5 KiB
C++
55 lines
1.5 KiB
C++
// -*- C++ -*-
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef _LIBCPP___FORMAT_FORMATTER_H
|
|
#define _LIBCPP___FORMAT_FORMATTER_H
|
|
|
|
#include <__availability>
|
|
#include <__config>
|
|
#include <__format/format_fwd.h>
|
|
|
|
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
|
|
# pragma GCC system_header
|
|
#endif
|
|
|
|
_LIBCPP_BEGIN_NAMESPACE_STD
|
|
|
|
#if _LIBCPP_STD_VER >= 20
|
|
|
|
/// The default formatter template.
|
|
///
|
|
/// [format.formatter.spec]/5
|
|
/// If F is a disabled specialization of formatter, these values are false:
|
|
/// - is_default_constructible_v<F>,
|
|
/// - is_copy_constructible_v<F>,
|
|
/// - is_move_constructible_v<F>,
|
|
/// - is_copy_assignable<F>, and
|
|
/// - is_move_assignable<F>.
|
|
template <class _Tp, class _CharT>
|
|
struct _LIBCPP_TEMPLATE_VIS formatter {
|
|
formatter() = delete;
|
|
formatter(const formatter&) = delete;
|
|
formatter& operator=(const formatter&) = delete;
|
|
};
|
|
|
|
# if _LIBCPP_STD_VER >= 23
|
|
|
|
template <class _Tp>
|
|
_LIBCPP_HIDE_FROM_ABI constexpr void __set_debug_format(_Tp& __formatter) {
|
|
if constexpr (requires { __formatter.set_debug_format(); })
|
|
__formatter.set_debug_format();
|
|
}
|
|
|
|
# endif // _LIBCPP_STD_VER >= 23
|
|
#endif // _LIBCPP_STD_VER >= 20
|
|
|
|
_LIBCPP_END_NAMESPACE_STD
|
|
|
|
#endif // _LIBCPP___FORMAT_FORMATTER_H
|