9bb71b73d9
Bug fix for pr18841: http://llvm.org/bugs/show_bug.cgi?id=18841 This change creates a stub Python readline.so module that does almost nothing. Its whole purpose is to prevent Python from loading the real module, something it does during the embedded Python interpreter's initialization sequence (and way before lldb ever requests it within embedded_interpreter.py). On Ubuntu 12.04 and 13.10 x86_64, and in the Python 2.7.6 tree, the stock Python readline module links against the GNU readline library. This appears to be the case on all Pythons except where __APPLE__ is defined. LLDB now requires linking against the libedit library. Something about having both libedit.so and libreadline.so linked into the same process space is causing the Python readline.so to trigger a NULL memory access. I have put in a separate patch to python.org. This suppression of embedded interpreter readline support can be removed if at least any one of the following happens: 1. The stock python distribution accepts a patch similar to what I submitted to Python 2.7.6's Modules/readline.c file. 2. The stock python distribution implements Modules/readline.c in terms of libedit's readline compatibility mode (i.e. essentially compiles it the way __APPLE__ compiles that module) under Linux. 3. a clean-room implementation of the python readline module is implemented against libedit (either readline compatibility mode or native libedit). This could be implemented within the readline.cpp file that this change introduces. It cannot be a fork of python's readline.c module due to llvm licensing. The net effect of this change on Linux is that the embedded python's readline support will not exist. llvm-svn: 202243
100 lines
3.9 KiB
Makefile
100 lines
3.9 KiB
Makefile
##===- scripts/Python/modules/readline/Makefile ------------*- Makefile -*-===##
|
|
#
|
|
# The LLVM Compiler Infrastructure
|
|
#
|
|
# This file is distributed under the University of Illinois Open Source
|
|
# License. See LICENSE.TXT for details.
|
|
#
|
|
##===----------------------------------------------------------------------===##
|
|
|
|
# Skip this entire Makefile if python is disabled.
|
|
ifeq (,$(findstring -DLLDB_DISABLE_PYTHON,$(CXXFLAGS)))
|
|
|
|
LEVEL := ../../../../../..
|
|
LLDB_LEVEL := ../../../..
|
|
|
|
LIBRARYNAME = readline
|
|
|
|
NO_BUILD_ARCHIVE = 1
|
|
LINK_LIBS_IN_SHARED = 1
|
|
SHARED_LIBRARY = 1
|
|
LOADABLE_MODULE = 1
|
|
|
|
PYTHON_INCLUDES = $(shell python-config --includes)
|
|
|
|
# Include all archives in the shared lib
|
|
USEDLIBS :=
|
|
|
|
include $(LLDB_LEVEL)/../../Makefile.config
|
|
|
|
LINK_COMPONENTS :=
|
|
|
|
include $(LEVEL)/Makefile.common
|
|
|
|
# include python headers
|
|
CXXFLAGS += $(PYTHON_INCLUDES)
|
|
|
|
ifeq ($(HOST_OS),Darwin)
|
|
LLVMLibsOptions += -Wl,-all_load
|
|
# set dylib internal version number to llvmCore submission number
|
|
ifdef LLDB_SUBMIT_VERSION
|
|
LLVMLibsOptions += -Wl,-current_version \
|
|
-Wl,$(LLDB_SUBMIT_VERSION).$(LLDB_SUBMIT_SUBVERSION) \
|
|
-Wl,-compatibility_version -Wl,1
|
|
endif
|
|
# extra options to override libtool defaults
|
|
LVMLibsOptions += -F/System/Library/Frameworks -F/System/Library/PrivateFrameworks
|
|
LLVMLibsOptions += -framework Foundation -framework CoreFoundation
|
|
LLVMLibsOptions += -framework CoreServices -framework Carbon -framework Security
|
|
LLVMLibsOptions += -framework DebugSymbols $(PYTHON_BUILD_FLAGS) -lobjc
|
|
# Mac OS X 10.4 and earlier tools do not allow a second -install_name on command line
|
|
DARWIN_VERS := $(shell echo $(TARGET_TRIPLE) | sed 's/.*darwin\([0-9]*\).*/\1/')
|
|
ifneq ($(DARWIN_VERS),8)
|
|
LLVMLibsOptions += -Wl,-install_name \
|
|
-Wl,"@executable_path/../lib/$(LIBRARYNAME)$(SHLIBEXT)"
|
|
endif
|
|
endif
|
|
|
|
ifeq ($(HOST_OS), $(filter $(HOST_OS), Linux GNU GNU/kFreeBSD))
|
|
# Include everything from the .a's into the shared library.
|
|
ProjLibsOptions := -Wl,--whole-archive $(ProjLibsOptions) \
|
|
-Wl,--no-whole-archive
|
|
# Link in libedit
|
|
# LLVMLibsOptions += -ledit
|
|
LLVMLibsOptions += -Wl,--soname,$(LIBRARYNAME)$(SHLIBEXT)
|
|
endif
|
|
|
|
ifeq ($(HOST_OS),FreeBSD)
|
|
# Include everything from the .a's into the shared library.
|
|
ProjLibsOptions := -Wl,--whole-archive $(ProjLibsOptions) \
|
|
-Wl,--no-whole-archive
|
|
# Allow unresolved symbols.
|
|
LLVMLibsOptions += -Wl,--allow-shlib-undefined
|
|
# Link in libedit
|
|
# LLVMLibsOptions += -L/usr/local/lib -ledit
|
|
endif
|
|
|
|
# FIXME: dynamically construct the version from `python -V`
|
|
PYTHON_VERSION:=2.7
|
|
LLDB_PYTHON_MODULE_REL_DIR:=python$(PYTHON_VERSION)/site-packages
|
|
LLDB_PYTHON_MODULE_DIR:=$(LibDir)/$(LLDB_PYTHON_MODULE_REL_DIR)
|
|
|
|
# Target to move readline module from shared lib build location to
|
|
# local python module directory.
|
|
all-local:: $(LLDB_PYTHON_MODULE_DIR)/$(LIBRARYNAME)$(SHLIBEXT)
|
|
|
|
$(LLDB_PYTHON_MODULE_DIR)/$(LIBRARYNAME)$(SHLIBEXT): $(SharedLibDir)/$(LIBRARYNAME)$(SHLIBEXT)
|
|
$(Echo) Staging $(BuildMode) $(LIBRARYNAME)$(SHLIBEXT) to $(LLDB_PYTHON_MODULE_DIR)
|
|
$(Verb) $(MKDIR) "$(LLDB_PYTHON_MODULE_DIR)"
|
|
$(Verb) $(ProgInstall) $(SharedLibDir)/$(LIBRARYNAME)$(SHLIBEXT) $(LLDB_PYTHON_MODULE_DIR)
|
|
|
|
# Target to move the shared library from the build python lib dir to
|
|
# the install python lib dir.
|
|
install-local:: $(LLDB_PYTHON_MODULE_DIR)/$(LIBRARYNAME)$(SHLIBEXT)
|
|
$(Echo) Installing $(BuildMode) $(LLDB_PYTHON_MODULE_DIR)/$(LIBRARYNAME)$(SHLIBEXT) to $(DESTDIR)$(prefix)/lib/$(LLDB_PYTHON_MODULE_REL_DIR)
|
|
$(Verb) $(MKDIR) "$(DESTDIR)$(prefix)/lib/$(LLDB_PYTHON_MODULE_REL_DIR)"
|
|
$(Verb) $(ProgInstall) "$(LLDB_PYTHON_MODULE_DIR)/$(LIBRARYNAME)$(SHLIBEXT)" "$(DESTDIR)$(prefix)/lib/$(LLDB_PYTHON_MODULE_REL_DIR)"
|
|
$(Verb) $(RM) "$(DESTDIR)$(prefix)/lib/$(LIBRARYNAME)$(SHLIBEXT)"
|
|
|
|
endif # if !defined(LLDB_DISABLE_PYTHON)
|