a6e8d5e554
expression is a discarded-value expression.
Summary:
We used to get this wrong in three ways:
1) During parsing, an expression-statement followed by the }) ending a
statement expression was always treated as producing the value of the
statement expression. That's wrong for ({ if (1) expr; })
2) During template instantiation, various kinds of statement (most
statements not appearing directly in a compound-statement) were not
treated as discarded-value expressions, resulting in missing volatile
loads (etc).
3) In all contexts, an expression-statement with attributes was not
treated as producing the value of the statement expression, eg
({ [[attr]] expr; }).
Also fix incorrect enforcement of OpenMP rule that directives can "only
be placed in the program at a position where ignoring or deleting the
directive would result in a program with correct syntax". In particular,
a label (be it goto, case, or default) should not affect whether
directives are permitted.
Reviewers: aaron.ballman, rjmccall
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D57984
llvm-svn: 354090
119 lines
3.3 KiB
C++
119 lines
3.3 KiB
C++
// RUN: %clang_cc1 -verify -fopenmp -ferror-limit 100 %s
|
|
|
|
// RUN: %clang_cc1 -verify -fopenmp-simd -ferror-limit 100 %s
|
|
|
|
template <class T>
|
|
T tmain(T argc) {
|
|
#pragma omp taskyield
|
|
;
|
|
#pragma omp taskyield untied // expected-error {{unexpected OpenMP clause 'untied' in directive '#pragma omp taskyield'}}
|
|
#pragma omp taskyield unknown // expected-warning {{extra tokens at the end of '#pragma omp taskyield' are ignored}}
|
|
if (argc)
|
|
#pragma omp taskyield // expected-error {{'#pragma omp taskyield' cannot be an immediate substatement}}
|
|
if (argc) {
|
|
#pragma omp taskyield
|
|
}
|
|
while (argc)
|
|
#pragma omp taskyield // expected-error {{'#pragma omp taskyield' cannot be an immediate substatement}}
|
|
while (argc) {
|
|
#pragma omp taskyield
|
|
}
|
|
do
|
|
#pragma omp taskyield // expected-error {{'#pragma omp taskyield' cannot be an immediate substatement}}
|
|
while (argc)
|
|
;
|
|
do {
|
|
#pragma omp taskyield
|
|
} while (argc);
|
|
switch (argc)
|
|
#pragma omp taskyield // expected-error {{'#pragma omp taskyield' cannot be an immediate substatement}}
|
|
switch (argc)
|
|
case 1:
|
|
#pragma omp taskyield // expected-error {{'#pragma omp taskyield' cannot be an immediate substatement}}
|
|
switch (argc)
|
|
case 1: {
|
|
#pragma omp taskyield
|
|
}
|
|
switch (argc) {
|
|
#pragma omp taskyield
|
|
case 1:
|
|
#pragma omp taskyield
|
|
break;
|
|
default: {
|
|
#pragma omp taskyield
|
|
} break;
|
|
}
|
|
for (;;)
|
|
#pragma omp taskyield // expected-error {{'#pragma omp taskyield' cannot be an immediate substatement}}
|
|
for (;;) {
|
|
#pragma omp taskyield
|
|
}
|
|
label:
|
|
#pragma omp taskyield
|
|
label1 : {
|
|
#pragma omp taskyield
|
|
}
|
|
if (1)
|
|
label2:
|
|
#pragma omp taskyield // expected-error {{'#pragma omp taskyield' cannot be an immediate substatement}}
|
|
|
|
return T();
|
|
}
|
|
|
|
int main(int argc, char **argv) {
|
|
#pragma omp taskyield
|
|
;
|
|
#pragma omp taskyield untied // expected-error {{unexpected OpenMP clause 'untied' in directive '#pragma omp taskyield'}}
|
|
#pragma omp taskyield unknown // expected-warning {{extra tokens at the end of '#pragma omp taskyield' are ignored}}
|
|
if (argc)
|
|
#pragma omp taskyield // expected-error {{'#pragma omp taskyield' cannot be an immediate substatement}}
|
|
if (argc) {
|
|
#pragma omp taskyield
|
|
}
|
|
while (argc)
|
|
#pragma omp taskyield // expected-error {{'#pragma omp taskyield' cannot be an immediate substatement}}
|
|
while (argc) {
|
|
#pragma omp taskyield
|
|
}
|
|
do
|
|
#pragma omp taskyield // expected-error {{'#pragma omp taskyield' cannot be an immediate substatement}}
|
|
while (argc)
|
|
;
|
|
do {
|
|
#pragma omp taskyield
|
|
} while (argc);
|
|
switch (argc)
|
|
#pragma omp taskyield // expected-error {{'#pragma omp taskyield' cannot be an immediate substatement}}
|
|
switch (argc)
|
|
case 1:
|
|
#pragma omp taskyield // expected-error {{'#pragma omp taskyield' cannot be an immediate substatement}}
|
|
switch (argc)
|
|
case 1: {
|
|
#pragma omp taskyield
|
|
}
|
|
switch (argc) {
|
|
#pragma omp taskyield
|
|
case 1:
|
|
#pragma omp taskyield
|
|
break;
|
|
default: {
|
|
#pragma omp taskyield
|
|
} break;
|
|
}
|
|
for (;;)
|
|
#pragma omp taskyield // expected-error {{'#pragma omp taskyield' cannot be an immediate substatement}}
|
|
for (;;) {
|
|
#pragma omp taskyield
|
|
}
|
|
label:
|
|
#pragma omp taskyield
|
|
label1 : {
|
|
#pragma omp taskyield
|
|
}
|
|
if (1)
|
|
label2:
|
|
#pragma omp taskyield // expected-error {{'#pragma omp taskyield' cannot be an immediate substatement}}
|
|
|
|
return tmain(argc);
|
|
}
|