ab674234c4
LLDB's implementation of DWARFDataExtractor has a method that returns a llvm::DWARFDataExtractor. In some cases, like DebugNamesDWARFIndex::Create, we were passing an LLVM::DWARFDataExtractor to a function that expects a LLVM:DataExtractor by value. This is causing slicing of the derived class. While slicing is not inherently bad, it can be dangerous if the constructor of the derived class mutates the base class in a way that leaves it in an invalid state after slicing. Differential Revision: https://reviews.llvm.org/D153913
39 lines
1.3 KiB
C++
39 lines
1.3 KiB
C++
//===-- DWARFDataExtractor.h ------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLDB_SOURCE_PLUGINS_SYMBOLFILE_DWARF_DWARFDATAEXTRACTOR_H
|
|
#define LLDB_SOURCE_PLUGINS_SYMBOLFILE_DWARF_DWARFDATAEXTRACTOR_H
|
|
|
|
#include "lldb/Core/dwarf.h"
|
|
#include "lldb/Utility/DataExtractor.h"
|
|
#include "llvm/DebugInfo/DWARF/DWARFDataExtractor.h"
|
|
|
|
namespace lldb_private {
|
|
|
|
class DWARFDataExtractor : public DataExtractor {
|
|
public:
|
|
DWARFDataExtractor() = default;
|
|
|
|
DWARFDataExtractor(const DWARFDataExtractor &data, lldb::offset_t offset,
|
|
lldb::offset_t length)
|
|
: DataExtractor(data, offset, length) {}
|
|
|
|
uint64_t GetDWARFInitialLength(lldb::offset_t *offset_ptr) const;
|
|
|
|
dw_offset_t GetDWARFOffset(lldb::offset_t *offset_ptr) const;
|
|
|
|
size_t GetDWARFSizeofInitialLength() const { return 4; }
|
|
size_t GetDWARFSizeOfOffset() const { return 4; }
|
|
|
|
llvm::DWARFDataExtractor GetAsLLVMDWARF() const;
|
|
llvm::DataExtractor GetAsLLVM() const;
|
|
};
|
|
}
|
|
|
|
#endif // LLDB_SOURCE_PLUGINS_SYMBOLFILE_DWARF_DWARFDATAEXTRACTOR_H
|