Patch from 'troyj': Hi, I ran into a problem with this test when the source was located in certain directories. The mkdir(2) man page states that the set-group-ID bit is inherited from the parent directory, but this test was written in such a way that it assumes the bit is unset. Whether that assumption is true depends on where the checkout lives, which leads to some people being able to reproduce the problem whereas others cannot. I think the correct fix is to exclude the bit from the check. Making probinson a reviewer since they reviewed the original test. Patch landed for troyj, thanks! Differential Revision: D53832 llvm-svn: 357449
53 lines
1.4 KiB
C
53 lines
1.4 KiB
C
// UNSUPPORTED: windows
|
|
// RUN: %clang_pgogen -o %t.bin %s -DTESTPATH=\"%t.dir\"
|
|
// RUN: rm -rf %t.dir
|
|
// RUN: %run %t.bin
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <sys/stat.h>
|
|
|
|
void __llvm_profile_set_dir_mode(unsigned Mode);
|
|
unsigned __llvm_profile_get_dir_mode(void);
|
|
void __llvm_profile_recursive_mkdir(char *Path);
|
|
|
|
static int test(unsigned Mode, const char *TestDir) {
|
|
int Ret = 0;
|
|
|
|
/* Create a dir and set the mode accordingly. */
|
|
char *Dir = strdup(TestDir);
|
|
if (!Dir)
|
|
return -1;
|
|
__llvm_profile_set_dir_mode(Mode);
|
|
__llvm_profile_recursive_mkdir(Dir);
|
|
|
|
if (Mode != __llvm_profile_get_dir_mode())
|
|
Ret = -1;
|
|
else {
|
|
// From 'man mkdir':
|
|
// "If the parent directory has the set-group-ID bit set, then so will the
|
|
// newly created directory." So we mask off S_ISGID below; this test cannot
|
|
// control its parent directory.
|
|
const unsigned Expected = ~umask(0) & Mode;
|
|
struct stat DirSt;
|
|
if (stat(Dir, &DirSt) == -1)
|
|
Ret = -1;
|
|
else if ((DirSt.st_mode & ~S_ISGID) != Expected) {
|
|
printf("Modes do not match: Expected %o but found %o (%s)\n", Expected,
|
|
DirSt.st_mode, Dir);
|
|
Ret = -1;
|
|
}
|
|
}
|
|
|
|
free(Dir);
|
|
return Ret;
|
|
}
|
|
|
|
int main(void) {
|
|
if (test(S_IFDIR | 0777, TESTPATH "/foo/bar/baz/") ||
|
|
test(S_IFDIR | 0666, TESTPATH "/foo/bar/qux/"))
|
|
return -1;
|
|
return 0;
|
|
}
|