The hardware has created a real mess in the naming for add/sub, which have been renamed basically every generation. Switch the carry out pseudos to have the gfx9/gfx10 names. We were using the original SI/CI v_add_i32/v_sub_i32 names. Later targets reintroduced these names as carryless instructions with a saturating clamp bit, which we do not define. Do this rename so we can unambiguously add these missing instructions. The carry-in versions should also be renamed, but at least those had a consistent _u32 name to begin with. The 16-bit instructions were also renamed, but aren't ambiguous. This does regress assembler error message quality in some cases. In mismatched wave32/wave64 situations, this will switch from "unsupported instruction" to "invalid operand", with the error pointing at the wrong position. I couldn't quite follow how the assembler selects these, but the previous behavior seemed accidental to me. It looked like there was a partial attempt to handle this which was never completed (i.e. there is an AMDGPUOperand::isBoolReg but it isn't used for anything).
41 lines
1.3 KiB
YAML
41 lines
1.3 KiB
YAML
# RUN: llc -march=amdgcn -verify-machineinstrs -run-pass si-shrink-instructions -o - %s | FileCheck -check-prefix=GCN %s
|
|
...
|
|
# GCN-LABEL: name: fold_imm_non_ssa{{$}}
|
|
# GCN: %0:vgpr_32 = V_MOV_B32_e32 123, implicit $exec
|
|
# GCN: %2:vgpr_32 = V_ADD_CO_U32_e32 456, %0, implicit-def $vcc, implicit $exec
|
|
|
|
name: fold_imm_non_ssa
|
|
tracksRegLiveness: true
|
|
registers:
|
|
- { id: 0, class: vgpr_32 }
|
|
- { id: 1, class: vgpr_32 }
|
|
- { id: 2, class: vgpr_32 }
|
|
- { id: 3, class: sreg_64 }
|
|
body: |
|
|
bb.0:
|
|
%0 = COPY undef %0
|
|
%0 = V_MOV_B32_e32 123, implicit $exec
|
|
%1 = V_MOV_B32_e32 456, implicit $exec
|
|
%2, $vcc = V_ADD_CO_U32_e64 %0, %1, 0, implicit $exec
|
|
S_ENDPGM 0
|
|
|
|
...
|
|
# GCN-LABEL: name: fold_partially_defined_superreg{{$}}
|
|
# GCN: %1:vgpr_32 = V_MOV_B32_e32 456, implicit $exec
|
|
# GCN: %2:vgpr_32 = V_ADD_CO_U32_e32 123, %1, implicit-def $vcc, implicit $exec
|
|
name: fold_partially_defined_superreg
|
|
tracksRegLiveness: true
|
|
registers:
|
|
- { id: 0, class: vgpr_32 }
|
|
- { id: 1, class: vgpr_32 }
|
|
- { id: 2, class: vgpr_32 }
|
|
- { id: 3, class: vreg_64 }
|
|
body: |
|
|
bb.0:
|
|
undef %3.sub0 = V_MOV_B32_e32 123, implicit $exec, implicit-def %3
|
|
%1 = V_MOV_B32_e32 456, implicit $exec
|
|
%2, $vcc = V_ADD_CO_U32_e64 %3.sub0, %1, 0, implicit $exec
|
|
S_ENDPGM 0
|
|
|
|
...
|