3336f681e3
Summary:
This change adds some verification in the IR verifier around struct path
TBAA metadata.
Other than some basic sanity checks (e.g. we get constant integers where
we expect constant integers), this checks:
- That by the time an struct access tuple `(base-type, offset)` is
"reduced" to a scalar base type, the offset is `0`. For instance, in
C++ you can't start from, say `("struct-a", 16)`, and end up with
`("int", 4)` -- by the time the base type is `"int"`, the offset
better be zero. In particular, a variant of this invariant is needed
for `llvm::getMostGenericTBAA` to be correct.
- That there are no cycles in a struct path.
- That struct type nodes have their offsets listed in an ascending
order.
- That when generating the struct access path, you eventually reach the
access type listed in the tbaa tag node.
Reviewers: dexonsmith, chandlerc, reames, mehdi_amini, manmanren
Subscribers: mcrosier, llvm-commits
Differential Revision: https://reviews.llvm.org/D26438
llvm-svn: 289402
60 lines
1.8 KiB
LLVM
60 lines
1.8 KiB
LLVM
; RUN: opt < %s -tsan -S | FileCheck %s
|
|
; Check that tsan does not instrument reads from constant globals.
|
|
|
|
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
|
|
|
|
@const_global = external constant i32
|
|
define i32 @read_from_const_global() nounwind uwtable sanitize_thread readnone {
|
|
entry:
|
|
%0 = load i32, i32* @const_global, align 4
|
|
ret i32 %0
|
|
}
|
|
; CHECK: define i32 @read_from_const_global
|
|
; CHECK-NOT: __tsan
|
|
; CHECK: ret i32
|
|
|
|
@non_const_global = global i32 0, align 4
|
|
define i32 @read_from_non_const_global() nounwind uwtable sanitize_thread readonly {
|
|
entry:
|
|
%0 = load i32, i32* @non_const_global, align 4
|
|
ret i32 %0
|
|
}
|
|
|
|
; CHECK: define i32 @read_from_non_const_global
|
|
; CHECK: __tsan_read
|
|
; CHECK: ret i32
|
|
|
|
@const_global_array = external constant [10 x i32]
|
|
define i32 @read_from_const_global_array(i32 %idx) nounwind uwtable sanitize_thread readnone {
|
|
entry:
|
|
%idxprom = sext i32 %idx to i64
|
|
%arrayidx = getelementptr inbounds [10 x i32], [10 x i32]* @const_global_array, i64 0, i64 %idxprom
|
|
%0 = load i32, i32* %arrayidx, align 4
|
|
ret i32 %0
|
|
}
|
|
|
|
; CHECK: define i32 @read_from_const_global_array
|
|
; CHECK-NOT: __tsan
|
|
; CHECK: ret i32
|
|
|
|
%struct.Foo = type { i32 (...)** }
|
|
define void @call_virtual_func(%struct.Foo* %f) uwtable sanitize_thread {
|
|
entry:
|
|
%0 = bitcast %struct.Foo* %f to void (%struct.Foo*)***
|
|
%vtable = load void (%struct.Foo*)**, void (%struct.Foo*)*** %0, align 8, !tbaa !2
|
|
%1 = load void (%struct.Foo*)*, void (%struct.Foo*)** %vtable, align 8
|
|
call void %1(%struct.Foo* %f)
|
|
ret void
|
|
}
|
|
|
|
; CHECK: define void @call_virtual_func
|
|
; CHECK: __tsan_vptr_read
|
|
; CHECK: = load
|
|
; CHECK-NOT: __tsan_read
|
|
; CHECK: = load
|
|
; CHECK: ret void
|
|
|
|
!0 = !{!"Simple C/C++ TBAA"}
|
|
!1 = !{!"vtable pointer", !0}
|
|
!2 = !{!1, !1, i64 0}
|