7f6360cdc6
Summary: Expand existing loopsink testing to also test loopsinking using new pass manager. Enable memoryssa for loopsink with new pass manager. This combination exposed a bug that was previously fixed for loopsink without memoryssa. When sinking an instruction into a loop, the source block may not be part of the loop but still needs to be checked for pointer invalidation. This is the fix for bugzilla #39695 (PR 54659) expanded to also work with memoryssa. Respond to review comments. Enable Memory SSA in legacy Loop Sink pass under EnableMSSALoopDependency option control. Update tests accordingly. Respond to review comments. Add options controlling whether memoryssa is used for loop sink, defaulting to off. Expand testing based on these options. Respond to review comments. Properly indicated preserved analyses. This relanding addresses a compile-time performance problem by moving test for profile data earlier to avoid unnecessary computations. Author: Jamie Schmeiser <schmeise@ca.ibm.com> Reviewed By: asbirlea (Alina Sbirlea) Differential Revision: https://reviews.llvm.org/D90249
69 lines
2.0 KiB
LLVM
69 lines
2.0 KiB
LLVM
; RUN: opt -S -loop-sink < %s | FileCheck %s
|
|
; RUN: opt -S -verify-memoryssa -enable-mssa-in-legacy-loop-sink -loop-sink < %s | FileCheck %s
|
|
; RUN: opt -S -aa-pipeline=basic-aa -passes=loop-sink < %s | FileCheck %s
|
|
; RUN: opt -S -verify-memoryssa -enable-mssa-in-loop-sink -aa-pipeline=basic-aa -passes=loop-sink < %s | FileCheck %s
|
|
|
|
target datalayout = "e-m:w-i64:64-f80:128-n8:16:32:64-S128"
|
|
target triple = "x86_64-pc-windows-msvc19.13.26128"
|
|
|
|
%struct.FontInfoData = type { i32 (...)** }
|
|
%struct.S = type { i8 }
|
|
|
|
; CHECK: @pr38462
|
|
; Make sure not to assert by trying to sink into catch.dispatch.
|
|
|
|
define void @pr38462(%struct.FontInfoData* %this) personality i8* bitcast (i32 (...)* @__C_specific_handler to i8*) !prof !1 {
|
|
entry:
|
|
%s = alloca %struct.S
|
|
%call6 = call i32 @f()
|
|
%tobool7 = icmp eq i32 %call6, 0
|
|
br i1 %tobool7, label %for.body.lr.ph, label %for.cond.cleanup
|
|
|
|
for.body.lr.ph:
|
|
%0 = getelementptr inbounds %struct.S, %struct.S* %s, i64 0, i32 0
|
|
br label %for.body
|
|
|
|
for.cond.cleanup.loopexit:
|
|
br label %for.cond.cleanup
|
|
|
|
for.cond.cleanup:
|
|
ret void
|
|
|
|
for.body:
|
|
%call2 = invoke i32 @f() to label %__try.cont unwind label %catch.dispatch
|
|
|
|
catch.dispatch:
|
|
%1 = catchswitch within none [label %__except] unwind to caller
|
|
|
|
__except:
|
|
%2 = catchpad within %1 [i8* null]
|
|
catchret from %2 to label %__except3
|
|
|
|
__except3:
|
|
call void @llvm.lifetime.start.p0i8(i64 1, i8* nonnull %0)
|
|
%call.i = call zeroext i1 @g(%struct.S* nonnull %s)
|
|
br i1 %call.i, label %if.then.i, label %exit
|
|
|
|
if.then.i:
|
|
%call2.i = call i32 @f()
|
|
br label %exit
|
|
|
|
exit:
|
|
call void @llvm.lifetime.end.p0i8(i64 1, i8* nonnull %0)
|
|
br label %__try.cont
|
|
|
|
__try.cont:
|
|
%call = call i32 @f()
|
|
%tobool = icmp eq i32 %call, 0
|
|
br i1 %tobool, label %for.body, label %for.cond.cleanup.loopexit
|
|
}
|
|
|
|
declare i32 @__C_specific_handler(...)
|
|
declare i32 @f()
|
|
declare zeroext i1 @g(%struct.S*)
|
|
declare void @llvm.lifetime.start.p0i8(i64, i8* nocapture)
|
|
declare void @llvm.lifetime.end.p0i8(i64, i8* nocapture)
|
|
|
|
!1 = !{!"function_entry_count", i64 1}
|
|
|