This patch removes the non compliant constructor of std::future_error and adds the standards compliant constructor in C++17 instead. Note that we can't support the constructor as an extension in all standard modes because it uses delegating constructors, which require C++11. We could in theory support the constructor as an extension in C++11 and C++14 only, however I believe it is acceptable not to do that since I expect the breakage from this patch will be minimal. If it turns out that more code than we expect is broken by this, we can reconsider that decision. This was found during D99515. Differential Revision: https://reviews.llvm.org/D99567 Co-authored-by: Louis Dionne <ldionne.2@gmail.com>
66 lines
2.2 KiB
C++
66 lines
2.2 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// UNSUPPORTED: no-threads
|
|
|
|
// LWG 2056 changed the values of future_errc, so if we're using new headers
|
|
// with an old library we'll get incorrect messages.
|
|
//
|
|
// XFAIL: stdlib=apple-libc++ && target={{.+}}-apple-macosx10.{{9|10|11}}
|
|
|
|
// VC Runtime's std::exception::what() method is not marked as noexcept, so
|
|
// this fails.
|
|
// UNSUPPORTED: target=x86_64-pc-windows-msvc
|
|
|
|
// <future>
|
|
//
|
|
// class future_error
|
|
//
|
|
// const char* what() const noexcept;
|
|
|
|
#include <cassert>
|
|
#include <future>
|
|
#include <string_view>
|
|
#include <utility>
|
|
|
|
#include "test_macros.h"
|
|
|
|
int main(int, char**) {
|
|
ASSERT_NOEXCEPT(std::declval<std::future_error const&>().what());
|
|
ASSERT_SAME_TYPE(decltype(std::declval<std::future_error const&>().what()), char const*);
|
|
|
|
// Before C++17, we can't construct std::future_error directly in a standards-conforming way
|
|
#if TEST_STD_VER >= 17
|
|
{
|
|
std::future_error const f(std::future_errc::broken_promise);
|
|
char const* what = f.what();
|
|
LIBCPP_ASSERT(what == std::string_view{"The associated promise has been destructed prior "
|
|
"to the associated state becoming ready."});
|
|
}
|
|
{
|
|
std::future_error f(std::future_errc::future_already_retrieved);
|
|
char const* what = f.what();
|
|
LIBCPP_ASSERT(what == std::string_view{"The future has already been retrieved from "
|
|
"the promise or packaged_task."});
|
|
}
|
|
{
|
|
std::future_error f(std::future_errc::promise_already_satisfied);
|
|
char const* what = f.what();
|
|
LIBCPP_ASSERT(what == std::string_view{"The state of the promise has already been set."});
|
|
}
|
|
{
|
|
std::future_error f(std::future_errc::no_state);
|
|
char const* what = f.what();
|
|
LIBCPP_ASSERT(what == std::string_view{"Operation not permitted on an object without "
|
|
"an associated state."});
|
|
}
|
|
#endif
|
|
|
|
return 0;
|
|
}
|