To consolidate behavior of function mangling and limit the number of places that ABI changes will need to be made, this switches the DirectX target used for HLSL to use the Itanium ABI from the Microsoft ABI. The Itanium ABI has greater flexibility in decisions regarding mangling of new types of which we have more than a few yet to add. One effect of this will be that linking library shaders compiled with DXC will not be possible with shaders compiled with clang. That isn't considered a terribly interesting use case and one that would likely have been onerous to maintain anyway. This involved adding a function to call all global destructors as the Microsoft ABI had done. This requires a few changes to tests. Most notably the mangling style has changed which accounts for most of the changes. In making those changes, I took the opportunity to harmonize some very similar tests for greater consistency. I also shaved off some unneeded run flags that had probably been copied over from one test to another. Other changes effected by using the new ABI include using different types when manipulating smaller bitfields, eliminating an unnecessary alloca in one instance in this-assignment.hlsl, changing the way static local initialization is guarded, and changing the order of inout parameters getting copied in and out. That last is a subtle change in functionality, but one where there was sufficient inconsistency in the past that standardizing is important, but the particular direction of the standardization is less important for the sake of existing shaders. fixes #110736
56 lines
2.5 KiB
HLSL
56 lines
2.5 KiB
HLSL
// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -emit-llvm -disable-llvm-passes -o - -std=hlsl202x %s | FileCheck %s
|
|
|
|
struct Pair {
|
|
int First;
|
|
int Second;
|
|
int getFirst() {
|
|
Pair Another = {5, 10};
|
|
this = Another;
|
|
return this.First;
|
|
}
|
|
int getSecond() {
|
|
this = Pair();
|
|
return Second;
|
|
}
|
|
void operator=(Pair P) {
|
|
First = P.First;
|
|
Second = 2;
|
|
}
|
|
};
|
|
[numthreads(1, 1, 1)]
|
|
void main() {
|
|
Pair Vals = {1, 2};
|
|
Vals.First = Vals.getFirst();
|
|
Vals.Second = Vals.getSecond();
|
|
}
|
|
|
|
// This test makes a probably safe assumption that HLSL 202x includes operator overloading for assignment operators.
|
|
// CHECK: define linkonce_odr noundef i32 @_ZN4Pair8getFirstEv(ptr noundef nonnull align 4 dereferenceable(8) %this) #0 align 2 {
|
|
// CHECK-NEXT:entry:
|
|
// CHECK-NEXT:%this.addr = alloca ptr, align 4
|
|
// CHECK-NEXT:%Another = alloca %struct.Pair, align 4
|
|
// CHECK-NEXT:%agg.tmp = alloca %struct.Pair, align 4
|
|
// CHECK-NEXT:store ptr %this, ptr %this.addr, align 4
|
|
// CHECK-NEXT:%this1 = load ptr, ptr %this.addr, align 4
|
|
// CHECK-NEXT:%First = getelementptr inbounds nuw %struct.Pair, ptr %Another, i32 0, i32 0
|
|
// CHECK-NEXT:store i32 5, ptr %First, align 4
|
|
// CHECK-NEXT:%Second = getelementptr inbounds nuw %struct.Pair, ptr %Another, i32 0, i32 1
|
|
// CHECK-NEXT:store i32 10, ptr %Second, align 4
|
|
// CHECK-NEXT:call void @llvm.memcpy.p0.p0.i32(ptr align 4 %agg.tmp, ptr align 4 %Another, i32 8, i1 false)
|
|
// CHECK-NEXT:call void @_ZN4PairaSES_(ptr noundef nonnull align 4 dereferenceable(8) %this1, ptr noundef byval(%struct.Pair) align 4 %agg.tmp)
|
|
// CHECK-NEXT:%First2 = getelementptr inbounds nuw %struct.Pair, ptr %this1, i32 0, i32 0
|
|
// CHECK-NEXT:%0 = load i32, ptr %First2, align 4
|
|
// CHECK-NEXT:ret i32 %0
|
|
|
|
// CHECK: define linkonce_odr noundef i32 @_ZN4Pair9getSecondEv(ptr noundef nonnull align 4 dereferenceable(8) %this) #0 align 2 {
|
|
// CHECK-NEXT:entry:
|
|
// CHECK-NEXT:%this.addr = alloca ptr, align 4
|
|
// CHECK-NEXT:%agg.tmp = alloca %struct.Pair, align 4
|
|
// CHECK-NEXT:store ptr %this, ptr %this.addr, align 4
|
|
// CHECK-NEXT:%this1 = load ptr, ptr %this.addr, align 4
|
|
// CHECK-NEXT:call void @llvm.memset.p0.i32(ptr align 4 %agg.tmp, i8 0, i32 8, i1 false)
|
|
// CHECK-NEXT:call void @_ZN4PairaSES_(ptr noundef nonnull align 4 dereferenceable(8) %this1, ptr noundef byval(%struct.Pair) align 4 %agg.tmp)
|
|
// CHECK-NEXT:%Second = getelementptr inbounds nuw %struct.Pair, ptr %this1, i32 0, i32 1
|
|
// CHECK-NEXT:%0 = load i32, ptr %Second, align 4
|
|
// CHECK-NEXT:ret i32 %0
|