6e6d5eae76
Some gdb remote serial protocol stubs will send the thread IDs and PCs for all threads in a process in the stop-reply packet. lldb often needs to know the pc values for all threads while at a private stop, and that results in <n-1> read-register packets for <n> threads, and can be a big performance problem when this is a hot code path. GDBRemoteRegisterContext tracks the StopID of when its values were set, and when the thread's StopID has incremented, it marks all values it has as Invalid, and knows to refetch them. We have a code path that resulted in setting the PCs for all the threads, and then `ProcessGDBRemote::CalculateThreadStopInfo` *forcing* an invalidation of all the register contexts, forcing us to re-read the pc values for all threads except the one that stopped. There are times when it is valid to force an invalidation of the regsiter cache - for instance, if the layout of the registers has changed because the processor state is different, or we've sent a write-all-registers packet to the inferior and we want to make sure we stay in sync with the inferior. But there was no reason for this method to be forcing the register context to be invalid. I added a test when running on Darwin systems, where debugserver always sends the thread IDs and PCs, which turns on packet logging. The test runs against an inferior which has 4 threads; it steps over a dlopen() call, steps in to a user function with debug info, steps-over and steps-in across source lines with multiple function calls, and then examines the packet log and flags it as an error if lldb asked for the pc value of any thread at any point in the debug session. For this program and the operations we're doing, with debugserver that provides thread IDs and PCs, we should never ask for the value of a pc register. rdar://136247381
63 lines
1.1 KiB
C++
63 lines
1.1 KiB
C++
#include <dlfcn.h>
|
|
#include <stdio.h>
|
|
#include <thread>
|
|
#include <unistd.h>
|
|
|
|
void f1() {
|
|
while (1)
|
|
sleep(1);
|
|
}
|
|
void f2() {
|
|
while (1)
|
|
sleep(1);
|
|
}
|
|
void f3() {
|
|
while (1)
|
|
sleep(1);
|
|
}
|
|
|
|
int main() {
|
|
std::thread t1{f1};
|
|
std::thread t2{f2};
|
|
std::thread t3{f3};
|
|
|
|
puts("break here");
|
|
|
|
void *handle = dlopen("libfoo.dylib", RTLD_LAZY);
|
|
int (*foo_ptr)() = (int (*)())dlsym(handle, "foo");
|
|
int c = foo_ptr();
|
|
|
|
// clang-format off
|
|
// multiple function calls on a single source line so 'step'
|
|
// and 'next' need to do multiple steps of work.
|
|
puts("1"); puts("2"); puts("3"); puts("4"); puts("5");
|
|
puts("6"); puts("7"); puts("8"); puts("9"); puts("10");
|
|
puts("11"); puts("12"); puts("13"); puts("14"); puts("15");
|
|
puts("16"); puts("17"); puts("18"); puts("19"); puts("20");
|
|
puts("21"); puts("22"); puts("23"); puts("24"); puts("24");
|
|
// clang-format on
|
|
puts("one");
|
|
puts("two");
|
|
puts("three");
|
|
puts("four");
|
|
puts("five");
|
|
puts("six");
|
|
puts("seven");
|
|
puts("eight");
|
|
puts("nine");
|
|
puts("ten");
|
|
c++;
|
|
c++;
|
|
c++;
|
|
c++;
|
|
c++;
|
|
c++;
|
|
c++;
|
|
c++;
|
|
c++;
|
|
c++;
|
|
c++;
|
|
c++;
|
|
return c;
|
|
}
|