43222bd309
This pull request aims to remove any dependency on OpenCL/SPIR-V type information in LLVM IR metadata. While, using metadata might simplify and prettify the resulting SPIR-V output (and restore some of the information missed in the transformation to opaque pointers), the overall methodology for resolving kernel parameter types is highly inefficient. The high-level strategy is to assign kernel parameter types in this order: 1. Resolving the types using builtin function calls as mangled names must contain type information or by looking up builtin definition in SPIRVBuiltins.td. Then: - Assigning the type temporarily using an intrinsic and later setting the right SPIR-V type in SPIRVGlobalRegistry after IRTranslation - Inserting a bitcast 2. Defaulting to LLVM IR types (in case of pointers the generic i8* type or types from byval/byref attributes) In case of type incompatibility (e.g. parameter defined initially as sampler_t and later used as image_t) the error will be found early on before IRTranslation (in the SPIRVEmitIntrinsics pass).
24 lines
1.1 KiB
LLVM
24 lines
1.1 KiB
LLVM
; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
|
|
; This test only intends to check the vstoren builtin name resolution.
|
|
; The calls to the OpenCL builtins are not valid and will not pass SPIR-V validation.
|
|
|
|
; CHECK-DAG: %[[#IMPORT:]] = OpExtInstImport "OpenCL.std"
|
|
|
|
; CHECK-DAG: %[[#VOID:]] = OpTypeVoid
|
|
; CHECK-DAG: %[[#INT8:]] = OpTypeInt 8 0
|
|
; CHECK-DAG: %[[#INT64:]] = OpTypeInt 64 0
|
|
; CHECK-DAG: %[[#VINT8:]] = OpTypeVector %[[#INT8]] 2
|
|
; CHECK-DAG: %[[#PTRINT8:]] = OpTypePointer CrossWorkgroup %[[#INT8]]
|
|
|
|
; CHECK: %[[#DATA:]] = OpFunctionParameter %[[#VINT8]]
|
|
; CHECK: %[[#OFFSET:]] = OpFunctionParameter %[[#INT64]]
|
|
; CHECK: %[[#ADDRESS:]] = OpFunctionParameter %[[#PTRINT8]]
|
|
|
|
define spir_kernel void @test_fn(<2 x i8> %data, i64 %offset, ptr addrspace(1) %address) {
|
|
; CHECK: %[[#]] = OpExtInst %[[#VOID]] %[[#IMPORT]] vstoren %[[#DATA]] %[[#OFFSET]] %[[#ADDRESS]]
|
|
call spir_func void @_Z7vstore2Dv2_cmPU3AS1c(<2 x i8> %data, i64 %offset, ptr addrspace(1) %address)
|
|
ret void
|
|
}
|
|
|
|
declare spir_func void @_Z7vstore2Dv2_cmPU3AS1c(<2 x i8>, i64, ptr addrspace(1))
|