1ed65febd9
This commit adds an initial SPIR-V structurizer. It leverages the previously merged passes, and the convergence region analysis to determine the correct merge and continue blocks for SPIR-V. The first part does a branch cleanup (simplifying switches, and legalizing them), then merge instructions are added to cycles, convergent and later divergent blocks. Then comes the important part: splitting critical edges, and making sure the divergent construct boundaries don't cross. - we split blocks with multiple headers into 2 blocks. - we split blocks that are a merge blocks for 2 or more constructs: SPIR-V spec disallow a merge block to be shared by 2 loop/switch/condition construct. - we split merge & continue blocks: SPIR-V spec disallow a basic block to be both a continue block, and a merge block. - we remove superfluous headers: when a header doesn't bring more info than the parent on the divergence state, it must be removed. This PR leverages the merged SPIR-V simulator for testing, as long as spirv-val. For now, most DXC structurization tests are passing. The unsupported ones are either caused by unsupported features like switches on boolean types, or switches in region exits, because the MergeExit pass doesn't support those yet (there is a FIXME). This PR is quite large, and the addition not trivial, so I tried to keep it simple. E.G: as soon as the CFG changes, I recompute the dominator trees and other structures instead of updating them. --------- Signed-off-by: Nathan Gauër <brioche@google.com>
115 lines
3.4 KiB
LLVM
115 lines
3.4 KiB
LLVM
; The goal of the test is to check that newly inserted `ptrcast` internal
|
|
; intrinsic functions for PHI's operands are inserted at the correct
|
|
; positions, and don't break rules of instruction domination and PHI nodes
|
|
; grouping at top of basic block.
|
|
|
|
; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
|
|
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown %s -o - -filetype=obj | spirv-val %}
|
|
|
|
|
|
; CHECK-DAG: OpName %[[#Case1:]] "case1"
|
|
; CHECK-DAG: OpName %[[#Case2:]] "case2"
|
|
; CHECK-DAG: OpName %[[#Case3:]] "case3"
|
|
|
|
%struct1 = type { i64 }
|
|
%struct2 = type { i64, i64 }
|
|
|
|
@.str.1 = private unnamed_addr addrspace(1) constant [3 x i8] c"OK\00", align 1
|
|
@.str.2 = private unnamed_addr addrspace(1) constant [6 x i8] c"WRONG\00", align 1
|
|
|
|
; CHECK: %[[#Case1]] = OpFunction
|
|
define spir_func void @case1(i1 %b1, i1 %b2, i1 %b3) {
|
|
entry:
|
|
; CHECK: OpBranchConditional %[[#]] %[[#l1:]] %[[#l2:]]
|
|
br i1 %b1, label %l1, label %l2
|
|
|
|
l1:
|
|
%str = phi ptr addrspace(1) [ @.str.1, %entry ], [ @.str.2, %l2 ], [ @.str.2, %l3 ]
|
|
br label %exit
|
|
|
|
; CHECK: %[[#l2]] = OpLabel
|
|
; CHECK: OpBranchConditional %[[#]] %[[#l1]] %[[#l3:]]
|
|
l2:
|
|
br i1 %b2, label %l1, label %l3
|
|
|
|
; CHECK: %[[#l3]] = OpLabel
|
|
; CHECK: OpBranchConditional %[[#]] %[[#l1]] %[[#exit:]]
|
|
l3:
|
|
br i1 %b3, label %l1, label %exit
|
|
|
|
; CHECK: %[[#l1]] = OpLabel
|
|
; CHECK-NEXT: OpPhi
|
|
; CHECK: OpBranch %[[#exit]]
|
|
|
|
; CHECK: %[[#exit]] = OpLabel
|
|
; CHECK: OpReturn
|
|
exit:
|
|
ret void
|
|
|
|
}
|
|
|
|
; CHECK: %[[#Case2]] = OpFunction
|
|
define spir_func void @case2(i1 %b1, i1 %b2, i1 %b3, ptr addrspace(1) byval(%struct1) %str1, ptr addrspace(1) byval(%struct2) %str2) {
|
|
entry:
|
|
; CHECK: OpBranchConditional %[[#]] %[[#l1:]] %[[#l2:]]
|
|
br i1 %b1, label %l1, label %l2
|
|
|
|
l1:
|
|
%str = phi ptr addrspace(1) [ %str1, %entry ], [ %str2, %l2 ], [ %str2, %l3 ]
|
|
br label %exit
|
|
|
|
; CHECK: %[[#l2]] = OpLabel
|
|
; CHECK: OpBranchConditional %[[#]] %[[#l1]] %[[#l3:]]
|
|
l2:
|
|
br i1 %b2, label %l1, label %l3
|
|
|
|
; CHECK: %[[#l3]] = OpLabel
|
|
; CHECK: OpBranchConditional %[[#]] %[[#l1]] %[[#exit:]]
|
|
l3:
|
|
br i1 %b3, label %l1, label %exit
|
|
|
|
; CHECK: %[[#l1]] = OpLabel
|
|
; CHECK-NEXT: OpPhi
|
|
; CHECK: OpBranch %[[#exit]]
|
|
|
|
; CHECK: %[[#exit]] = OpLabel
|
|
; CHECK: OpReturn
|
|
exit:
|
|
ret void
|
|
}
|
|
|
|
; CHECK: %[[#Case3]] = OpFunction
|
|
define spir_func void @case3(i1 %b1, i1 %b2, i1 %b3, ptr addrspace(1) byval(%struct1) %_arg_str1, ptr addrspace(1) byval(%struct2) %_arg_str2) {
|
|
|
|
; CHECK: OpBranchConditional %[[#]] %[[#l1:]] %[[#l2:]]
|
|
entry:
|
|
br i1 %b1, label %l1, label %l2
|
|
|
|
l1:
|
|
%str = phi ptr addrspace(1) [ %_arg_str1, %entry ], [ %str2, %l2 ], [ %str3, %l3 ]
|
|
br label %exit
|
|
|
|
; CHECK: %[[#l2]] = OpLabel
|
|
; CHECK: OpInBoundsPtrAccessChain
|
|
; CHECK: OpBranchConditional %[[#]] %[[#l1]] %[[#l3:]]
|
|
l2:
|
|
%str2 = getelementptr inbounds %struct2, ptr addrspace(1) %_arg_str2, i32 1
|
|
br i1 %b2, label %l1, label %l3
|
|
|
|
; CHECK: %[[#l3]] = OpLabel
|
|
; CHECK: OpInBoundsPtrAccessChain
|
|
; CHECK: OpBranchConditional %[[#]] %[[#l1]] %[[#exit:]]
|
|
l3:
|
|
%str3 = getelementptr inbounds %struct2, ptr addrspace(1) %_arg_str2, i32 2
|
|
br i1 %b3, label %l1, label %exit
|
|
|
|
; CHECK: %[[#l1]] = OpLabel
|
|
; CHECK-NEXT: OpPhi
|
|
; CHECK: OpBranch %[[#exit]]
|
|
|
|
; CHECK: %[[#exit]] = OpLabel
|
|
; CHECK: OpReturn
|
|
exit:
|
|
ret void
|
|
}
|