b3a0c4d7dc
Summary:
The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue.
This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals.
This patch was mostly written by a shell script with some manual verification afterwards:
```
lang=python
import sys
def sanitize_line(line):
if line.strip().startswith("self.assertTrue(") and " == " in line:
line = line.replace("self.assertTrue(", "self.assertEquals(")
line = line.replace(" == ", ", ", 1)
if line.strip().startswith("self.assertTrue(") and " != " in line:
line = line.replace("self.assertTrue(", "self.assertNotEqual(")
line = line.replace(" != ", ", ", 1)
return line
for a in sys.argv[1:]:
with open(a, "r") as f:
lines = f.readlines()
with open(a, "w") as f:
for line in lines:
f.write(sanitize_line(line))
```
Reviewers: labath, JDevlieghere
Reviewed By: labath
Subscribers: abidh, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74475
87 lines
3.0 KiB
Python
87 lines
3.0 KiB
Python
"""
|
|
Test that you can set breakpoint and hit the C++ language exception breakpoint
|
|
"""
|
|
|
|
|
|
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class TestCPPExceptionBreakpoint (TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
my_var = 10
|
|
|
|
@add_test_categories(['pyapi'])
|
|
@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24538")
|
|
@expectedFailureNetBSD
|
|
def test_cpp_exception_breakpoint(self):
|
|
"""Test setting and hitting the C++ exception breakpoint."""
|
|
self.build()
|
|
self.do_cpp_exception_bkpt()
|
|
|
|
@add_test_categories(['pyapi'])
|
|
@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24538")
|
|
@expectedFailureNetBSD
|
|
def test_dummy_target_cpp_exception_breakpoint(self):
|
|
"""Test setting and hitting the C++ exception breakpoint from dummy target."""
|
|
self.build()
|
|
self.do_dummy_target_cpp_exception_bkpt()
|
|
|
|
def setUp(self):
|
|
TestBase.setUp(self)
|
|
self.main_source = "main.c"
|
|
self.main_source_spec = lldb.SBFileSpec(self.main_source)
|
|
|
|
def do_cpp_exception_bkpt(self):
|
|
exe = self.getBuildArtifact("a.out")
|
|
error = lldb.SBError()
|
|
|
|
self.target = self.dbg.CreateTarget(exe)
|
|
self.assertTrue(self.target, VALID_TARGET)
|
|
|
|
exception_bkpt = self.target.BreakpointCreateForException(
|
|
lldb.eLanguageTypeC_plus_plus, False, True)
|
|
self.assertTrue(
|
|
exception_bkpt.IsValid(),
|
|
"Created exception breakpoint.")
|
|
|
|
process = self.target.LaunchSimple(
|
|
None, None, self.get_process_working_directory())
|
|
self.assertTrue(process, PROCESS_IS_VALID)
|
|
|
|
thread_list = lldbutil.get_threads_stopped_at_breakpoint(
|
|
process, exception_bkpt)
|
|
self.assertEquals(len(thread_list), 1,
|
|
"One thread stopped at the exception breakpoint.")
|
|
|
|
def do_dummy_target_cpp_exception_bkpt(self):
|
|
exe = self.getBuildArtifact("a.out")
|
|
error = lldb.SBError()
|
|
|
|
dummy_exception_bkpt = self.dbg.GetDummyTarget().BreakpointCreateForException(
|
|
lldb.eLanguageTypeC_plus_plus, False, True)
|
|
self.assertTrue(
|
|
dummy_exception_bkpt.IsValid(),
|
|
"Created exception breakpoint in dummy target.")
|
|
|
|
self.target = self.dbg.CreateTarget(exe)
|
|
self.assertTrue(self.target, VALID_TARGET)
|
|
|
|
exception_bkpt = self.target.GetBreakpointAtIndex(0)
|
|
self.assertTrue(
|
|
exception_bkpt.IsValid(),
|
|
"Target primed with exception breakpoint from dummy target.")
|
|
|
|
process = self.target.LaunchSimple(
|
|
None, None, self.get_process_working_directory())
|
|
self.assertTrue(process, PROCESS_IS_VALID)
|
|
|
|
thread_list = lldbutil.get_threads_stopped_at_breakpoint(
|
|
process, exception_bkpt)
|
|
self.assertEquals(len(thread_list), 1,
|
|
"One thread stopped at the exception breakpoint.")
|