A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
80 lines
2.7 KiB
C++
80 lines
2.7 KiB
C++
//===-- CommandObjectScript.cpp ---------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "CommandObjectScript.h"
|
|
|
|
|
|
#include "lldb/Core/Debugger.h"
|
|
|
|
#include "lldb/DataFormatters/DataVisualization.h"
|
|
|
|
#include "lldb/Interpreter/CommandInterpreter.h"
|
|
#include "lldb/Interpreter/CommandReturnObject.h"
|
|
#include "lldb/Interpreter/ScriptInterpreter.h"
|
|
#include "lldb/Utility/Args.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
// CommandObjectScript
|
|
|
|
CommandObjectScript::CommandObjectScript(CommandInterpreter &interpreter,
|
|
ScriptLanguage script_lang)
|
|
: CommandObjectRaw(
|
|
interpreter, "script",
|
|
"Invoke the script interpreter with provided code and display any "
|
|
"results. Start the interactive interpreter if no code is supplied.",
|
|
"script [<script-code>]") {}
|
|
|
|
CommandObjectScript::~CommandObjectScript() {}
|
|
|
|
bool CommandObjectScript::DoExecute(llvm::StringRef command,
|
|
CommandReturnObject &result) {
|
|
#ifdef LLDB_DISABLE_PYTHON
|
|
// if we ever support languages other than Python this simple #ifdef won't
|
|
// work
|
|
result.AppendError("your copy of LLDB does not support scripting.");
|
|
result.SetStatus(eReturnStatusFailed);
|
|
return false;
|
|
#else
|
|
if (m_interpreter.GetDebugger().GetScriptLanguage() ==
|
|
lldb::eScriptLanguageNone) {
|
|
result.AppendError(
|
|
"the script-lang setting is set to none - scripting not available");
|
|
result.SetStatus(eReturnStatusFailed);
|
|
return false;
|
|
}
|
|
|
|
ScriptInterpreter *script_interpreter = m_interpreter.GetScriptInterpreter();
|
|
|
|
if (script_interpreter == nullptr) {
|
|
result.AppendError("no script interpreter");
|
|
result.SetStatus(eReturnStatusFailed);
|
|
return false;
|
|
}
|
|
|
|
DataVisualization::ForceUpdate(); // script might change Python code we use
|
|
// for formatting.. make sure we keep up to
|
|
// date with it
|
|
|
|
if (command.empty()) {
|
|
script_interpreter->ExecuteInterpreterLoop();
|
|
result.SetStatus(eReturnStatusSuccessFinishNoResult);
|
|
return result.Succeeded();
|
|
}
|
|
|
|
// We can do better when reporting the status of one-liner script execution.
|
|
if (script_interpreter->ExecuteOneLine(command, &result))
|
|
result.SetStatus(eReturnStatusSuccessFinishNoResult);
|
|
else
|
|
result.SetStatus(eReturnStatusFailed);
|
|
|
|
return result.Succeeded();
|
|
#endif
|
|
}
|