The 'loop' construct has some pretty strict checks as to what the for loop associated with it has to look like. The previous implementation was a little convoluted and missed implementing the 'condition' checking. Additionally, it did a bad job double-diagnosing with templates. This patch rewrites it in a way that does a much better job with the double-diagnosing, and proeprly implements some checks for the 'condition' of the for loop.
393 lines
16 KiB
C++
393 lines
16 KiB
C++
// RUN: %clang_cc1 %s -fopenacc -verify -Wno-empty-body -Wno-unused-value
|
|
namespace std {
|
|
struct random_access_iterator_tag{};
|
|
}
|
|
|
|
struct SomeStruct{
|
|
void operator++();
|
|
void operator++(int);
|
|
};
|
|
|
|
struct SomeIterator {
|
|
bool operator!=(SomeIterator&);
|
|
void operator++();
|
|
void operator++(int);
|
|
int operator*();
|
|
};
|
|
|
|
struct SomeRAIterator {
|
|
using iterator_category = std::random_access_iterator_tag;
|
|
SomeRAIterator();
|
|
SomeRAIterator(int i);
|
|
|
|
void operator=(int i);
|
|
SomeRAIterator &operator=(SomeRAIterator&);
|
|
|
|
void operator++(int);
|
|
void operator++();
|
|
int operator*();
|
|
void operator+=(int);
|
|
bool operator!=(SomeRAIterator&);
|
|
};
|
|
|
|
struct HasIteratorCollection {
|
|
SomeIterator &begin();
|
|
SomeIterator &end();
|
|
};
|
|
|
|
struct HasRAIteratorCollection {
|
|
SomeRAIterator &begin();
|
|
SomeRAIterator &end();
|
|
};
|
|
|
|
void func_call();
|
|
|
|
template<typename Int, typename IntPtr, typename Float, typename Struct, typename Iterator, typename RandAccessIterator>
|
|
void SeqLoopRules() {
|
|
|
|
// expected-error@+3{{OpenACC 'parallel loop' construct can only be applied to a 'for' loop}}
|
|
// expected-note@+1{{'parallel loop' construct is here}}
|
|
#pragma acc parallel loop seq
|
|
while(true);
|
|
|
|
// No rules in this section!
|
|
#pragma acc kernels loop seq
|
|
for(;;);
|
|
|
|
#pragma acc parallel loop seq
|
|
for(float f = 0;;);
|
|
|
|
#pragma acc serial loop seq
|
|
for(int f;;);
|
|
|
|
#pragma acc kernels loop seq
|
|
for(int f,g;;);
|
|
|
|
#pragma acc parallel loop seq
|
|
for(Int f;;++f);
|
|
|
|
#pragma acc serial loop seq
|
|
for(Int *f = nullptr;;++f);
|
|
|
|
#pragma acc kernels loop seq
|
|
for(IntPtr f = nullptr;;++f);
|
|
|
|
#pragma acc parallel loop seq
|
|
for(Float *f = nullptr;;++f);
|
|
|
|
#pragma acc serial loop seq
|
|
for(SomeStruct f;;);
|
|
|
|
#pragma acc kernels loop seq
|
|
for(Struct f;;++f);
|
|
|
|
#pragma acc parallel loop seq
|
|
for(SomeIterator f;;++f);
|
|
|
|
#pragma acc serial loop seq
|
|
for(Iterator f;;++f);
|
|
|
|
#pragma acc kernels loop seq
|
|
for(SomeRAIterator f;;++f);
|
|
|
|
#pragma acc parallel loop seq
|
|
for(RandAccessIterator f;;++f);
|
|
|
|
#pragma acc kernels loop seq
|
|
for(Int f;;);
|
|
|
|
#pragma acc parallel loop seq
|
|
for(Int f;;++f);
|
|
|
|
#pragma acc serial loop seq
|
|
for(Int f;;f+=1);
|
|
|
|
int i;
|
|
#pragma acc kernels loop seq
|
|
for(Int f;;i+=1);
|
|
|
|
#pragma acc parallel loop seq
|
|
for(Int f;;i++);
|
|
|
|
#pragma acc serial loop seq
|
|
for(RandAccessIterator f;;i++);
|
|
|
|
#pragma acc kernels loop seq
|
|
for(RandAccessIterator f;;func_call());
|
|
|
|
Int Array[5];
|
|
#pragma acc parallel loop seq
|
|
for(auto X : Array);
|
|
|
|
#pragma acc serial loop seq
|
|
for(auto X : HasIteratorCollection{});
|
|
|
|
#pragma acc kernels loop seq
|
|
for(auto X : HasRAIteratorCollection{});
|
|
|
|
RandAccessIterator f, end;
|
|
#pragma acc parallel loop seq
|
|
for(f;f != end;f++);
|
|
|
|
#pragma acc kernels loop seq
|
|
for(f = 0;;++f);
|
|
|
|
#pragma acc parallel loop seq
|
|
for(f = 0;;f++);
|
|
|
|
#pragma acc serial loop seq
|
|
for(f = 0;;f+=1);
|
|
}
|
|
|
|
|
|
template<typename Int, typename IntPtr, typename Float, typename Struct, typename Iterator, typename RandAccessIterator>
|
|
void LoopRules() {
|
|
// expected-error@+3{{OpenACC 'parallel loop' construct can only be applied to a 'for' loop}}
|
|
// expected-note@+1{{'parallel loop' construct is here}}
|
|
#pragma acc parallel loop
|
|
while(true);
|
|
|
|
// Loop variable must be integer, pointer, or random_access_iterator
|
|
#pragma acc kernels loop
|
|
// expected-error@+6{{OpenACC 'kernels loop' construct must have initialization clause in canonical form ('var = init' or 'T var = init'}}
|
|
// expected-note@-2{{'kernels loop' construct is here}}
|
|
// expected-error@+4{{OpenACC 'kernels loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'kernels loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'kernels loop' variable must monotonically increase or decrease ('++', '--', or compound assignment)}}
|
|
// expected-note@-6{{'kernels loop' construct is here}}
|
|
for(;;);
|
|
|
|
#pragma acc parallel loop
|
|
// expected-error@+6{{loop variable of loop associated with an OpenACC 'parallel loop' construct must be of integer, pointer, or random-access-iterator type (is 'float')}}
|
|
// expected-note@-2{{'parallel loop' construct is here}}
|
|
// expected-error@+4{{OpenACC 'parallel loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'parallel loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'parallel loop' variable must monotonically increase or decrease ('++', '--', or compound assignment)}}
|
|
// expected-note@-6{{'parallel loop' construct is here}}
|
|
for(float f = 0;;);
|
|
|
|
#pragma acc serial loop
|
|
// expected-error@+6{{OpenACC 'serial loop' construct must have initialization clause in canonical form ('var = init' or 'T var = init'}}
|
|
// expected-note@-2{{'serial loop' construct is here}}
|
|
// expected-error@+4{{OpenACC 'serial loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'serial loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'serial loop' variable must monotonically increase or decrease ('++', '--', or compound assignment)}}
|
|
// expected-note@-6{{'serial loop' construct is here}}
|
|
for(int f;;);
|
|
|
|
#pragma acc kernels loop
|
|
// expected-error@+6{{OpenACC 'kernels loop' construct must have initialization clause in canonical form ('var = init' or 'T var = init'}}
|
|
// expected-note@-2{{'kernels loop' construct is here}}
|
|
// expected-error@+4{{OpenACC 'kernels loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'kernels loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'kernels loop' variable must monotonically increase or decrease ('++', '--', or compound assignment)}}
|
|
// expected-note@-6{{'kernels loop' construct is here}}
|
|
for(int f,g;;);
|
|
|
|
#pragma acc parallel loop
|
|
// expected-error@+4{{OpenACC 'parallel loop' construct must have initialization clause in canonical form ('var = init' or 'T var = init'}}
|
|
// expected-note@-2{{'parallel loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'parallel loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'parallel loop' construct is here}}
|
|
for(Int f;;++f);
|
|
|
|
#pragma acc serial loop
|
|
// expected-error@+2{{OpenACC 'serial loop' construct must have a terminating condition}}
|
|
// expected-note@-2{{'serial loop' construct is here}}
|
|
for(Int *f = nullptr;;++f);
|
|
|
|
#pragma acc kernels loop
|
|
// expected-error@+2{{OpenACC 'kernels loop' construct must have a terminating condition}}
|
|
// expected-note@-2{{'kernels loop' construct is here}}
|
|
for(IntPtr f = nullptr;;++f);
|
|
|
|
#pragma acc parallel loop
|
|
// expected-error@+2{{OpenACC 'parallel loop' construct must have a terminating condition}}
|
|
// expected-note@-2{{'parallel loop' construct is here}}
|
|
for(Float *f = nullptr;;++f);
|
|
|
|
#pragma acc serial loop
|
|
// expected-error@+6{{loop variable of loop associated with an OpenACC 'serial loop' construct must be of integer, pointer, or random-access-iterator type (is 'SomeStruct')}}
|
|
// expected-note@-2{{'serial loop' construct is here}}
|
|
// expected-error@+4{{OpenACC 'serial loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'serial loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'serial loop' variable must monotonically increase or decrease ('++', '--', or compound assignment)}}
|
|
// expected-note@-6{{'serial loop' construct is here}}
|
|
for(SomeStruct f;;);
|
|
|
|
#pragma acc kernels loop
|
|
// expected-error@+4{{loop variable of loop associated with an OpenACC 'kernels loop' construct must be of integer, pointer, or random-access-iterator type (is 'SomeStruct')}}
|
|
// expected-note@-2{{'kernels loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'kernels loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'kernels loop' construct is here}}
|
|
for(Struct f;;++f);
|
|
|
|
#pragma acc parallel loop
|
|
// expected-error@+4{{loop variable of loop associated with an OpenACC 'parallel loop' construct must be of integer, pointer, or random-access-iterator type (is 'SomeIterator')}}
|
|
// expected-note@-2{{'parallel loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'parallel loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'parallel loop' construct is here}}
|
|
for(SomeIterator f;;++f);
|
|
|
|
#pragma acc serial loop
|
|
// expected-error@+4{{loop variable of loop associated with an OpenACC 'serial loop' construct must be of integer, pointer, or random-access-iterator type (is 'SomeIterator')}}
|
|
// expected-note@-2{{'serial loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'serial loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'serial loop' construct is here}}
|
|
for(Iterator f;;++f);
|
|
|
|
#pragma acc kernels loop
|
|
// expected-error@+2{{OpenACC 'kernels loop' construct must have a terminating condition}}
|
|
// expected-note@-2{{'kernels loop' construct is here}}
|
|
for(SomeRAIterator f;;++f);
|
|
|
|
#pragma acc parallel loop
|
|
// expected-error@+2{{OpenACC 'parallel loop' construct must have a terminating condition}}
|
|
// expected-note@-2{{'parallel loop' construct is here}}
|
|
for(RandAccessIterator f;;++f);
|
|
|
|
Int i;
|
|
#pragma acc serial loop
|
|
// expected-error@+4{{OpenACC 'serial loop' construct must have a terminating condition}}
|
|
// expected-note@-2{{'serial loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'serial loop' variable must monotonically increase or decrease ('++', '--', or compound assignment)}}
|
|
// expected-note@-4{{'serial loop' construct is here}}
|
|
for( i = 0;;);
|
|
|
|
#pragma acc kernels loop
|
|
// expected-error@+6{{OpenACC 'kernels loop' construct must have initialization clause in canonical form ('var = init' or 'T var = init'}}
|
|
// expected-note@-2{{'kernels loop' construct is here}}
|
|
// expected-error@+4{{OpenACC 'kernels loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'kernels loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'kernels loop' variable must monotonically increase or decrease ('++', '--', or compound assignment)}}
|
|
// expected-note@-6{{'kernels loop' construct is here}}
|
|
for( i;;);
|
|
|
|
#pragma acc parallel loop
|
|
// expected-error@+6{{OpenACC 'parallel loop' construct must have initialization clause in canonical form ('var = init' or 'T var = init'}}
|
|
// expected-note@-2{{'parallel loop' construct is here}}
|
|
// expected-error@+4{{OpenACC 'parallel loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'parallel loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'parallel loop' variable must monotonically increase or decrease ('++', '--', or compound assignment)}}
|
|
// expected-note@-6{{'parallel loop' construct is here}}
|
|
for( int j ;;);
|
|
|
|
#pragma acc serial loop
|
|
// expected-error@+6{{OpenACC 'serial loop' construct must have initialization clause in canonical form ('var = init' or 'T var = init'}}
|
|
// expected-note@-2{{'serial loop' construct is here}}
|
|
// expected-error@+4{{OpenACC 'serial loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'serial loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'serial loop' variable must monotonically increase or decrease ('++', '--', or compound assignment)}}
|
|
// expected-note@-6{{'serial loop' construct is here}}
|
|
for( int j, k = 0;;);
|
|
|
|
#pragma acc kernels loop
|
|
// expected-error@+6{{OpenACC 'kernels loop' construct must have initialization clause in canonical form ('var = init' or 'T var = init'}}
|
|
// expected-note@-2{{'kernels loop' construct is here}}
|
|
// expected-error@+4{{OpenACC 'kernels loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'kernels loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'kernels loop' variable must monotonically increase or decrease ('++', '--', or compound assignment)}}
|
|
// expected-note@-6{{'kernels loop' construct is here}}
|
|
for(Int f;;);
|
|
|
|
#pragma acc parallel loop
|
|
// expected-error@+4{{OpenACC 'parallel loop' construct must have initialization clause in canonical form ('var = init' or 'T var = init'}}
|
|
// expected-note@-2{{'parallel loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'parallel loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'parallel loop' construct is here}}
|
|
for(Int f;;++f);
|
|
|
|
#pragma acc serial loop
|
|
// expected-error@+4{{OpenACC 'serial loop' construct must have initialization clause in canonical form ('var = init' or 'T var = init'}}
|
|
// expected-note@-2{{'serial loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'serial loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'serial loop' construct is here}}
|
|
for(Int f;;f+=1);
|
|
|
|
#pragma acc kernels loop
|
|
// expected-error@+6{{OpenACC 'kernels loop' construct must have initialization clause in canonical form ('var = init' or 'T var = init'}}
|
|
// expected-note@-2{{'kernels loop' construct is here}}
|
|
// expected-error@+4{{OpenACC 'kernels loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'kernels loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'kernels loop' variable must monotonically increase or decrease ('++', '--', or compound assignment)}}
|
|
// expected-note@-6{{'kernels loop' construct is here}}
|
|
for(Int f;;i+=1);
|
|
|
|
#pragma acc parallel loop
|
|
// expected-error@+6{{OpenACC 'parallel loop' construct must have initialization clause in canonical form ('var = init' or 'T var = init'}}
|
|
// expected-note@-2{{'parallel loop' construct is here}}
|
|
// expected-error@+4{{OpenACC 'parallel loop' construct must have a terminating condition}}
|
|
// expected-note@-4{{'parallel loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'parallel loop' variable must monotonically increase or decrease ('++', '--', or compound assignment)}}
|
|
// expected-note@-6{{'parallel loop' construct is here}}
|
|
for(Int f;;i++);
|
|
|
|
#pragma acc serial loop
|
|
// expected-error@+4{{OpenACC 'serial loop' construct must have a terminating condition}}
|
|
// expected-note@-2{{'serial loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'serial loop' variable must monotonically increase or decrease ('++', '--', or compound assignment)}}
|
|
// expected-note@-4{{'serial loop' construct is here}}
|
|
for(RandAccessIterator f;;i++);
|
|
|
|
#pragma acc kernels loop
|
|
// expected-error@+4{{OpenACC 'kernels loop' construct must have a terminating condition}}
|
|
// expected-note@-2{{'kernels loop' construct is here}}
|
|
// expected-error@+2{{OpenACC 'kernels loop' variable must monotonically increase or decrease ('++', '--', or compound assignment)}}
|
|
// expected-note@-4{{'kernels loop' construct is here}}
|
|
for(RandAccessIterator f;;func_call());
|
|
|
|
// Not much we can do here other than check for random access iterator.
|
|
Int Array[5];
|
|
#pragma acc parallel loop
|
|
for(auto X : Array);
|
|
|
|
#pragma acc kernels loop
|
|
// expected-error@+2{{loop variable of loop associated with an OpenACC 'kernels loop' construct must be of integer, pointer, or random-access-iterator type (is 'SomeIterator')}}
|
|
// expected-note@-2{{'kernels loop' construct is here}}
|
|
for(auto X : HasIteratorCollection{});
|
|
|
|
#pragma acc serial loop
|
|
for(auto X : HasRAIteratorCollection{});
|
|
|
|
RandAccessIterator end;
|
|
#pragma acc parallel loop
|
|
for(RandAccessIterator f = 0; f != end; ++f);
|
|
|
|
RandAccessIterator f;
|
|
#pragma acc serial loop
|
|
// expected-error@+2{{OpenACC 'serial loop' construct must have initialization clause in canonical form ('var = init' or 'T var = init'}}
|
|
// expected-note@-2{{'serial loop' construct is here}}
|
|
for(f;f != end;f++);
|
|
|
|
#pragma acc kernels loop
|
|
// expected-error@+2{{OpenACC 'kernels loop' construct must have a terminating condition}}
|
|
// expected-note@-2{{'kernels loop' construct is here}}
|
|
for(f = 0;;++f);
|
|
|
|
#pragma acc parallel loop
|
|
// expected-error@+2{{OpenACC 'parallel loop' construct must have a terminating condition}}
|
|
// expected-note@-2{{'parallel loop' construct is here}}
|
|
for(f = 0;;f++);
|
|
|
|
#pragma acc serial loop
|
|
// expected-error@+2{{OpenACC 'serial loop' construct must have a terminating condition}}
|
|
// expected-note@-2{{'serial loop' construct is here}}
|
|
for(f = 0;;f+=1);
|
|
|
|
#pragma acc kernels loop
|
|
for(f = 0;f != end;++f);
|
|
|
|
#pragma acc parallel loop
|
|
for(f = 0;f != end;f++);
|
|
|
|
#pragma acc parallel loop
|
|
for(f = 0;f != end;f+=1);
|
|
}
|
|
|
|
void inst() {
|
|
SeqLoopRules<int, int*, float, SomeStruct, SomeIterator, SomeRAIterator>();
|
|
// expected-note@+1{{in instantiation of function template specialization}}
|
|
LoopRules<int, int*, float, SomeStruct, SomeIterator, SomeRAIterator>();
|
|
}
|
|
|