dda42164ec
StaticAnalyzer uses the CFG-based RelaxedLiveVariables analysis in order to,
in particular, figure out values of which expressions are still needed.
When the expression becomes "dead", it is garbage-collected during
the dead binding scan.
Expressions that constitute branches/bodies of control flow statements,
eg. `E1' in `if (C1) E1;' but not `E2' in `if (C2) { E2; }', were kept alive
for too long. This caused false positives in MoveChecker because it relies
on cleaning up loop-local variables when they go out of scope, but some of those
live-for-too-long expressions were keeping a reference to those variables.
Fix liveness analysis to correctly mark these expressions as dead.
Add a debug checker, debug.DumpLiveStmts, in order to test expressions liveness.
Differential Revision: https://reviews.llvm.org/D55566
llvm-svn: 349320
168 lines
4.2 KiB
C++
168 lines
4.2 KiB
C++
// RUN: %clang_analyze_cc1 -w -analyzer-checker=debug.DumpLiveStmts %s 2>&1\
|
|
// RUN: | FileCheck %s
|
|
|
|
int coin();
|
|
|
|
|
|
int testThatDumperWorks(int x, int y, int z) {
|
|
return x ? y : z;
|
|
}
|
|
// CHECK: [ B0 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B1 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B2 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-NEXT: DeclRefExpr {{.*}} 'y' 'int'
|
|
// CHECK-EMPTY:
|
|
// CHECK-NEXT: DeclRefExpr {{.*}} 'z' 'int'
|
|
// CHECK-EMPTY:
|
|
// CHECK-NEXT: ImplicitCastExpr {{.*}} <IntegralToBoolean>
|
|
// CHECK-NEXT: `-ImplicitCastExpr {{.*}} <LValueToRValue>
|
|
// CHECK-NEXT: `-DeclRefExpr {{.*}} 'x' 'int'
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B3 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-NEXT: DeclRefExpr {{.*}} 'y' 'int'
|
|
// CHECK-EMPTY:
|
|
// CHECK-NEXT: DeclRefExpr {{.*}} 'z' 'int'
|
|
// CHECK-EMPTY:
|
|
// CHECK-NEXT: ImplicitCastExpr {{.*}} <IntegralToBoolean>
|
|
// CHECK-NEXT: `-ImplicitCastExpr {{.*}} <LValueToRValue>
|
|
// CHECK-NEXT: `-DeclRefExpr {{.*}} 'x' 'int'
|
|
// CHECK: [ B4 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-NEXT: DeclRefExpr {{.*}} 'y' 'int'
|
|
// CHECK-EMPTY:
|
|
// CHECK-NEXT: DeclRefExpr {{.*}} 'z' 'int'
|
|
// CHECK-EMPTY:
|
|
// CHECK-NEXT: ImplicitCastExpr {{.*}} <IntegralToBoolean>
|
|
// CHECK-NEXT: `-ImplicitCastExpr {{.*}} <LValueToRValue>
|
|
// CHECK-NEXT: `-DeclRefExpr {{.*}} 'x' 'int'
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B5 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-NEXT: DeclRefExpr {{.*}} 'y' 'int'
|
|
// CHECK-EMPTY:
|
|
// CHECK-NEXT: DeclRefExpr {{.*}} 'z' 'int'
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
|
|
|
|
void testIfBranchExpression(bool flag) {
|
|
// No expressions should be carried over from one block to another here.
|
|
while (flag) {
|
|
int e = 1;
|
|
if (true)
|
|
e;
|
|
}
|
|
}
|
|
// CHECK: [ B0 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B1 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B2 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B3 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B4 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B5 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
|
|
|
|
void testWhileBodyExpression(bool flag) {
|
|
// No expressions should be carried over from one block to another here.
|
|
while (flag) {
|
|
int e = 1;
|
|
while (coin())
|
|
e;
|
|
}
|
|
}
|
|
// CHECK: [ B0 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B1 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B2 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B3 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B4 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B5 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
|
|
|
|
void testDoWhileBodyExpression(bool flag) {
|
|
// No expressions should be carried over from one block to another here.
|
|
while (flag) {
|
|
int e = 1;
|
|
do
|
|
e;
|
|
while (coin());
|
|
}
|
|
}
|
|
// CHECK: [ B0 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B1 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B2 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B3 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B4 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B5 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
|
|
|
|
void testForBodyExpression(bool flag) {
|
|
// No expressions should be carried over from one block to another here.
|
|
while (flag) {
|
|
int e = 1;
|
|
for (; coin();)
|
|
e;
|
|
}
|
|
}
|
|
// CHECK: [ B0 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B1 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B2 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B3 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B4 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
// CHECK: [ B5 (live statements at block exit) ]
|
|
// CHECK-EMPTY:
|
|
// CHECK-EMPTY:
|
|
|