e1ee3837ac
This fixes PR38549, which is silently accepted by ld.bfd.
This seems correct because it makes sense to let non-glob patterns take
precedence over glob patterns.
lld issues an error because
`assignWildcardVersion(ver, VER_NDX_LOCAL);` is processed before `assignExactVersion(ver, v.id, v.name);`.
Move all assignWildcardVersion() calls after assignExactVersion() calls
to fix this.
Also, move handleDynamicList() to the bottom. computeBinding() called by
includeInDynsym() has this cryptic rule:
if (versionId == VER_NDX_LOCAL && isDefined() && !isPreemptible)
return STB_LOCAL;
Before the change:
* foo's version is set to VER_NDX_LOCAL due to `local: *`
* handleDynamicList() is called
- foo.computeBinding() is STB_LOCAL
- foo.includeInDynsym() is false
- foo.isPreemptible is not set (wrong)
* foo's version is set to V1
After the change:
* foo's version is set to VER_NDX_LOCAL due to `local: *`
* foo's version is set to V1
* handleDynamicList() is called
- foo.computeBinding() is STB_GLOBAL
- foo.includeInDynsym() is true
- foo.isPreemptible is set (correct)
Reviewed By: ruiu
Differential Revision: https://reviews.llvm.org/D64550
llvm-svn: 365760
37 lines
1.5 KiB
ArmAsm
37 lines
1.5 KiB
ArmAsm
# REQUIRES: x86
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t.o
|
|
# RUN: echo '{ local: foo; };' > %tl.ver
|
|
# RUN: echo '{ global: foo; local: *; };' > %tg.ver
|
|
# RUN: echo 'V1 { global: foo; };' > %t1.ver
|
|
# RUN: echo 'V2 { global: foo; };' > %t2.ver
|
|
# RUN: echo 'V2 { global: notexist; local: f*; };' > %t2w.ver
|
|
|
|
## Note, ld.bfd errors on the two cases.
|
|
# RUN: ld.lld -shared %t.o --version-script %tl.ver --version-script %t1.ver \
|
|
# RUN: -o %t.so 2>&1 | FileCheck --check-prefix=LOCAL %s
|
|
# RUN: llvm-readelf --dyn-syms %t.so | FileCheck --check-prefix=LOCAL-SYM %s
|
|
# RUN: ld.lld -shared %t.o --version-script %tg.ver --version-script %t1.ver \
|
|
# RUN: -o %t.so 2>&1 | FileCheck --check-prefix=GLOBAL %s
|
|
# RUN: llvm-readelf --dyn-syms %t.so | FileCheck --check-prefix=GLOBAL-SYM %s
|
|
|
|
## Note, ld.bfd silently accepts this case.
|
|
# RUN: ld.lld -shared %t.o --version-script %t1.ver --version-script %t2.ver \
|
|
# RUN: -o %t.so 2>&1 | FileCheck --check-prefix=V1-WARN %s
|
|
# RUN: llvm-readelf --dyn-syms %t.so | FileCheck --check-prefix=V1-SYM %s
|
|
|
|
# RUN: ld.lld -shared %t.o --version-script %t1.ver --version-script %t2w.ver \
|
|
# RUN: -o %t.so --fatal-warnings
|
|
# RUN: llvm-readelf --dyn-syms %t.so | FileCheck --check-prefix=V1-SYM %s
|
|
|
|
# LOCAL: warning: attempt to reassign symbol 'foo' of VER_NDX_LOCAL to version 'V1'
|
|
# LOCAL-SYM-NOT: foo
|
|
|
|
# GLOBAL: warning: attempt to reassign symbol 'foo' of VER_NDX_GLOBAL to version 'V1'
|
|
# GLOBAL-SYM: foo{{$}}
|
|
|
|
# V1-WARN: warning: attempt to reassign symbol 'foo' of version 'V1' to version 'V2'
|
|
# V1-SYM: foo@@V1
|
|
|
|
.globl foo
|
|
foo:
|