8b3af63b89
A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
109 lines
3.3 KiB
C++
109 lines
3.3 KiB
C++
//===-- UtilityFunction.cpp -------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include <stdio.h>
|
|
#if HAVE_SYS_TYPES_H
|
|
#include <sys/types.h>
|
|
#endif
|
|
|
|
|
|
#include "lldb/Core/Module.h"
|
|
#include "lldb/Core/StreamFile.h"
|
|
#include "lldb/Expression/DiagnosticManager.h"
|
|
#include "lldb/Expression/FunctionCaller.h"
|
|
#include "lldb/Expression/IRExecutionUnit.h"
|
|
#include "lldb/Expression/UtilityFunction.h"
|
|
#include "lldb/Host/Host.h"
|
|
#include "lldb/Target/ExecutionContext.h"
|
|
#include "lldb/Target/Process.h"
|
|
#include "lldb/Target/Target.h"
|
|
#include "lldb/Utility/ConstString.h"
|
|
#include "lldb/Utility/Log.h"
|
|
#include "lldb/Utility/Stream.h"
|
|
|
|
using namespace lldb_private;
|
|
using namespace lldb;
|
|
|
|
/// Constructor
|
|
///
|
|
/// \param[in] text
|
|
/// The text of the function. Must be a full translation unit.
|
|
///
|
|
/// \param[in] name
|
|
/// The name of the function, as used in the text.
|
|
UtilityFunction::UtilityFunction(ExecutionContextScope &exe_scope,
|
|
const char *text, const char *name,
|
|
ExpressionKind kind)
|
|
: Expression(exe_scope, kind),
|
|
m_execution_unit_sp(), m_jit_module_wp(),
|
|
m_function_text(),
|
|
m_function_name(name) {}
|
|
|
|
UtilityFunction::~UtilityFunction() {
|
|
lldb::ProcessSP process_sp(m_jit_process_wp.lock());
|
|
if (process_sp) {
|
|
lldb::ModuleSP jit_module_sp(m_jit_module_wp.lock());
|
|
if (jit_module_sp)
|
|
process_sp->GetTarget().GetImages().Remove(jit_module_sp);
|
|
}
|
|
}
|
|
|
|
// FIXME: We should check that every time this is called it is called with the
|
|
// same return type & arguments...
|
|
|
|
FunctionCaller *UtilityFunction::MakeFunctionCaller(
|
|
const CompilerType &return_type, const ValueList &arg_value_list,
|
|
lldb::ThreadSP thread_to_use_sp, Status &error) {
|
|
if (m_caller_up)
|
|
return m_caller_up.get();
|
|
|
|
ProcessSP process_sp = m_jit_process_wp.lock();
|
|
if (!process_sp) {
|
|
error.SetErrorString("Can't make a function caller without a process.");
|
|
return nullptr;
|
|
}
|
|
|
|
Address impl_code_address;
|
|
impl_code_address.SetOffset(StartAddress());
|
|
std::string name(m_function_name);
|
|
name.append("-caller");
|
|
|
|
m_caller_up.reset(process_sp->GetTarget().GetFunctionCallerForLanguage(
|
|
Language(), return_type, impl_code_address, arg_value_list, name.c_str(),
|
|
error));
|
|
if (error.Fail()) {
|
|
|
|
return nullptr;
|
|
}
|
|
if (m_caller_up) {
|
|
DiagnosticManager diagnostics;
|
|
|
|
unsigned num_errors =
|
|
m_caller_up->CompileFunction(thread_to_use_sp, diagnostics);
|
|
if (num_errors) {
|
|
error.SetErrorStringWithFormat(
|
|
"Error compiling %s caller function: \"%s\".",
|
|
m_function_name.c_str(), diagnostics.GetString().c_str());
|
|
m_caller_up.reset();
|
|
return nullptr;
|
|
}
|
|
|
|
diagnostics.Clear();
|
|
ExecutionContext exe_ctx(process_sp);
|
|
|
|
if (!m_caller_up->WriteFunctionWrapper(exe_ctx, diagnostics)) {
|
|
error.SetErrorStringWithFormat(
|
|
"Error inserting caller function for %s: \"%s\".",
|
|
m_function_name.c_str(), diagnostics.GetString().c_str());
|
|
m_caller_up.reset();
|
|
return nullptr;
|
|
}
|
|
}
|
|
return m_caller_up.get();
|
|
}
|