A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
89 lines
2.2 KiB
C++
89 lines
2.2 KiB
C++
//===-- FileAction.cpp ------------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include <fcntl.h>
|
|
|
|
#include "lldb/Host/FileAction.h"
|
|
#include "lldb/Host/PosixApi.h"
|
|
#include "lldb/Utility/Stream.h"
|
|
|
|
using namespace lldb_private;
|
|
|
|
// FileAction member functions
|
|
|
|
FileAction::FileAction()
|
|
: m_action(eFileActionNone), m_fd(-1), m_arg(-1), m_file_spec() {}
|
|
|
|
void FileAction::Clear() {
|
|
m_action = eFileActionNone;
|
|
m_fd = -1;
|
|
m_arg = -1;
|
|
m_file_spec.Clear();
|
|
}
|
|
|
|
llvm::StringRef FileAction::GetPath() const { return m_file_spec.GetCString(); }
|
|
|
|
const FileSpec &FileAction::GetFileSpec() const { return m_file_spec; }
|
|
|
|
bool FileAction::Open(int fd, const FileSpec &file_spec, bool read,
|
|
bool write) {
|
|
if ((read || write) && fd >= 0 && file_spec) {
|
|
m_action = eFileActionOpen;
|
|
m_fd = fd;
|
|
if (read && write)
|
|
m_arg = O_NOCTTY | O_CREAT | O_RDWR;
|
|
else if (read)
|
|
m_arg = O_NOCTTY | O_RDONLY;
|
|
else
|
|
m_arg = O_NOCTTY | O_CREAT | O_WRONLY;
|
|
m_file_spec = file_spec;
|
|
return true;
|
|
} else {
|
|
Clear();
|
|
}
|
|
return false;
|
|
}
|
|
|
|
bool FileAction::Close(int fd) {
|
|
Clear();
|
|
if (fd >= 0) {
|
|
m_action = eFileActionClose;
|
|
m_fd = fd;
|
|
}
|
|
return m_fd >= 0;
|
|
}
|
|
|
|
bool FileAction::Duplicate(int fd, int dup_fd) {
|
|
Clear();
|
|
if (fd >= 0 && dup_fd >= 0) {
|
|
m_action = eFileActionDuplicate;
|
|
m_fd = fd;
|
|
m_arg = dup_fd;
|
|
}
|
|
return m_fd >= 0;
|
|
}
|
|
|
|
void FileAction::Dump(Stream &stream) const {
|
|
stream.PutCString("file action: ");
|
|
switch (m_action) {
|
|
case eFileActionClose:
|
|
stream.Printf("close fd %d", m_fd);
|
|
break;
|
|
case eFileActionDuplicate:
|
|
stream.Printf("duplicate fd %d to %d", m_fd, m_arg);
|
|
break;
|
|
case eFileActionNone:
|
|
stream.PutCString("no action");
|
|
break;
|
|
case eFileActionOpen:
|
|
stream.Printf("open fd %d with '%s', OFLAGS = 0x%x", m_fd,
|
|
m_file_spec.GetCString(), m_arg);
|
|
break;
|
|
}
|
|
}
|