Files
clang-p2996/lldb/tools/debugserver/source/MacOSX/CFString.h
Jonas Devlieghere 8b3af63b89 [NFC] Remove ASCII lines from comments
A lot of comments in LLDB are surrounded by an ASCII line to delimit the
begging and end of the comment.

Its use is not really consistent across the code base, sometimes the
lines are longer, sometimes they are shorter and sometimes they are
omitted. Furthermore, it looks kind of weird with the 80 column limit,
where the comment actually extends past the line, but not by much.
Furthermore, when /// is used for Doxygen comments, it looks
particularly odd. And when // is used, it incorrectly gives the
impression that it's actually a Doxygen comment.

I assume these lines were added to improve distinguishing between
comments and code. However, given that todays editors and IDEs do a
great job at highlighting comments, I think it's worth to drop this for
the sake of consistency. The alternative is fixing all the
inconsistencies, which would create a lot more churn.

Differential revision: https://reviews.llvm.org/D60508

llvm-svn: 358135
2019-04-10 20:48:55 +00:00

41 lines
1.5 KiB
C++

//===-- CFString.h ----------------------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//
// Created by Greg Clayton on 1/16/08.
//
//===----------------------------------------------------------------------===//
#ifndef __CFString_h__
#define __CFString_h__
#include "CFUtils.h"
#include <iosfwd>
class CFString : public CFReleaser<CFStringRef> {
public:
// Constructors and Destructors
CFString(CFStringRef cf_str = NULL);
CFString(const char *s, CFStringEncoding encoding = kCFStringEncodingUTF8);
CFString(const CFString &rhs);
CFString &operator=(const CFString &rhs);
virtual ~CFString();
const char *GetFileSystemRepresentation(std::string &str);
CFStringRef SetFileSystemRepresentation(const char *path);
CFStringRef SetFileSystemRepresentationFromCFType(CFTypeRef cf_type);
CFStringRef SetFileSystemRepresentationAndExpandTilde(const char *path);
const char *UTF8(std::string &str);
CFIndex GetLength() const;
static const char *UTF8(CFStringRef cf_str, std::string &str);
static const char *FileSystemRepresentation(CFStringRef cf_str,
std::string &str);
static const char *GlobPath(const char *path, std::string &expanded_path);
};
#endif // #ifndef __CFString_h__