A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
76 lines
2.0 KiB
C++
76 lines
2.0 KiB
C++
//===-- CFUtils.h -----------------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Created by Greg Clayton on 3/5/07.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef __CFUtils_h__
|
|
#define __CFUtils_h__
|
|
|
|
#include <CoreFoundation/CoreFoundation.h>
|
|
|
|
#ifdef __cplusplus
|
|
|
|
// Templatized CF helper class that can own any CF pointer and will
|
|
// call CFRelease() on any valid pointer it owns unless that pointer is
|
|
// explicitly released using the release() member function.
|
|
template <class T> class CFReleaser {
|
|
public:
|
|
// Type names for the avlue
|
|
typedef T element_type;
|
|
|
|
// Constructors and destructors
|
|
CFReleaser(T ptr = NULL) : _ptr(ptr) {}
|
|
CFReleaser(const CFReleaser ©) : _ptr(copy.get()) {
|
|
if (get())
|
|
::CFRetain(get());
|
|
}
|
|
virtual ~CFReleaser() { reset(); }
|
|
|
|
// Assignments
|
|
CFReleaser &operator=(const CFReleaser<T> ©) {
|
|
if (copy != *this) {
|
|
// Replace our owned pointer with the new one
|
|
reset(copy.get());
|
|
// Retain the current pointer that we own
|
|
if (get())
|
|
::CFRetain(get());
|
|
}
|
|
}
|
|
// Get the address of the contained type
|
|
T *ptr_address() { return &_ptr; }
|
|
|
|
// Access the pointer itself
|
|
const T get() const { return _ptr; }
|
|
T get() { return _ptr; }
|
|
|
|
// Set a new value for the pointer and CFRelease our old
|
|
// value if we had a valid one.
|
|
void reset(T ptr = NULL) {
|
|
if (ptr != _ptr) {
|
|
if (_ptr != NULL)
|
|
::CFRelease(_ptr);
|
|
_ptr = ptr;
|
|
}
|
|
}
|
|
|
|
// Release ownership without calling CFRelease
|
|
T release() {
|
|
T tmp = _ptr;
|
|
_ptr = NULL;
|
|
return tmp;
|
|
}
|
|
|
|
private:
|
|
element_type _ptr;
|
|
};
|
|
|
|
#endif // #ifdef __cplusplus
|
|
#endif // #ifndef __CFUtils_h__
|